diff options
| author | Andreas Fischer <bantu@phpbb.com> | 2012-12-14 01:50:22 +0100 |
|---|---|---|
| committer | Andreas Fischer <bantu@phpbb.com> | 2012-12-14 01:50:22 +0100 |
| commit | b5142296b182a4bf0d552aac565d90aa0befd07a (patch) | |
| tree | 55693645b3899359e363f8ddf0673bf0bf49257d /phpBB/includes/functions.php | |
| parent | 93222cf396192cc4e2d9a4dc741c60efda21404d (diff) | |
| parent | 89f069637cd95f584db924407378b64df9910243 (diff) | |
| download | forums-b5142296b182a4bf0d552aac565d90aa0befd07a.tar forums-b5142296b182a4bf0d552aac565d90aa0befd07a.tar.gz forums-b5142296b182a4bf0d552aac565d90aa0befd07a.tar.bz2 forums-b5142296b182a4bf0d552aac565d90aa0befd07a.tar.xz forums-b5142296b182a4bf0d552aac565d90aa0befd07a.zip | |
Merge remote-tracking branch 'p/ticket/11015' into develop
* p/ticket/11015: (30 commits)
[ticket/11015] Move comment in the right place.
[ticket/11015] Correctly transform 'mysqli' etc. in phpbb_convert_30_dbms_to_31
[ticket/11015] Fix 3.0 to 3.1 dbms conversion for mysqli.
[ticket/11015] Change permission adding in database updater to new style.
[ticket/11015] Change more docblocks to phpbb_db_driver.
[ticket/11015] Installer still needs 3.0-style dbms name.
[ticket/11015] Include functions.php because it is not always included.
[ticket/11015] Convert database drivers to new spelling in post setup sync.
[ticket/11015] Convert connect test to the new syntax.
[ticket/11015] Restore whitespace to avoid conflict when merging develop.
[ticket/11015] Fix functional test case.
[ticket/11015] Change more docblocks.
[ticket/11015] Include dbms name in exception message.
[ticket/11015] Make phpbb_convert_30_dbms_to_31 more future proof
[ticket/11015] Move db driver class name fixing to function
[ticket/11015] Allow full dbms class name in tests/test_config.php
[ticket/11015] Allow full dbms class name in config.php
[ticket/11015] Remove strange method_exists call
[tracker/11015] Prepend phpbb_db_driver_ for PHPBB_TEST_DBMS
[ticket/11015] Re-introduce accidentally removed require in install_convert
...
Diffstat (limited to 'phpBB/includes/functions.php')
| -rw-r--r-- | phpBB/includes/functions.php | 46 |
1 files changed, 46 insertions, 0 deletions
diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php index e492f97022..8ef5284134 100644 --- a/phpBB/includes/functions.php +++ b/phpBB/includes/functions.php @@ -5550,6 +5550,52 @@ function phpbb_to_numeric($input) } /** +* Convert either 3.0 dbms or 3.1 db driver class name to 3.1 db driver class name. +* +* If $dbms is a valid 3.1 db driver class name, returns it unchanged. +* Otherwise prepends phpbb_db_driver_ to the dbms to convert a 3.0 dbms +* to 3.1 db driver class name. +* +* @param string $dbms dbms parameter +* @return db driver class +*/ +function phpbb_convert_30_dbms_to_31($dbms) +{ + // Note: this check is done first because mysqli extension + // supplies a mysqli class, and class_exists($dbms) would return + // true for mysqli class. + // However, per the docblock any valid 3.1 driver name should be + // recognized by this function, and have priority over 3.0 dbms. + if (class_exists('phpbb_db_driver_' . $dbms)) + { + return 'phpbb_db_driver_' . $dbms; + } + + if (class_exists($dbms)) + { + // Additionally we could check that $dbms extends phpbb_db_driver. + // http://php.net/manual/en/class.reflectionclass.php + // Beware of possible performance issues: + // http://stackoverflow.com/questions/294582/php-5-reflection-api-performance + // We could check for interface implementation in all paths or + // only when we do not prepend phpbb_db_driver_. + + /* + $reflection = new \ReflectionClass($dbms); + + if ($reflection->isSubclassOf('phpbb_db_driver')) + { + return $dbms; + } + */ + + return $dbms; + } + + throw new \RuntimeException("You have specified an invalid dbms driver: $dbms"); +} + +/** * Create a Symfony Request object from phpbb_request object * * @param phpbb_request $request Request object |