diff options
| author | David M <davidmj@users.sourceforge.net> | 2008-02-03 10:19:04 +0000 |
|---|---|---|
| committer | David M <davidmj@users.sourceforge.net> | 2008-02-03 10:19:04 +0000 |
| commit | 7b262babcd5c862c3068b08da8bba5f48bd5f36a (patch) | |
| tree | 5b25f810cc36b33ba6ff406dab76377551e7688e /phpBB/includes/db/dbal.php | |
| parent | e9e9e8e69c3aee47d5bfbc24b2fb9f335cddf36a (diff) | |
| download | forums-7b262babcd5c862c3068b08da8bba5f48bd5f36a.tar forums-7b262babcd5c862c3068b08da8bba5f48bd5f36a.tar.gz forums-7b262babcd5c862c3068b08da8bba5f48bd5f36a.tar.bz2 forums-7b262babcd5c862c3068b08da8bba5f48bd5f36a.tar.xz forums-7b262babcd5c862c3068b08da8bba5f48bd5f36a.zip | |
Alright, this should give some improved performance :)
This is the end of random seek access to rows. If you have a compelling reason as to why they should stay, contact me. Else, they are gone forevermore...
The following API calls are deprecated:
acm::sql_rowseek() -> no replacement
$db->sql_fetchfield($field, $rownum = false, $query_id = false) -> $db->sql_fetchfield($field, $query_id = false)
Initial tests show that phpBB3 over four percent of memory against phpBB3.1 on an empty board. So far so good :)
Other cool things:
db2, MS SQL ODBC and MS SQL 2005 all use less memory because they do not need to reference the last executed query to handle random access seeks :)
P.S.
The crazy people using SVN: please report any issues with the new way we itterate through caches, I do not want to miss anything :)
git-svn-id: file:///svn/phpbb/trunk@8372 89ea8834-ac86-4346-8a33-228a782c2dd0
Diffstat (limited to 'phpBB/includes/db/dbal.php')
| -rw-r--r-- | phpBB/includes/db/dbal.php | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/phpBB/includes/db/dbal.php b/phpBB/includes/db/dbal.php index 5fd6de7f50..0444dcd816 100644 --- a/phpBB/includes/db/dbal.php +++ b/phpBB/includes/db/dbal.php @@ -192,9 +192,8 @@ class dbal /** * Fetch field - * if rownum is false, the current row is used, else it is pointing to the row (zero-based) */ - function sql_fetchfield($field, $rownum = false, $query_id = false) + function sql_fetchfield($field, $query_id = false) { global $cache; @@ -205,11 +204,6 @@ class dbal if ($query_id !== false) { - if ($rownum !== false) - { - $this->sql_rowseek($rownum, $query_id); - } - if (!is_object($query_id) && isset($cache->sql_rowset[$query_id])) { return $cache->sql_fetchfield($query_id, $field); |