aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes/acp
diff options
context:
space:
mode:
authorOliver Schramm <oliver.schramm97@gmail.com>2014-11-09 02:46:50 +0100
committerOliver Schramm <oliver.schramm97@gmail.com>2014-11-09 02:46:50 +0100
commit054ab67771c62fdb0c7e033428bbbfc2a7f9d63b (patch)
treef60ec12c92767647b976d68763d83c21f8328d78 /phpBB/includes/acp
parent101945acf98b7fb765a90288bc7dd403ee610dd5 (diff)
downloadforums-054ab67771c62fdb0c7e033428bbbfc2a7f9d63b.tar
forums-054ab67771c62fdb0c7e033428bbbfc2a7f9d63b.tar.gz
forums-054ab67771c62fdb0c7e033428bbbfc2a7f9d63b.tar.bz2
forums-054ab67771c62fdb0c7e033428bbbfc2a7f9d63b.tar.xz
forums-054ab67771c62fdb0c7e033428bbbfc2a7f9d63b.zip
[ticket/13310] Always use sql_build_query in acp_email.php
PHPBB3-13310
Diffstat (limited to 'phpBB/includes/acp')
-rw-r--r--phpBB/includes/acp/acp_email.php16
1 files changed, 10 insertions, 6 deletions
diff --git a/phpBB/includes/acp/acp_email.php b/phpBB/includes/acp/acp_email.php
index fe55b36e67..ebbdb288b6 100644
--- a/phpBB/includes/acp/acp_email.php
+++ b/phpBB/includes/acp/acp_email.php
@@ -72,11 +72,15 @@ class acp_email
if ($usernames)
{
// If giving usernames the admin is able to email inactive users too...
- $sql = 'SELECT username, user_email, user_jabber, user_notify_type, user_lang
- FROM ' . USERS_TABLE . '
- WHERE ' . $db->sql_in_set('username_clean', array_map('utf8_clean_string', explode("\n", $usernames))) . '
- AND user_allow_massemail = 1
- ORDER BY user_lang, user_notify_type'; // , SUBSTRING(user_email FROM INSTR(user_email, '@'))
+ $sql_ary = array(
+ 'SELECT' => 'username, user_email, user_jabber, user_notify_type, user_lang',
+ 'FROM' => array(
+ USERS_TABLE => '',
+ ),
+ 'WHERE' => $db->sql_in_set('username_clean', array_map('utf8_clean_string', explode("\n", $usernames))) . '
+ AND user_allow_massemail = 1',
+ 'ORDER_BY' => 'user_lang, user_notify_type',
+ );
}
else
{
@@ -123,8 +127,8 @@ class acp_email
),
);
}
- $sql = $db->sql_build_query('SELECT', $sql_ary);
}
+ $sql = $db->sql_build_query('SELECT', $sql_ary);
$result = $db->sql_query($sql);
$row = $db->sql_fetchrow($result);