diff options
| author | Henry Sudhof <kellanved@phpbb.com> | 2007-07-26 11:51:23 +0000 |
|---|---|---|
| committer | Henry Sudhof <kellanved@phpbb.com> | 2007-07-26 11:51:23 +0000 |
| commit | 4dc5afd639deb192051f5aab03b5a1bbb9d11367 (patch) | |
| tree | e577226e7f91302feed5624004105c3e867919a9 /phpBB/includes/acp/auth.php | |
| parent | 8a26bac6e24ff528f2cc8d919faadb3ed9ef8155 (diff) | |
| download | forums-4dc5afd639deb192051f5aab03b5a1bbb9d11367.tar forums-4dc5afd639deb192051f5aab03b5a1bbb9d11367.tar.gz forums-4dc5afd639deb192051f5aab03b5a1bbb9d11367.tar.bz2 forums-4dc5afd639deb192051f5aab03b5a1bbb9d11367.tar.xz forums-4dc5afd639deb192051f5aab03b5a1bbb9d11367.zip | |
Cleaning up a little. Mostly there are excellent reasons not to use sql_in_set.
Might be revisisted in the future.
#13797
git-svn-id: file:///svn/phpbb/trunk@7952 89ea8834-ac86-4346-8a33-228a782c2dd0
Diffstat (limited to 'phpBB/includes/acp/auth.php')
| -rw-r--r-- | phpBB/includes/acp/auth.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/phpBB/includes/acp/auth.php b/phpBB/includes/acp/auth.php index bc1ef75d1a..a5b6dba520 100644 --- a/phpBB/includes/acp/auth.php +++ b/phpBB/includes/acp/auth.php @@ -821,7 +821,7 @@ class auth_admin extends auth } // Remove current auth options... - $auth_option_ids = array(); + $auth_option_ids = array((int)$any_option_id); foreach ($auth as $auth_option => $auth_setting) { $auth_option_ids[] = (int) $this->option_ids[$auth_option]; @@ -830,7 +830,7 @@ class auth_admin extends auth $sql = "DELETE FROM $table WHERE $forum_sql AND $ug_id_sql - AND auth_option_id IN ($any_option_id, " . implode(', ', $auth_option_ids) . ')'; + AND ". $db->sql_in_set(auth_option_id, $auth_option_ids); $db->sql_query($sql); // Remove those having a role assigned... the correct type of course... |