diff options
| author | Fyorl <gaelreth@gmail.com> | 2012-08-10 13:08:12 +0100 |
|---|---|---|
| committer | Fyorl <gaelreth@gmail.com> | 2012-08-10 13:08:12 +0100 |
| commit | dd7be79fc33e38f5517dfca9041c03212440dd96 (patch) | |
| tree | 30c02c3e6abe0dd4f55f8a700c9d70dea4ab7bf7 /phpBB/download | |
| parent | 6dd0bd0bcec357ed82b9fe3dbaf6816d6f22d9ce (diff) | |
| download | forums-dd7be79fc33e38f5517dfca9041c03212440dd96.tar forums-dd7be79fc33e38f5517dfca9041c03212440dd96.tar.gz forums-dd7be79fc33e38f5517dfca9041c03212440dd96.tar.bz2 forums-dd7be79fc33e38f5517dfca9041c03212440dd96.tar.xz forums-dd7be79fc33e38f5517dfca9041c03212440dd96.zip | |
[feature/attach-dl] Removed strtolower and added comments
PHPBB3-11042
Diffstat (limited to 'phpBB/download')
| -rw-r--r-- | phpBB/download/file.php | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/phpBB/download/file.php b/phpBB/download/file.php index c4d6c26152..a5d7eada3f 100644 --- a/phpBB/download/file.php +++ b/phpBB/download/file.php @@ -376,7 +376,11 @@ else $bad_chars = array("'", "\\", ' ', '/', ':', '*', '?', '"', '<', '>', '|'); $clean_name = current($row); - $clean_name = rawurlencode(str_replace($bad_chars, '_', strtolower($clean_name))); + + // rawurlencode to convert any potentially 'bad' characters that we missed + $clean_name = rawurlencode(str_replace($bad_chars, '_', $clean_name)); + + // Turn the %xx entities created by rawurlencode to _ $clean_name = preg_replace("/%(\w{2})/", '_', $clean_name); $suffix = '_' . (($post_id) ? $post_id : $topic_id) . '_' . $clean_name; |