diff options
author | Callum Macrae <callum@lynxphp.com> | 2012-05-22 19:38:30 +0100 |
---|---|---|
committer | Callum Macrae <callum@lynxphp.com> | 2012-05-22 19:38:30 +0100 |
commit | 22cc7c73fdb26420bdf5b7a509da9a22925e274a (patch) | |
tree | 0b930101984415826e95759cbc50a05be312712e /phpBB/docs | |
parent | 06efa6c0beac3cb4fed0e7412c3b60f91f4181bb (diff) | |
download | forums-22cc7c73fdb26420bdf5b7a509da9a22925e274a.tar forums-22cc7c73fdb26420bdf5b7a509da9a22925e274a.tar.gz forums-22cc7c73fdb26420bdf5b7a509da9a22925e274a.tar.bz2 forums-22cc7c73fdb26420bdf5b7a509da9a22925e274a.tar.xz forums-22cc7c73fdb26420bdf5b7a509da9a22925e274a.zip |
[ticket/10855] Fixed a couple issues in coding guidelines.
PHPBB3-10855
Diffstat (limited to 'phpBB/docs')
-rw-r--r-- | phpBB/docs/coding-guidelines.html | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/phpBB/docs/coding-guidelines.html b/phpBB/docs/coding-guidelines.html index 237bc18d20..ae4655e094 100644 --- a/phpBB/docs/coding-guidelines.html +++ b/phpBB/docs/coding-guidelines.html @@ -301,7 +301,7 @@ PHPBB_QA (Set board to QA-Mode, which means the updater also c <p><code>$current_user</code> is right, but <code>$currentuser</code> and <code> $currentUser</code> are not.</p> </div> - <p>In JavaScript, variable names should use camel caps:</p> + <p>In JavaScript, variable names should use camel case:</p> <div class="indent"> <p><code>currentUser</code> is right, but <code>currentuser</code> and <code>current_user</code> are not.</p> @@ -532,7 +532,7 @@ $post_url = "{$phpbb_root_path}posting.$phpEx?mode=$mode&amp;start=$start"; <p>In SQL statements mixing single and double quotes is partly allowed (following the guidelines listed here about SQL formatting), else one should try to only use one method - mostly single quotes.</p> <h4>Commas after every array element:</h4> - <p>If an array is defined with each element on its own line, you still have to modify the previous line to add a comma when appending a new element. PHP allows for trailing (useless) commas in array definitions. These should always be used so each element including the comma can be appended with a single line. In JavaScript, you should not use the trailing comma, as IE doesn't like it.</p> + <p>If an array is defined with each element on its own line, you still have to modify the previous line to add a comma when appending a new element. PHP allows for trailing (useless) commas in array definitions. These should always be used so each element including the comma can be appended with a single line. In JavaScript, do not use the trailing comma, as it causes browsers to throw errors.</p> <p class="bad">// wrong</p> <div class="codebox"><pre> |