diff options
| author | David M <davidmj@users.sourceforge.net> | 2008-02-03 10:19:04 +0000 |
|---|---|---|
| committer | David M <davidmj@users.sourceforge.net> | 2008-02-03 10:19:04 +0000 |
| commit | 7b262babcd5c862c3068b08da8bba5f48bd5f36a (patch) | |
| tree | 5b25f810cc36b33ba6ff406dab76377551e7688e /phpBB/develop/add_permissions.php | |
| parent | e9e9e8e69c3aee47d5bfbc24b2fb9f335cddf36a (diff) | |
| download | forums-7b262babcd5c862c3068b08da8bba5f48bd5f36a.tar forums-7b262babcd5c862c3068b08da8bba5f48bd5f36a.tar.gz forums-7b262babcd5c862c3068b08da8bba5f48bd5f36a.tar.bz2 forums-7b262babcd5c862c3068b08da8bba5f48bd5f36a.tar.xz forums-7b262babcd5c862c3068b08da8bba5f48bd5f36a.zip | |
Alright, this should give some improved performance :)
This is the end of random seek access to rows. If you have a compelling reason as to why they should stay, contact me. Else, they are gone forevermore...
The following API calls are deprecated:
acm::sql_rowseek() -> no replacement
$db->sql_fetchfield($field, $rownum = false, $query_id = false) -> $db->sql_fetchfield($field, $query_id = false)
Initial tests show that phpBB3 over four percent of memory against phpBB3.1 on an empty board. So far so good :)
Other cool things:
db2, MS SQL ODBC and MS SQL 2005 all use less memory because they do not need to reference the last executed query to handle random access seeks :)
P.S.
The crazy people using SVN: please report any issues with the new way we itterate through caches, I do not want to miss anything :)
git-svn-id: file:///svn/phpbb/trunk@8372 89ea8834-ac86-4346-8a33-228a782c2dd0
Diffstat (limited to 'phpBB/develop/add_permissions.php')
| -rw-r--r-- | phpBB/develop/add_permissions.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/phpBB/develop/add_permissions.php b/phpBB/develop/add_permissions.php index 035c23f49c..956b830465 100644 --- a/phpBB/develop/add_permissions.php +++ b/phpBB/develop/add_permissions.php @@ -250,7 +250,7 @@ function mass_auth($ug_type, $forum_id, $ug_id, $acl_list, $setting) $sql = 'SELECT group_id FROM ' . GROUPS_TABLE . " WHERE group_name = '" . strtoupper($ug_id) . "'"; $result = $db->sql_query_limit($sql, 1); - $id = (int) $db->sql_fetchfield('group_id', 0, $result); + $id = (int) $db->sql_fetchfield('group_id', $result); $db->sql_freeresult($result); if (!$id) |