diff options
| author | Paul S. Owen <psotfx@users.sourceforge.net> | 2003-02-05 15:56:25 +0000 |
|---|---|---|
| committer | Paul S. Owen <psotfx@users.sourceforge.net> | 2003-02-05 15:56:25 +0000 |
| commit | e0a71f56ceedeb82ed40abc84c1dba9bd0cb3afa (patch) | |
| tree | eea5c571b1a2a5b22e94dba772723ed7ca942e07 /phpBB/admin | |
| parent | a6bf34acf644dfdb53e8dbf34ebdcb3d94b97ace (diff) | |
| download | forums-e0a71f56ceedeb82ed40abc84c1dba9bd0cb3afa.tar forums-e0a71f56ceedeb82ed40abc84c1dba9bd0cb3afa.tar.gz forums-e0a71f56ceedeb82ed40abc84c1dba9bd0cb3afa.tar.bz2 forums-e0a71f56ceedeb82ed40abc84c1dba9bd0cb3afa.tar.xz forums-e0a71f56ceedeb82ed40abc84c1dba9bd0cb3afa.zip | |
Group related updates
git-svn-id: file:///svn/phpbb/trunk@3455 89ea8834-ac86-4346-8a33-228a782c2dd0
Diffstat (limited to 'phpBB/admin')
| -rw-r--r-- | phpBB/admin/admin_groups.php | 198 |
1 files changed, 131 insertions, 67 deletions
diff --git a/phpBB/admin/admin_groups.php b/phpBB/admin/admin_groups.php index e055ac3e6a..01c42955f4 100644 --- a/phpBB/admin/admin_groups.php +++ b/phpBB/admin/admin_groups.php @@ -56,75 +56,137 @@ switch ($action) case 'edit': case 'addgroup': - if (isset($_POST['submit'])) + $error = ''; + + // Grab data, even when submitting updates + if ($action == 'edit') { - $group_name = (!empty($_POST['group_name'])) ? $_POST['group_name'] : ''; - $group_description = (!empty($_POST['group_description'])) ? $_POST['group_description'] : ''; - $group_type = (!empty($_POST['group_type'])) ? $_POST['group_type'] : ''; - $group_color = (!empty($_POST['group_color'])) ? $_POST['group_color'] : ''; - $group_rank = (!empty($_POST['group_rank'])) ? $_POST['group_rank'] : ''; + $sql = "SELECT * + FROM " . GROUPS_TABLE . " + WHERE group_id = $group_id"; + $result = $db->sql_query($sql); - $force_color = (!empty($_POST['force_color'])) ? true : false; + if (!extract($db->sql_fetchrow($result))) + { + trigger_error($user->lang['NO_GROUP']); + } + } + + // Did we submit? + if (isset($_POST['submit']) || isset($_POST['submitprefs'])) + { + if (isset($_POST['submit'])) + { + if ($group_type != GROUP_SPECIAL) + { + $group_name = (!empty($_POST['group_name'])) ? htmlspecialchars($_POST['group_name']) : ''; + $group_type = (!empty($_POST['group_type'])) ? intval($_POST['group_type']) : ''; + } + $group_description = (!empty($_POST['group_description'])) ? htmlspecialchars($_POST['group_description']) : ''; + $group_colour = (!empty($_POST['group_colour'])) ? htmlspecialchars($_POST['group_colour']) : ''; + $group_rank = (isset($_POST['group_rank'])) ? intval($_POST['group_rank']) : ''; + $group_avatar = (!empty($_POST['group_avatar'])) ? htmlspecialchars($_POST['group_avatar']) : ''; - // Check data + // Check data + if ($group_name == '' || strlen($group_name) > 40) + { + $error .= (($error != '') ? '<br />' : '') . (($group_name == '') ? $user->lang['GROUP_ERR_USERNAME'] : $user->lang['GROUP_ERR_USER_LONG']); + } + if (strlen($group_description) > 255) + { + $error .= (($error != '') ? '<br />' : '') . $user->lang['GROUP_ERR_DESC_LONG']; + } + if ($group_type < GROUP_OPEN || $group_type > GROUP_FREE) + { + $error .= (($error != '') ? '<br />' : '') . $user->lang['GROUP_ERR_TYPE']; + } + } + else + { + $user_lang = (!empty($_POST['user_lang'])) ? htmlspecialchars($_POST['user_lang']) : ''; + $user_tz = (isset($_POST['user_tz'])) ? doubleval($_POST['user_tz']) : ''; + $user_dst = (isset($_POST['user_dst'])) ? intval($_POST['user_dst']) : ''; + } - if ($group_color != '') + // Update DB + if (!$error) { - $color_sql = (!$force_color) ? "AND user_colour = ''" : ''; + // Update group preferences + $sql = "UPDATE " . GROUPS_TABLE . " + SET group_name = '$group_name', group_description = '$group_description', group_type = $group_type, group_rank = $group_rank, group_colour = '$group_colour' + WHERE group_id = $group_id"; + $db->sql_query($sql); + + $user_sql = ''; + $user_sql .= (isset($_POST['submit'])) ? ((($user_sql != '') ? ', ' : '') . "user_colour = '$group_colour'") : ''; + $user_sql .= (isset($_POST['submit']) && $group_rank != -1) ? ((($user_sql != '') ? ', ' : '') . "user_rank = $group_rank") : ''; + $user_sql .= (isset($_POST['submitprefs']) && $user_lang != -1) ? ((($user_sql != '') ? ', ' : '') . "user_lang = '$user_lang'") : ''; + $user_sql .= (isset($_POST['submitprefs']) && $user_tz != -14) ? ((($user_sql != '') ? ', ' : '') . "user_timezone = $user_tz") : ''; + $user_sql .= (isset($_POST['submitprefs']) && $user_dst != -1) ? ((($user_sql != '') ? ', ' : '') . "user_dst = $user_dst") : ''; + + // Update group members preferences switch (SQL_LAYER) { case 'mysql': case 'mysql4': - $sql = "SELECT user_id - FROM " . USER_GROUP_TABLE . " - WHERE group_id = $group_id"; - $result = $db->sql_query($sql); - - if ($row = $db->sql_fetchrow($result)) + // batchwise? 500 at a time or so maybe? try to reduce memory useage + $more = true; + $start = 0; + do { - $user_id_sql = ''; - do + $sql = "SELECT user_id + FROM " . USER_GROUP_TABLE . " + WHERE group_id = $group_id + LIMIT $start, 500"; + $result = $db->sql_query($sql); + + if ($row = $db->sql_fetchrow($result)) { - $user_id_sql .= (($user_id_sql != '') ? ', ' : '') . $row['user_id']; + $user_count = 0; + $user_id_sql = ''; + do + { + $user_id_sql .= (($user_id_sql != '') ? ', ' : '') . $row['user_id']; + $user_count++; + } + while ($row = $db->sql_fetchrow($result)); + + $sql = "UPDATE " . USERS_TABLE . " + SET $user_sql + WHERE user_id IN ($user_id_sql)"; + $db->sql_query($sql); + + if ($user_count == 500) + { + $start += 500; + } + else + { + $more = false; + } } - while ($row = $db->sql_fetchrow($result)); - - $sql = "UPDATE " . USERS_TABLE . " - SET user_colour = '$group_color' - WHERE user_id IN ($user_id_sql) - $color_sql"; - $db->sql_query($sql); + else + { + $more = false; + } + $db->sql_freeresult($result); + unset($user_id_sql); } - $db->sql_freeresult($result); - unset($user_id_sql); + while ($more); break; default: $sql = "UPDATE " . USERS_TABLE . " - SET user_colour = '$group_color' + SET $user_sql WHERE user_id IN ( SELECT user_id FROM " . USER_GROUP_TABLE . " - WHERE group_id = $group_id) - $color_sql"; + WHERE group_id = $group_id)"; $db->sql_query($sql); } - trigger_error('Done'); - } - } - - if ($action == 'edit' && empty($_POST['submit'])) - { - $sql = "SELECT * - FROM " . GROUPS_TABLE . " - WHERE group_id = $group_id"; - $result = $db->sql_query($sql); - - if (!extract($db->sql_fetchrow($result))) - { - trigger_error($user->lang['NO_GROUP']); + trigger_error($user->lang['GROUP_UPDATED']); } } @@ -158,9 +220,6 @@ switch ($action) $type_hidden = ($group_type == GROUP_HIDDEN) ? ' checked="checked"' : ''; $type_free = ($group_type == GROUP_FREE) ? ' checked="checked"' : ''; - $force_color_yes = (!isset($force_color) || $force_color) ? ' checked="checked"' : ''; - $force_color_no = (isset($force_color) && !$force_color) ? ' checked="checked"' : ''; - ?> <script language="javascript" type="text/javascript"> @@ -168,17 +227,31 @@ switch ($action) function swatch() { - window.open('./swatch.php?form=settings&name=group_color', '_swatch', 'HEIGHT=115,resizable=yes,scrollbars=no,WIDTH=636'); + window.open('./swatch.php?form=settings&name=group_colour', '_swatch', 'HEIGHT=115,resizable=yes,scrollbars=no,WIDTH=636'); return false; } //--> </script> -<form name="settings" method="post" action="admin_groups.<?php echo "$phpEx$SID&action=edit&g=$group_id"; ?>"><table class="bg" width="90%" cellspacing="1" cellpadding="4" border="0" align="center"> +<form name="settings" method="post" action="admin_groups.<?php echo "$phpEx$SID&action=$action&g=$group_id"; ?>"><table class="bg" width="90%" cellspacing="1" cellpadding="4" border="0" align="center"> <tr> <th colspan="2"><?php echo $user->lang['GROUP_DETAILS']; ?></th> </tr> +<?php + + if ($error != '') + { + +?> + <tr> + <td class="row1" colspan="2" align="center"><span style="color:red"><?php echo $error; ?></span></td> + </tr> +<?php + + } + +?> <tr> <td class="row2"><?php echo $user->lang['GROUP_NAME']; ?>:</td> <td class="row1"><?php @@ -222,27 +295,18 @@ function swatch() </tr> <tr> <td class="row2"><?php echo $user->lang['GROUP_COLOR']; ?>:<br /><span class="gensmall"><?php echo sprintf($user->lang['GROUP_COLOR_EXPLAIN'], '<a href="swatch.html" onclick="swatch();return false" target="_swatch">', '</a>'); ?></span></td> - <td class="row1" nowrap="nowrap"><input type="text" name="group_color" value="<?php echo (!empty($group_color)) ? $group_color : ''; ?>" size="6" maxlength="6" /> <input type="radio" name="force_color" value="1"<?php echo $force_color_yes; ?> /> <?php echo $user->lang['FORCE_COLOR']; ?> <input type="radio" name="force_color" value="0"<?php echo $force_color_no; ?> /> <?php echo $user->lang['USER_COLOR']; ?></td> + <td class="row1" nowrap="nowrap"><input type="text" name="group_colour" value="<?php echo (!empty($group_colour)) ? $group_colour : ''; ?>" size="6" maxlength="6" /></td> </tr> <tr> <td class="row2"><?php echo $user->lang['GROUP_RANK']; ?>:</td> <td class="row1"><select name="group_rank"><?php echo $rank_options; ?></select></td> </tr> - <tr> + <!-- tr> <td class="row2"><?php echo $user->lang['GROUP_AVATAR']; ?>:<br /><span class="gensmall"><?php echo $user->lang['GROUP_AVATAR_EXPLAIN']; ?></span></td> <td class="row1"> </td> - </tr> + </tr --> <tr> - <td class="cat" colspan="2" align="center"><?php - - if ($group_type == GROUP_SPECIAL) - { - -?><input type="hidden" name="group_type" value="<?php echo GROUP_SPECIAL; ?>" /><?php - - } - -?><input class="mainoption" type="submit" name="submit" value="<?php echo $user->lang['SUBMIT']; ?>" /> <input class="liteoption" type="reset" value="<?php echo $user->lang['RESET']; ?>" /></td> + <td class="cat" colspan="2" align="center"><input class="mainoption" type="submit" name="submit" value="<?php echo $user->lang['SUBMIT']; ?>" /> <input class="liteoption" type="reset" value="<?php echo $user->lang['RESET']; ?>" /></td> </tr> </table></form> @@ -256,15 +320,15 @@ function swatch() </tr> <tr> <td class="row2"><?php echo $user->lang['GROUP_LANG']; ?>:</td> - <td class="row1"><select name="tz"><?php echo '<option value="-1" selected="selected">' . $user->lang['USER_DEFAULT'] . '</option>' . language_select(); ?></select></td> + <td class="row1"><select name="user_lang"><?php echo '<option value="-1" selected="selected">' . $user->lang['USER_DEFAULT'] . '</option>' . language_select(); ?></select></td> </tr> <tr> <td class="row2"><?php echo $user->lang['GROUP_TIMEZONE']; ?>:</td> - <td class="row1"><select name="tz"><?php echo '<option value="-1" selected="selected">' . $user->lang['USER_DEFAULT'] . '</option>' . tz_select(); ?></select></td> + <td class="row1"><select name="user_tz"><?php echo '<option value="-14" selected="selected">' . $user->lang['USER_DEFAULT'] . '</option>' . tz_select(); ?></select></td> </tr> <tr> <td class="row2"><?php echo $user->lang['GROUP_DST']; ?>:</td> - <td class="row1" nowrap="nowrap"><input type="radio" name="dst" value="0" /> <?php echo $user->lang['DISABLED']; ?> <input type="radio" name="dst" value="1" /> <?php echo $user->lang['ENABLED']; ?> <input type="radio" name="dst" value="-1" checked="checked" /> <?php echo $user->lang['USER_DEFAULT']; ?></td> + <td class="row1" nowrap="nowrap"><input type="radio" name="user_dst" value="0" /> <?php echo $user->lang['DISABLED']; ?> <input type="radio" name="user_dst" value="1" /> <?php echo $user->lang['ENABLED']; ?> <input type="radio" name="user_dst" value="-1" checked="checked" /> <?php echo $user->lang['USER_DEFAULT']; ?></td> </tr> <tr> <td class="cat" colspan="2" align="center"><?php @@ -276,7 +340,7 @@ function swatch() } -?><input class="mainoption" type="submit" name="submit" value="<?php echo $user->lang['SUBMIT']; ?>" /> <input class="liteoption" type="reset" value="<?php echo $user->lang['RESET']; ?>" /></td> +?><input class="mainoption" type="submit" name="submitprefs" value="<?php echo $user->lang['SUBMIT']; ?>" /> <input class="liteoption" type="reset" value="<?php echo $user->lang['RESET']; ?>" /></td> </tr> </table></form> |