diff options
| author | Paul S. Owen <psotfx@users.sourceforge.net> | 2002-07-16 12:28:12 +0000 |
|---|---|---|
| committer | Paul S. Owen <psotfx@users.sourceforge.net> | 2002-07-16 12:28:12 +0000 |
| commit | 3a453527cb3c8357ce146075584cc67cc66d2abe (patch) | |
| tree | 38e8123d2e4fe529b02c02bfc851edd9b5c503a0 /phpBB/admin/admin_ranks.php | |
| parent | 14927f5445b50ec7d8709ab060a515865faba27c (diff) | |
| download | forums-3a453527cb3c8357ce146075584cc67cc66d2abe.tar forums-3a453527cb3c8357ce146075584cc67cc66d2abe.tar.gz forums-3a453527cb3c8357ce146075584cc67cc66d2abe.tar.bz2 forums-3a453527cb3c8357ce146075584cc67cc66d2abe.tar.xz forums-3a453527cb3c8357ce146075584cc67cc66d2abe.zip | |
Minor changes
git-svn-id: file:///svn/phpbb/trunk@2686 89ea8834-ac86-4346-8a33-228a782c2dd0
Diffstat (limited to 'phpBB/admin/admin_ranks.php')
| -rw-r--r-- | phpBB/admin/admin_ranks.php | 142 |
1 files changed, 67 insertions, 75 deletions
diff --git a/phpBB/admin/admin_ranks.php b/phpBB/admin/admin_ranks.php index 33546a91d3..f2f965fe31 100644 --- a/phpBB/admin/admin_ranks.php +++ b/phpBB/admin/admin_ranks.php @@ -8,7 +8,6 @@ * * $Id$ * - * ***************************************************************************/ /*************************************************************************** @@ -24,6 +23,11 @@ define('IN_PHPBB', 1); if( !empty($setmodules) ) { + if ( !$acl->get_acl_admin('user') ) + { + return; + } + $file = basename(__FILE__); $module['Users']['Ranks'] = "$file"; return; @@ -32,11 +36,22 @@ if( !empty($setmodules) ) // // Let's set the root dir for phpBB // -$phpbb_root_path = "../"; +$phpbb_root_path = '../'; require($phpbb_root_path . 'extension.inc'); require('pagestart.' . $phpEx); -if( isset($HTTP_GET_VARS['mode']) || isset($HTTP_POST_VARS['mode']) ) +// +// +// +if ( !$acl->get_acl_admin('user') ) +{ + return; +} + +// +// +// +if ( isset($HTTP_GET_VARS['mode']) || isset($HTTP_POST_VARS['mode']) ) { $mode = ($HTTP_GET_VARS['mode']) ? $HTTP_GET_VARS['mode'] : $HTTP_POST_VARS['mode']; } @@ -45,45 +60,42 @@ else // // These could be entered via a form button // - if( isset($HTTP_POST_VARS['add']) ) + if ( isset($HTTP_POST_VARS['add']) ) { - $mode = "add"; + $mode = 'add'; } - else if( isset($HTTP_POST_VARS['save']) ) + else if ( isset($HTTP_POST_VARS['save']) ) { - $mode = "save"; + $mode = 'save'; } else { - $mode = ""; + $mode = ''; } } -if( $mode != "" ) +if ( $mode != '' ) { - if( $mode == "edit" || $mode == "add" ) + if ( $mode == 'edit' || $mode == 'add' ) { // // They want to add a new rank, show the form. // $rank_id = ( isset($HTTP_GET_VARS['id']) ) ? intval($HTTP_GET_VARS['id']) : 0; - $s_hidden_fields = ""; + $s_hidden_fields = ''; - if( $mode == "edit" ) + if ( $mode == 'edit' ) { - if( empty($rank_id) ) + if ( empty($rank_id) ) { - message_die(GENERAL_MESSAGE, $lang['Must_select_rank']); + message_die(MESSAGE, $lang['Must_select_rank']); } $sql = "SELECT * FROM " . RANKS_TABLE . " WHERE rank_id = $rank_id"; - if(!$result = $db->sql_query($sql)) - { - message_die(GENERAL_ERROR, "Couldn't obtain rank data", "", __LINE__, __FILE__, $sql); - } + $result = $db->sql_query($sql); $rank_info = $db->sql_fetchrow($result); $s_hidden_fields .= '<input type="hidden" name="id" value="' . $rank_id . '" />'; @@ -96,20 +108,20 @@ if( $mode != "" ) $s_hidden_fields .= '<input type="hidden" name="mode" value="save" />'; - $rank_is_special = ( $rank_info['rank_special'] ) ? "checked=\"checked\"" : ""; - $rank_is_not_special = ( !$rank_info['rank_special'] ) ? "checked=\"checked\"" : ""; + $rank_is_special = ( $rank_info['rank_special'] ) ? ' checked="checked"' : ''; + $rank_is_not_special = ( !$rank_info['rank_special'] ) ? ' checked="checked"' : ''; $template->set_filenames(array( - "body" => "admin/ranks_edit_body.tpl") + 'body' => 'admin/ranks_edit_body.tpl') ); $template->assign_vars(array( "RANK" => $rank_info['rank_title'], "SPECIAL_RANK" => $rank_is_special, "NOT_SPECIAL_RANK" => $rank_is_not_special, - "MINIMUM" => ( $rank_is_special ) ? "" : $rank_info['rank_min'], - "IMAGE" => ( $rank_info['rank_image'] != "" ) ? $rank_info['rank_image'] : "", - "IMAGE_DISPLAY" => ( $rank_info['rank_image'] != "" ) ? '<img src="../' . $rank_info['rank_image'] . '" />' : "", + "MINIMUM" => ( $rank_is_special ) ? '' : $rank_info['rank_min'], + "IMAGE" => ( $rank_info['rank_image'] != '' ) ? $rank_info['rank_image'] : '', + "IMAGE_DISPLAY" => ( $rank_info['rank_image'] != '' ) ? '<img src="../' . $rank_info['rank_image'] . '" />' : '', "L_RANKS_TITLE" => $lang['Ranks_title'], "L_RANKS_TEXT" => $lang['Ranks_explain'], @@ -123,29 +135,29 @@ if( $mode != "" ) "L_YES" => $lang['Yes'], "L_NO" => $lang['No'], - "S_RANK_ACTION" => append_sid("admin_ranks.$phpEx"), + "S_RANK_ACTION" => "admin_ranks.$phpEx$SID", "S_HIDDEN_FIELDS" => $s_hidden_fields) ); } - else if( $mode == "save" ) + else if ( $mode == 'save' ) { // // Ok, they sent us our info, let's update it. // $rank_id = ( isset($HTTP_POST_VARS['id']) ) ? intval($HTTP_POST_VARS['id']) : 0; - $rank_title = ( isset($HTTP_POST_VARS['title']) ) ? trim($HTTP_POST_VARS['title']) : ""; + $rank_title = ( isset($HTTP_POST_VARS['title']) ) ? trim($HTTP_POST_VARS['title']) : ''; $special_rank = ( $HTTP_POST_VARS['special_rank'] == 1 ) ? TRUE : 0; $min_posts = ( isset($HTTP_POST_VARS['min_posts']) ) ? intval($HTTP_POST_VARS['min_posts']) : -1; - $rank_image = ( (isset($HTTP_POST_VARS['rank_image'])) ) ? trim($HTTP_POST_VARS['rank_image']) : ""; + $rank_image = ( (isset($HTTP_POST_VARS['rank_image'])) ) ? trim($HTTP_POST_VARS['rank_image']) : ''; - if( $rank_title == "" ) + if ( $rank_title == "" ) { - message_die(GENERAL_MESSAGE, $lang['Must_select_rank']); + message_die(MESSAGE, $lang['Must_select_rank']); } - if( $special_rank == 1 ) + if ( $special_rank == 1 ) { $max_posts = -1; $min_posts = -1; @@ -154,11 +166,11 @@ if( $mode != "" ) // // The rank image has to be a jpg, gif or png // - if($rank_image != "") + if ( $rank_image != '' ) { - if ( !preg_match("/(\.gif|\.png|\.jpg)$/is", $rank_image)) + if ( !preg_match('/(\.gif|\.png|\.jpg)$/is', $rank_image)) { - $rank_image = ""; + $rank_image = ''; } } @@ -178,23 +190,20 @@ if( $mode != "" ) $message = $lang['Rank_added']; } - if( !$result = $db->sql_query($sql) ) - { - message_die(GENERAL_ERROR, "Couldn't update/insert into ranks table", "", __LINE__, __FILE__, $sql); - } + $db->sql_query($sql); - $message .= "<br /><br />" . sprintf($lang['Click_return_rankadmin'], "<a href=\"" . append_sid("admin_ranks.$phpEx") . "\">", "</a>") . "<br /><br />" . sprintf($lang['Click_return_admin_index'], "<a href=\"" . append_sid("index.$phpEx?pane=right") . "\">", "</a>"); + $message .= '<br /><br />' . sprintf($lang['Click_return_rankadmin'], '<a href="' . "admin_ranks.$phpEx$SID" . '">', '</a>') . '<br /><br />' . sprintf($lang['Click_return_admin_index'], '<a href="' . "index.$phpEx$SID&pane=right" . '">', '</a>'); - message_die(GENERAL_MESSAGE, $message); + message_die(MESSAGE, $message); } - else if( $mode == "delete" ) + else if ( $mode == 'delete' ) { // // Ok, they want to delete their rank // - if( isset($HTTP_POST_VARS['id']) || isset($HTTP_GET_VARS['id']) ) + if ( isset($HTTP_POST_VARS['id']) || isset($HTTP_GET_VARS['id']) ) { $rank_id = ( isset($HTTP_POST_VARS['id']) ) ? intval($HTTP_POST_VARS['id']) : intval($HTTP_GET_VARS['id']); } @@ -203,33 +212,25 @@ if( $mode != "" ) $rank_id = 0; } - if( $rank_id ) + if ( $rank_id ) { $sql = "DELETE FROM " . RANKS_TABLE . " WHERE rank_id = $rank_id"; - - if( !$result = $db->sql_query($sql) ) - { - message_die(GENERAL_ERROR, "Couldn't delete rank data", "", __LINE__, __FILE__, $sql); - } + $db->sql_query($sql); $sql = "UPDATE " . USERS_TABLE . " SET user_rank = 0 WHERE user_rank = $rank_id"; + $db->sql_query($sql); - if( !$result = $db->sql_query($sql) ) - { - message_die(GENERAL_ERROR, $lang['No_update_ranks'], "", __LINE__, __FILE__, $sql); - } - - $message = $lang['Rank_removed'] . "<br /><br />" . sprintf($lang['Click_return_rankadmin'], "<a href=\"" . append_sid("admin_ranks.$phpEx") . "\">", "</a>") . "<br /><br />" . sprintf($lang['Click_return_admin_index'], "<a href=\"" . append_sid("index.$phpEx?pane=right") . "\">", "</a>"); + $message = $lang['Rank_removed'] . '<br /><br />' . sprintf($lang['Click_return_rankadmin'], '<a href="' . "admin_ranks.$phpEx$SID" . '">', '</a>') . '<br /><br />' . sprintf($lang['Click_return_admin_index'], '<a href="' . "index.$phpEx$SID&pane=right" . '">', '</a>'); - message_die(GENERAL_MESSAGE, $message); + message_die(MESSAGE, $message); } else { - message_die(GENERAL_MESSAGE, $lang['Must_select_rank']); + message_die(MESSAGE, $lang['Must_select_rank']); } } else @@ -244,10 +245,7 @@ if( $mode != "" ) $sql = "SELECT * FROM " . RANKS_TABLE . " ORDER BY rank_min, rank_title"; - if( !$result = $db->sql_query($sql) ) - { - message_die(GENERAL_ERROR, "Couldn't obtain ranks data", "", __LINE__, __FILE__, $sql); - } + $result = $db->sql_query($sql); $rank_rows = $db->sql_fetchrowset($result); $rank_count = count($rank_rows); @@ -263,7 +261,7 @@ if( $mode != "" ) "L_ADD_RANK" => $lang['Add_new_rank'], "L_ACTION" => $lang['Action'], - "S_RANKS_ACTION" => append_sid("admin_ranks.$phpEx")) + "S_RANKS_ACTION" => "admin_ranks.$phpEx$SID") ); for( $i = 0; $i < $rank_count; $i++) @@ -289,8 +287,8 @@ if( $mode != "" ) "SPECIAL_RANK" => ( $special_rank == 1 ) ? $lang['Yes'] : $lang['No'], - "U_RANK_EDIT" => append_sid("admin_ranks.$phpEx?mode=edit&id=$rank_id"), - "U_RANK_DELETE" => append_sid("admin_ranks.$phpEx?mode=delete&id=$rank_id")) + "U_RANK_EDIT" => "admin_ranks.$phpEx$SID&mode=edit&id=$rank_id", + "U_RANK_DELETE" => "admin_ranks.$phpEx$SID&mode=delete&id=$rank_id") ); } } @@ -306,11 +304,7 @@ else $sql = "SELECT * FROM " . RANKS_TABLE . " ORDER BY rank_min ASC, rank_special ASC"; - if( !$result = $db->sql_query($sql) ) - { - message_die(GENERAL_ERROR, "Couldn't obtain ranks data", "", __LINE__, __FILE__, $sql); - } - $rank_count = $db->sql_numrows($result); + $result = $db->sql_query($sql); $rank_rows = $db->sql_fetchrowset($result); @@ -325,7 +319,7 @@ else "L_ADD_RANK" => $lang['Add_new_rank'], "L_ACTION" => $lang['Action'], - "S_RANKS_ACTION" => append_sid("admin_ranks.$phpEx")) + "S_RANKS_ACTION" => "admin_ranks.$phpEx$SID") ); for($i = 0; $i < $rank_count; $i++) @@ -335,7 +329,7 @@ else $rank_id = $rank_rows[$i]['rank_id']; $rank_min = $rank_rows[$i]['rank_min']; - if( $special_rank == 1 ) + if ( $special_rank == 1 ) { $rank_min = $rank_max = "-"; } @@ -352,14 +346,12 @@ else "SPECIAL_RANK" => $rank_is_special, "RANK_MIN" => $rank_min, - "U_RANK_EDIT" => append_sid("admin_ranks.$phpEx?mode=edit&id=$rank_id"), - "U_RANK_DELETE" => append_sid("admin_ranks.$phpEx?mode=delete&id=$rank_id")) + "U_RANK_EDIT" => "admin_ranks.$phpEx$SID&mode=edit&id=$rank_id", + "U_RANK_DELETE" => "admin_ranks.$phpEx$SID&mode=delete&id=$rank_id") ); } } -$template->pparse("body"); - include('page_footer_admin.'.$phpEx); -?> +?>
\ No newline at end of file |
