Merge branch 'develop' of github.com:phpbb/phpbb3 into ticket/11667

# By Joas Schilling (224) and others
# Via Andreas Fischer (23) and others
* 'develop' of github.com:phpbb/phpbb3: (385 commits)
  [ticket/11734] Readd accidently removed language strings of forum permissions
  [ticket/11620] Whitespace and combine function into test_case
  [ticket/11620] Move check_ban_test functions to setUp/tearDown for clarity
  [ticket/11620] Changed incorrect global variable
  [ticket/11620] Minor indentation changes and comment clarity
  [ticket/11733] Fix "Illegal offset type" Warning caused by overall feed
  [ticket/11733] Add browse test for feed.php
  [ticket/11731] Remove static calls to captcha garbage collector
  [ticket/11728] Replace topic_approved with topic_visibility
  [ticket/11620] Expected and actual test conditions wrongly swapped
  [ticket/11620] Space between . in directory import concatenation
  [ticket/11620] Changes to match merge
  [ticket/11620] Changes for code guidelines consistency
  [ticket/11620] Fix a static calls to non-static for session captcha
  [ticket/11620] Cleanup creation_test that was renamed on a cherry-pick
  [ticket/11620] Update auth_provider for new interface
  [ticket/11620] Added garbage_collection_test
  [ticket/11620] Fixed check_ban_test errors with cache and ban warning message
  [ticket/11620] Fixed a typo on check_ban_test
  [ticket/11620]  Refactored check_isvalid_test to use session_test_case
  ...

1 files changed, 30 insertions, 14 deletions

diff --git a/build/build.xml b/build/build.xml
index 02518ac441..f8181160c1 100644
--- a/build/build.xml
+++ b/build/build.xml
@@ -169,26 +169,42 @@
 			command="git archive ${revision} | tar -xf - -C ../${dir}"
 			checkreturn="true" />
 
-		<!--
-			If composer.phar exists in this version of the tree, also export
-			it into ${dir}, install dependencies, then delete it again.
-		-->
-		<exec dir="."
-			command="git ls-tree ${revision} composer.phar"
+		<!-- Install composer dependencies, if there are any. -->
+		<exec dir="${dir}"
+			command='php -r "\$j = json_decode(file_get_contents(\"composer.json\")); echo isset(\$j->require);"'
 			checkreturn="true"
-			outputProperty='composer-ls-tree-output' />
+			outputProperty='composer-has-dependencies' />
 		<if>
-			<not><equals arg1="${composer-ls-tree-output}" arg2="" trim="true" /></not>
+			<equals arg1="${composer-has-dependencies}" arg2="1" trim="true" />
 			<then>
+				<!-- We have non-dev composer dependencies -->
 				<exec dir="."
-					command="git archive ${revision} composer.phar | tar -xf - -C ${dir}"
-					checkreturn="true" />
-				<exec dir="${dir}"
-					command="php composer.phar install"
+					command="git ls-tree ${revision} composer.phar"
 					checkreturn="true"
-					passthru="true" />
-				<delete file="${dir}/composer.phar" />
+					outputProperty='composer-ls-tree-output' />
+				<if>
+					<equals arg1="${composer-ls-tree-output}" arg2="" trim="true" />
+					<then>
+						<fail message="There are composer dependencies, but composer.phar is missing." />
+					</then>
+					<else>
+						<!-- Export the phar, install dependencies, delete phar. -->
+						<exec dir="."
+							command="git archive ${revision} composer.phar | tar -xf - -C ${dir}"
+							checkreturn="true" />
+						<exec dir="${dir}"
+							command="php composer.phar install"
+							checkreturn="true"
+							passthru="true" />
+						<delete file="${dir}/composer.phar" />
+					</else>
+				</if>
 			</then>
+			<else>
+				<!-- We do not have composer dependencies, do not ship composer files -->
+				<delete file="${dir}/composer.json" />
+				<delete file="${dir}/composer.lock" />
+			</else>
 		</if>
 
 		<delete file="${dir}/config.php" />