aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMeik Sievertsen <acydburn@phpbb.com>2008-02-01 12:45:05 +0000
committerMeik Sievertsen <acydburn@phpbb.com>2008-02-01 12:45:05 +0000
commitfbea6fbc31e45332f9bb56aa0a65eeba3451655a (patch)
tree05fb04d07b878db8da71f4df6d25ebef4b32b998
parentf24069d32c39d21037503b0c5d645a5929291f69 (diff)
downloadforums-fbea6fbc31e45332f9bb56aa0a65eeba3451655a.tar
forums-fbea6fbc31e45332f9bb56aa0a65eeba3451655a.tar.gz
forums-fbea6fbc31e45332f9bb56aa0a65eeba3451655a.tar.bz2
forums-fbea6fbc31e45332f9bb56aa0a65eeba3451655a.tar.xz
forums-fbea6fbc31e45332f9bb56aa0a65eeba3451655a.zip
Try to sort last active date on memberlist correctly at least on current page (Bug #18665) - patch provided by phillipK
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8359 89ea8834-ac86-4346-8a33-228a782c2dd0
-rw-r--r--phpBB/docs/CHANGELOG.html1
-rw-r--r--phpBB/memberlist.php3
2 files changed, 3 insertions, 1 deletions
diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html
index eea7f88892..2e7600b000 100644
--- a/phpBB/docs/CHANGELOG.html
+++ b/phpBB/docs/CHANGELOG.html
@@ -114,6 +114,7 @@
<li>[Fix] Prepend phpbb_root_path to ranks path for displaying ranks (Bug #19075)</li>
<li>[Fix] Allow forum notifications if topic notifications are disabled but forum notifications enabled (Bug #14765)</li>
<li>[Fix] Fixing realpath issues for provider returning the passed value instead of disabling it. This fixes issues with confirm boxes for those hosted on Network Solutions for example. (Bug #20435)</li>
+ <li>[Fix] Try to sort last active date on memberlist correctly at least on current page (Bug #18665)</li>
</ul>
<a name="v30rc8"></a><h3>1.i. Changes since 3.0.RC8</h3>
diff --git a/phpBB/memberlist.php b/phpBB/memberlist.php
index f7c9d101a8..d021581cb2 100644
--- a/phpBB/memberlist.php
+++ b/phpBB/memberlist.php
@@ -1369,7 +1369,8 @@ switch ($mode)
if ($sort_key == 'l')
{
$lesser_than = ($sort_dir == 'a') ? -1 : 1;
- uasort($id_cache, create_function('$first, $second', "return (\$first['last_visit'] == \$second['last_visit']) ? 0 : ((\$first['last_visit'] < \$second['last_visit']) ? $lesser_than : ($lesser_than * -1));"));
+// uasort($id_cache, create_function('$first, $second', "return (\$first['last_visit'] == \$second['last_visit']) ? 0 : ((\$first['last_visit'] < \$second['last_visit']) ? $lesser_than : ($lesser_than * -1));"));
+ usort($user_list, create_function('$first, $second', "global \$id_cache; return (\$id_cache[\$first]['last_visit'] == \$id_cache[\$second]['last_visit']) ? 0 : ((\$id_cache[\$first]['last_visit'] < \$id_cache[\$second]['last_visit']) ? $lesser_than : ($lesser_than * -1));"));
}
for ($i = 0, $end = sizeof($user_list); $i < $end; ++$i)