diff options
| author | Joas Schilling <nickvergessen@gmx.de> | 2014-04-11 12:16:45 +0200 |
|---|---|---|
| committer | Joas Schilling <nickvergessen@gmx.de> | 2014-04-25 11:52:18 +0200 |
| commit | ed40846590ea3b80af35aa845dba7e05da88c223 (patch) | |
| tree | 10ca43394fd2053ec4f815c3074d6cac356df807 | |
| parent | f86bf3c4d359a0f2c09f81d867212e7a248a6535 (diff) | |
| download | forums-ed40846590ea3b80af35aa845dba7e05da88c223.tar forums-ed40846590ea3b80af35aa845dba7e05da88c223.tar.gz forums-ed40846590ea3b80af35aa845dba7e05da88c223.tar.bz2 forums-ed40846590ea3b80af35aa845dba7e05da88c223.tar.xz forums-ed40846590ea3b80af35aa845dba7e05da88c223.zip | |
[ticket/12371] Do not group "quote" notifications
Grouping these notification makes no sense, as the user will not find the
posts he is quoted in, when they are spread over multiple pages
PHPBB3-12371
| -rw-r--r-- | phpBB/phpbb/notification/type/quote.php | 31 |
1 files changed, 8 insertions, 23 deletions
diff --git a/phpBB/phpbb/notification/type/quote.php b/phpBB/phpbb/notification/type/quote.php index 745430e114..f4b4d763eb 100644 --- a/phpBB/phpbb/notification/type/quote.php +++ b/phpBB/phpbb/notification/type/quote.php @@ -113,29 +113,6 @@ class quote extends \phpbb\notification\type\post $notify_users = $this->check_user_notification_options($auth_read[$post['forum_id']]['f_read'], $options); - // Try to find the users who already have been notified about replies and have not read the topic since and just update their notifications - $update_notifications = array(); - $sql = 'SELECT n.* - FROM ' . $this->notifications_table . ' n, ' . $this->notification_types_table . ' nt - WHERE n.notification_type_id = ' . (int) $this->notification_type_id . ' - AND n.item_parent_id = ' . (int) self::get_item_parent_id($post) . ' - AND n.notification_read = 0 - AND nt.notification_type_id = n.notification_type_id - AND nt.notification_type_enabled = 1'; - $result = $this->db->sql_query($sql); - while ($row = $this->db->sql_fetchrow($result)) - { - // Do not create a new notification - unset($notify_users[$row['user_id']]); - - $notification = $this->notification_manager->get_item_type_class($this->get_type(), $row); - $sql = 'UPDATE ' . $this->notifications_table . ' - SET ' . $this->db->sql_build_array('UPDATE', $notification->add_responders($post)) . ' - WHERE notification_id = ' . $row['notification_id']; - $this->db->sql_query($sql); - } - $this->db->sql_freeresult($result); - return $notify_users; } @@ -191,6 +168,14 @@ class quote extends \phpbb\notification\type\post } /** + * {inheritDoc} + */ + public function get_redirect_url() + { + return $this->get_url(); + } + + /** * Get email template * * @return string|bool |