diff options
| author | Andreas Fischer <bantu@phpbb.com> | 2011-03-18 03:15:40 +0100 |
|---|---|---|
| committer | Andreas Fischer <bantu@phpbb.com> | 2011-03-19 23:20:41 +0100 |
| commit | d36f78b9f1c7fc0c52a36d95510be1d8e2361f5d (patch) | |
| tree | ae4dfe9e97c00ec7e93c83194873ee4da8c59e06 | |
| parent | 34929033b48a3f5f61d7d793b815f723c8e94a34 (diff) | |
| download | forums-d36f78b9f1c7fc0c52a36d95510be1d8e2361f5d.tar forums-d36f78b9f1c7fc0c52a36d95510be1d8e2361f5d.tar.gz forums-d36f78b9f1c7fc0c52a36d95510be1d8e2361f5d.tar.bz2 forums-d36f78b9f1c7fc0c52a36d95510be1d8e2361f5d.tar.xz forums-d36f78b9f1c7fc0c52a36d95510be1d8e2361f5d.zip | |
[ticket/10082] session_id is CHAR(32) not VARCHAR(32), so give them a CHAR(32).
This fixes session unit tests on PostgreSQL in particular.
PHPBB3-10082
| -rw-r--r-- | tests/session/continue_test.php | 14 | ||||
| -rw-r--r-- | tests/session/fixtures/sessions_full.xml | 4 |
2 files changed, 11 insertions, 7 deletions
diff --git a/tests/session/continue_test.php b/tests/session/continue_test.php index 3080121978..6737562a0a 100644 --- a/tests/session/continue_test.php +++ b/tests/session/continue_test.php @@ -19,21 +19,25 @@ class phpbb_session_continue_test extends phpbb_database_test_case static public function session_begin_attempts() { + // The session_id field is defined as CHAR(32) in the database schema. + // Thus the data we put in session_id fields has to have a length of 32 characters on stricter DBMSes. + // Thus we fill those strings up with zeroes until they have a string length of 32. + return array( array( - 'bar_session', '4', 'user agent', '127.0.0.1', + 'bar_session000000000000000000000', '4', 'user agent', '127.0.0.1', array( - array('session_id' => 'anon_session', 'session_user_id' => 1), - array('session_id' => 'bar_session', 'session_user_id' => 4), + array('session_id' => 'anon_session00000000000000000000', 'session_user_id' => 1), + array('session_id' => 'bar_session000000000000000000000', 'session_user_id' => 4), ), array(), 'If a request comes with a valid session id with matching user agent and IP, no new session should be created.', ), array( - 'anon_session', '4', 'user agent', '127.0.0.1', + 'anon_session00000000000000000000', '4', 'user agent', '127.0.0.1', array( array('session_id' => '__new_session_id__', 'session_user_id' => 1), // use generated SID - array('session_id' => 'bar_session', 'session_user_id' => 4), + array('session_id' => 'bar_session000000000000000000000', 'session_user_id' => 4), ), array( 'u' => array('1', null), diff --git a/tests/session/fixtures/sessions_full.xml b/tests/session/fixtures/sessions_full.xml index 4559a08c55..bf6fc65997 100644 --- a/tests/session/fixtures/sessions_full.xml +++ b/tests/session/fixtures/sessions_full.xml @@ -22,13 +22,13 @@ <column>session_ip</column> <column>session_browser</column> <row> - <value>anon_session</value> + <value>anon_session00000000000000000000</value> <value>1</value> <value>127.0.0.1</value> <value>anonymous user agent</value> </row> <row> - <value>bar_session</value> + <value>bar_session000000000000000000000</value> <value>4</value> <value>127.0.0.1</value> <value>user agent</value> |