diff options
| author | Igor Wiedler <igor@wiedler.ch> | 2012-07-20 23:53:11 +0200 |
|---|---|---|
| committer | Igor Wiedler <igor@wiedler.ch> | 2012-07-21 00:12:37 +0200 |
| commit | ca43a8947a67642f6d1f211f1f5e030b2526ebe2 (patch) | |
| tree | b85344974864f4cdcd053bf79bcdec6bcf50dd43 | |
| parent | 841ea0e494504400c798faa6cc860dd1179e1004 (diff) | |
| download | forums-ca43a8947a67642f6d1f211f1f5e030b2526ebe2.tar forums-ca43a8947a67642f6d1f211f1f5e030b2526ebe2.tar.gz forums-ca43a8947a67642f6d1f211f1f5e030b2526ebe2.tar.bz2 forums-ca43a8947a67642f6d1f211f1f5e030b2526ebe2.tar.xz forums-ca43a8947a67642f6d1f211f1f5e030b2526ebe2.zip | |
[ticket/11008] Remove eval() calls to get document[id]
PHPBB3-11008
| -rw-r--r-- | phpBB/adm/style/overall_header.html | 6 | ||||
| -rw-r--r-- | phpBB/styles/prosilver/template/forum_fn.js | 6 | ||||
| -rw-r--r-- | phpBB/styles/subsilver2/template/memberlist_search.html | 6 | ||||
| -rw-r--r-- | phpBB/styles/subsilver2/template/overall_header.html | 6 |
4 files changed, 4 insertions, 20 deletions
diff --git a/phpBB/adm/style/overall_header.html b/phpBB/adm/style/overall_header.html index f79c0318b5..f6d0e1025f 100644 --- a/phpBB/adm/style/overall_header.html +++ b/phpBB/adm/style/overall_header.html @@ -62,11 +62,7 @@ function dE(n, s, type) */ function marklist(id, name, state) { - var parent = document.getElementById(id); - if (!parent) - { - eval('parent = document.' + id); - } + var parent = document.getElementById(id) || document[id]; if (!parent) { diff --git a/phpBB/styles/prosilver/template/forum_fn.js b/phpBB/styles/prosilver/template/forum_fn.js index 240fe7e51d..995b4b0ab7 100644 --- a/phpBB/styles/prosilver/template/forum_fn.js +++ b/phpBB/styles/prosilver/template/forum_fn.js @@ -42,11 +42,7 @@ function jumpto() */ function marklist(id, name, state) { - var parent = document.getElementById(id); - if (!parent) - { - eval('parent = document.' + id); - } + var parent = document.getElementById(id) || document[id]; if (!parent) { diff --git a/phpBB/styles/subsilver2/template/memberlist_search.html b/phpBB/styles/subsilver2/template/memberlist_search.html index 96ffad00d6..ab1ecca2ee 100644 --- a/phpBB/styles/subsilver2/template/memberlist_search.html +++ b/phpBB/styles/subsilver2/template/memberlist_search.html @@ -43,11 +43,7 @@ */ function marklist(id, name, state) { - var parent = document.getElementById(id); - if (!parent) - { - eval('parent = document.' + id); - } + var parent = document.getElementById(id) || document[id]; if (!parent) { diff --git a/phpBB/styles/subsilver2/template/overall_header.html b/phpBB/styles/subsilver2/template/overall_header.html index 5d5489338a..f08531c47f 100644 --- a/phpBB/styles/subsilver2/template/overall_header.html +++ b/phpBB/styles/subsilver2/template/overall_header.html @@ -71,11 +71,7 @@ function find_username(url) */ function marklist(id, name, state) { - var parent = document.getElementById(id); - if (!parent) - { - eval('parent = document.' + id); - } + var parent = document.getElementById(id) || document[id]; if (!parent) { |