diff options
| author | Nils Adermann <naderman@naderman.de> | 2011-08-29 20:14:23 -0400 |
|---|---|---|
| committer | Nils Adermann <naderman@naderman.de> | 2011-09-29 15:42:49 +0200 |
| commit | c785ef7aa7953c5e533e48b11ef13d6b1f344813 (patch) | |
| tree | 49363b193236619c0eed69fbd68b965d0e64748c | |
| parent | 018a8359974273b65a3e6bd8aeca75396fd36a5b (diff) | |
| download | forums-c785ef7aa7953c5e533e48b11ef13d6b1f344813.tar forums-c785ef7aa7953c5e533e48b11ef13d6b1f344813.tar.gz forums-c785ef7aa7953c5e533e48b11ef13d6b1f344813.tar.bz2 forums-c785ef7aa7953c5e533e48b11ef13d6b1f344813.tar.xz forums-c785ef7aa7953c5e533e48b11ef13d6b1f344813.zip | |
[feature/extension-manager] Make sure the extension manager works without cache
Includes a test for manager without a cache
PHPBB3-10323
| -rw-r--r-- | phpBB/includes/extension/manager.php | 8 | ||||
| -rw-r--r-- | tests/extension/manager_test.php | 13 |
2 files changed, 19 insertions, 2 deletions
diff --git a/phpBB/includes/extension/manager.php b/phpBB/includes/extension/manager.php index 443eaf011b..a6c8ebb3d0 100644 --- a/phpBB/includes/extension/manager.php +++ b/phpBB/includes/extension/manager.php @@ -48,7 +48,7 @@ class phpbb_extension_manager $this->extension_table = $extension_table; $this->cache_name = $cache_name; - $this->extensions = $this->cache->get($this->cache_name); + $this->extensions = ($this->cache) ? $this->cache->get($this->cache_name) : false; if ($this->extensions === false) { @@ -78,7 +78,11 @@ class phpbb_extension_manager } ksort($this->extensions); - $this->cache->put($this->cache_name, $this->extensions); + + if ($this->cache) + { + $this->cache->put($this->cache_name, $this->extensions); + } } /** diff --git a/tests/extension/manager_test.php b/tests/extension/manager_test.php index 70c3543a69..52be88330a 100644 --- a/tests/extension/manager_test.php +++ b/tests/extension/manager_test.php @@ -81,4 +81,17 @@ class phpbb_extension_manager_test extends phpbb_database_test_case $this->assertTrue(phpbb_ext_moo::$purged); } + + public function test_enabled_no_cache() + { + $extension_manager = new phpbb_extension_manager( + $this->new_dbal(), + 'phpbb_ext', + dirname(__FILE__) . '/', + '.php' + ); + + $this->assertEquals(array('foo'), array_keys($extension_manager->all_enabled())); + } + } |