aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoas Schilling <nickvergessen@gmx.de>2013-01-22 15:45:20 +0100
committerJoas Schilling <nickvergessen@gmx.de>2013-01-22 15:45:20 +0100
commitc0ab3f3ddddefa8f902ffa57c864e6db5bf1f440 (patch)
tree442cb8268fb4c8ffc75e92bee4560ceab22aa92d
parent2c4e7eabe248fc785cd2b43f57a42580361c599d (diff)
downloadforums-c0ab3f3ddddefa8f902ffa57c864e6db5bf1f440.tar
forums-c0ab3f3ddddefa8f902ffa57c864e6db5bf1f440.tar.gz
forums-c0ab3f3ddddefa8f902ffa57c864e6db5bf1f440.tar.bz2
forums-c0ab3f3ddddefa8f902ffa57c864e6db5bf1f440.tar.xz
forums-c0ab3f3ddddefa8f902ffa57c864e6db5bf1f440.zip
[ticket/10714] Fix several doc blocks and comments
PHPBB3-10714
-rw-r--r--phpBB/includes/functions_admin.php4
-rw-r--r--phpBB/includes/log/interface.php10
-rw-r--r--phpBB/includes/log/log.php5
3 files changed, 11 insertions, 8 deletions
diff --git a/phpBB/includes/functions_admin.php b/phpBB/includes/functions_admin.php
index 18b11182d0..60591e98d3 100644
--- a/phpBB/includes/functions_admin.php
+++ b/phpBB/includes/functions_admin.php
@@ -2489,12 +2489,12 @@ function cache_moderators()
/**
* View log
*
-* @param string $mode The mode defines which log_type is used and in which log the entry is displayed.
+* @param string $mode The mode defines which log_type is used and from which log the entry is retrieved
* @param array &$log The result array with the logs
* @param mixed &$log_count If $log_count is set to false, we will skip counting all entries in the database.
* Otherwise an integer with the number of total matching entries is returned.
* @param int $limit Limit the number of entries that are returned
-* @param int $offset Offset when fetching the log entries, f.e. on paginations
+* @param int $offset Offset when fetching the log entries, f.e. when paginating
* @param mixed $forum_id Restrict the log entries to the given forum_id (can also be an array of forum_ids)
* @param int $topic_id Restrict the log entries to the given topic_id
* @param int $user_id Restrict the log entries to the given user_id
diff --git a/phpBB/includes/log/interface.php b/phpBB/includes/log/interface.php
index 254b65cb19..24bf412ce0 100644
--- a/phpBB/includes/log/interface.php
+++ b/phpBB/includes/log/interface.php
@@ -56,24 +56,24 @@ interface phpbb_log_interface
/**
* Adds a log entry to the database
*
- * @param string $mode The mode defines which log_type is used and in which log the entry is displayed.
+ * @param string $mode The mode defines which log_type is used and from which log the entry is retrieved
* @param int $user_id User ID of the user
* @param string $log_ip IP address of the user
* @param string $log_operation Name of the operation
- * @param int $log_time Timestamp when the log entry was added.
+ * @param int $log_time Timestamp when the log entry was added, if empty time() will be used
* @param array $additional_data More arguments can be added, depending on the log_type
*
* @return int|bool Returns the log_id, if the entry was added to the database, false otherwise.
*/
- public function add($mode, $user_id, $log_ip, $log_operation, $log_time, $additional_data);
+ public function add($mode, $user_id, $log_ip, $log_operation, $log_time = false, $additional_data = array());
/**
* Grab the logs from the database
*
- * @param string $mode The mode defines which log_type is used and in which log the entry is displayed.
+ * @param string $mode The mode defines which log_type is used and ifrom which log the entry is retrieved
* @param bool $count_logs Shall we count all matching log entries?
* @param int $limit Limit the number of entries that are returned
- * @param int $offset Offset when fetching the log entries, f.e. on paginations
+ * @param int $offset Offset when fetching the log entries, f.e. when paginating
* @param mixed $forum_id Restrict the log entries to the given forum_id (can also be an array of forum_ids)
* @param int $topic_id Restrict the log entries to the given topic_id
* @param int $user_id Restrict the log entries to the given user_id
diff --git a/phpBB/includes/log/log.php b/phpBB/includes/log/log.php
index 092fdb6a89..33c558695c 100644
--- a/phpBB/includes/log/log.php
+++ b/phpBB/includes/log/log.php
@@ -31,16 +31,19 @@ class phpbb_log implements phpbb_log_interface
/**
* Keeps the total log count of the last call to get_logs()
+ * @var int
*/
protected $entry_count;
/**
* Keeps the offset of the last valid page of the last call to get_logs()
+ * @var int
*/
protected $last_page_offset;
/**
* The table we use to store our logs.
+ * @var string
*/
protected $log_table;
@@ -112,7 +115,7 @@ class phpbb_log implements phpbb_log_interface
/*
* IN_ADMIN is set after the session was created,
- * so we need to take ADMIN_START into account aswell, otherwise
+ * so we need to take ADMIN_START into account as well, otherwise
* it will not work for the phpbb_log object we create in common.php
*/
$this->set_is_admin((defined('ADMIN_START') && ADMIN_START) || (defined('IN_ADMIN') && IN_ADMIN));