diff options
| author | lavigor <lavigor@users.noreply.github.com> | 2017-07-01 22:59:25 +0300 |
|---|---|---|
| committer | lavigor <lavigor@users.noreply.github.com> | 2017-07-01 23:01:34 +0300 |
| commit | b7ce395fbe6e2087a400487cb2431dc9ea66b8a9 (patch) | |
| tree | 0b23f318ea52f1da108430cf8acace6233d8ded9 | |
| parent | aef138d8bc2cc2c74bc9951d136c7bc1e0cf3ad7 (diff) | |
| download | forums-b7ce395fbe6e2087a400487cb2431dc9ea66b8a9.tar forums-b7ce395fbe6e2087a400487cb2431dc9ea66b8a9.tar.gz forums-b7ce395fbe6e2087a400487cb2431dc9ea66b8a9.tar.bz2 forums-b7ce395fbe6e2087a400487cb2431dc9ea66b8a9.tar.xz forums-b7ce395fbe6e2087a400487cb2431dc9ea66b8a9.zip | |
[ticket/15259] Fatal error on SQLite/Oracle database update
PHPBB3-15259
| -rw-r--r-- | phpBB/phpbb/db/tools/tools.php | 36 |
1 files changed, 14 insertions, 22 deletions
diff --git a/phpBB/phpbb/db/tools/tools.php b/phpBB/phpbb/db/tools/tools.php index 76036554d2..2f891e43d5 100644 --- a/phpBB/phpbb/db/tools/tools.php +++ b/phpBB/phpbb/db/tools/tools.php @@ -941,29 +941,19 @@ class tools implements tools_interface continue; } - // These DBMS prefix index name with the table name switch ($this->sql_layer) { + // These DBMS prefix index name with the table name case 'oracle': case 'sqlite3': - $index_name = $this->check_index_name_length($table_name, $table_name . '_' . $index_name, false); - $table_prefix = substr(CONFIG_TABLE, 0, -6); // strlen(config) - - if (strpos($index_name , $table_name) === false) - { - if (strpos($index_name, $table_prefix) !== false) - { - $row[$col] = substr($row[$col], strlen($table_prefix) + 1); - } - else - { - $row[$col] = substr($row[$col], strlen($table_name) + 1); - } - } + $new_index_name = $this->check_index_name_length($table_name, $table_name . '_' . $index_name, false); + break; + default: + $new_index_name = $this->check_index_name_length($table_name, $index_name, false); break; } - if (strtolower($row[$col]) == strtolower($index_name)) + if (strtolower($row[$col]) == strtolower($new_index_name)) { $this->db->sql_freeresult($result); return true; @@ -1577,15 +1567,17 @@ class tools implements tools_interface $table_prefix = substr(CONFIG_TABLE, 0, -6); // strlen(config) if (strpos($index_name, $table_prefix) === 0) { - $index_name = substr($index_name, strlen($table_prefix) + 1); - return $this->check_index_name_length($table_name, $index_name); + $index_name = substr($index_name, strlen($table_prefix)); + return $this->check_index_name_length($table_name, $index_name, $throw_error); } - // Try removing the table name then - if (strpos($index_name, $table_name) === 0) + // Try removing the remaining suffix part of table name then + $table_suffix = substr($table_name, strlen($table_prefix)); + if (strpos($index_name, $table_suffix) === 0) { - $index_name = substr($index_name, strlen($table_name) + 1); - return $this->check_index_name_length($table_name, $index_name); + // Remove the suffix and underscore separator between table_name and index_name + $index_name = substr($index_name, strlen($table_suffix) + 1); + return $this->check_index_name_length($table_name, $index_name, $throw_error); } if ($throw_error) |