aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGreg Ryckman <greg.ryckman@yp.ca>2016-03-30 12:53:44 -0400
committerGreg Ryckman <greg.ryckman@yp.ca>2016-03-30 12:53:44 -0400
commita643d04b05b33cfaee3d238e885dc6d1bca2e6c9 (patch)
tree2a19df600fcc6613b7d38e3f31fe9922f691ed54
parent27df46040fe66804be7a8097beecbdae8a319f43 (diff)
downloadforums-a643d04b05b33cfaee3d238e885dc6d1bca2e6c9.tar
forums-a643d04b05b33cfaee3d238e885dc6d1bca2e6c9.tar.gz
forums-a643d04b05b33cfaee3d238e885dc6d1bca2e6c9.tar.bz2
forums-a643d04b05b33cfaee3d238e885dc6d1bca2e6c9.tar.xz
forums-a643d04b05b33cfaee3d238e885dc6d1bca2e6c9.zip
[ticket/14572] Fix quote notification deletion
Some array_key calls were incorrect in the notification checks for quotes. Two calls were being made in a row, resulting in incorrect arrays. PHPBB3-14572
-rw-r--r--phpBB/phpbb/notification/type/quote.php4
1 files changed, 2 insertions, 2 deletions
diff --git a/phpBB/phpbb/notification/type/quote.php b/phpBB/phpbb/notification/type/quote.php
index 684463c8c3..323c18b204 100644
--- a/phpBB/phpbb/notification/type/quote.php
+++ b/phpBB/phpbb/notification/type/quote.php
@@ -115,14 +115,14 @@ class quote extends \phpbb\notification\type\post
));
// Find the new users to notify
- $notifications = array_keys($this->find_users_for_notification($post));
+ $notifications = $this->find_users_for_notification($post);
// Find the notifications we must delete
$remove_notifications = array_diff(array_keys($old_notifications), array_keys($notifications));
// Find the notifications we must add
$add_notifications = array();
- foreach (array_diff(array_keys($notifications), $old_notifications) as $user_id)
+ foreach (array_diff(array_keys($notifications), array_keys($old_notifications)) as $user_id)
{
$add_notifications[$user_id] = $notifications[$user_id];
}