aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMeik Sievertsen <acydburn@phpbb.com>2009-04-17 13:05:11 +0000
committerMeik Sievertsen <acydburn@phpbb.com>2009-04-17 13:05:11 +0000
commit93b3103c317979879e5738bbc60e5d466d7f8300 (patch)
tree571291e44972da291f374ee29b53cdc3dbf9eb3f
parent6408f1dc7e50a8991a085d001c52cf9816232e4c (diff)
downloadforums-93b3103c317979879e5738bbc60e5d466d7f8300.tar
forums-93b3103c317979879e5738bbc60e5d466d7f8300.tar.gz
forums-93b3103c317979879e5738bbc60e5d466d7f8300.tar.bz2
forums-93b3103c317979879e5738bbc60e5d466d7f8300.tar.xz
forums-93b3103c317979879e5738bbc60e5d466d7f8300.zip
Use L_EMAIL variants consistently... also added comments for translators to indicate where which variant is used (Bug #39495)
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9452 89ea8834-ac86-4346-8a33-228a782c2dd0
-rw-r--r--phpBB/adm/style/acp_email.html2
-rw-r--r--phpBB/language/en/common.php4
-rw-r--r--phpBB/styles/prosilver/template/ucp_pm_viewmessage.html2
-rw-r--r--phpBB/styles/prosilver/template/viewtopic_body.html2
4 files changed, 5 insertions, 5 deletions
diff --git a/phpBB/adm/style/acp_email.html b/phpBB/adm/style/acp_email.html
index b1d9b4af11..885809ffe2 100644
--- a/phpBB/adm/style/acp_email.html
+++ b/phpBB/adm/style/acp_email.html
@@ -44,7 +44,7 @@
</dl>
<p class="submit-buttons">
- <input class="button1" type="submit" id="submit" name="submit" value="{L_EMAIL}" />&nbsp;
+ <input class="button1" type="submit" id="submit" name="submit" value="{L_SEND_EMAIL}" />&nbsp;
<input class="button2" type="reset" id="reset" name="reset" value="{L_RESET}" />
</p>
{S_FORM_TOKEN}
diff --git a/phpBB/language/en/common.php b/phpBB/language/en/common.php
index 7e889db7d8..f603506b40 100644
--- a/phpBB/language/en/common.php
+++ b/phpBB/language/en/common.php
@@ -158,7 +158,7 @@ $lang = array_merge($lang, array(
'VIEWED_COUNT_NONE' => 'Not viewed yet',
'EDIT_POST' => 'Edit post',
- 'EMAIL' => 'E-mail',
+ 'EMAIL' => 'E-mail', // Short form for EMAIL_ADDRESS
'EMAIL_ADDRESS' => 'E-mail address',
'EMAIL_SMTP_ERROR_RESPONSE' => 'Ran into problems sending e-mail at <strong>Line %1$s</strong>. Response: %2$s.',
'EMPTY_SUBJECT' => 'You must specify a subject when posting a new topic.',
@@ -520,7 +520,7 @@ $lang = array_merge($lang, array(
'SELECT_ALL_CODE' => 'Select all',
'SELECT_DESTINATION_FORUM' => 'Please select a destination forum',
'SELECT_FORUM' => 'Select a forum',
- 'SEND_EMAIL' => 'E-mail',
+ 'SEND_EMAIL' => 'E-mail', // Used for submit buttons
'SEND_EMAIL_USER' => 'E-mail', // Used as: {L_SEND_EMAIL_USER} {USERNAME} -> E-mail UserX
'SEND_PRIVATE_MESSAGE' => 'Send private message',
'SETTINGS' => 'Settings',
diff --git a/phpBB/styles/prosilver/template/ucp_pm_viewmessage.html b/phpBB/styles/prosilver/template/ucp_pm_viewmessage.html
index 535641f33b..ef9807f88a 100644
--- a/phpBB/styles/prosilver/template/ucp_pm_viewmessage.html
+++ b/phpBB/styles/prosilver/template/ucp_pm_viewmessage.html
@@ -75,7 +75,7 @@
<dd>
<ul class="profile-icons">
<!-- IF U_PM --><li class="pm-icon"><a href="{U_PM}" title="{L_PRIVATE_MESSAGE}"><span>{L_PRIVATE_MESSAGE}</span></a></li><!-- ENDIF -->
- <!-- IF U_EMAIL --><li class="email-icon"><a href="{U_EMAIL}" title="{L_EMAIL}"><span>{L_EMAIL}</span></a></li><!-- ENDIF -->
+ <!-- IF U_EMAIL --><li class="email-icon"><a href="{U_EMAIL}" title="{L_SEND_EMAIL_USER} {MESSAGE_AUTHOR}"><span>{L_SEND_EMAIL_USER} {MESSAGE_AUTHOR}</span></a></li><!-- ENDIF -->
<!-- IF U_WWW --><li class="web-icon"><a href="{U_WWW}" title="{L_VISIT_WEBSITE}: {U_WWW}"><span>{L_WEBSITE}</span></a></li><!-- ENDIF -->
<!-- IF U_MSN --><li class="msnm-icon"><a href="{U_MSN}" onclick="popup(this.href, 550, 320); return false;" title="{L_MSNM}"><span>{L_MSNM}</span></a></li><!-- ENDIF -->
<!-- IF U_ICQ --><li class="icq-icon"><a href="{U_ICQ}" onclick="popup(this.href, 550, 320); return false;" title="{L_ICQ}"><span>{L_ICQ}</span></a></li><!-- ENDIF -->
diff --git a/phpBB/styles/prosilver/template/viewtopic_body.html b/phpBB/styles/prosilver/template/viewtopic_body.html
index 2b8ce06ace..87685106ad 100644
--- a/phpBB/styles/prosilver/template/viewtopic_body.html
+++ b/phpBB/styles/prosilver/template/viewtopic_body.html
@@ -200,7 +200,7 @@
<dd>
<ul class="profile-icons">
<!-- IF postrow.U_PM --><li class="pm-icon"><a href="{postrow.U_PM}" title="{L_PRIVATE_MESSAGE}"><span>{L_PRIVATE_MESSAGE}</span></a></li><!-- ENDIF -->
- <!-- IF postrow.U_EMAIL --><li class="email-icon"><a href="{postrow.U_EMAIL}" title="{L_EMAIL}"><span>{L_EMAIL}</span></a></li><!-- ENDIF -->
+ <!-- IF postrow.U_EMAIL --><li class="email-icon"><a href="{postrow.U_EMAIL}" title="{L_SEND_EMAIL_USER} {postrow.POST_AUTHOR}"><span>{L_SEND_EMAIL_USER} {postrow.POST_AUTHOR}</span></a></li><!-- ENDIF -->
<!-- IF postrow.U_WWW --><li class="web-icon"><a href="{postrow.U_WWW}" title="{L_VISIT_WEBSITE}: {postrow.U_WWW}"><span>{L_WEBSITE}</span></a></li><!-- ENDIF -->
<!-- IF postrow.U_MSN --><li class="msnm-icon"><a href="{postrow.U_MSN}" onclick="popup(this.href, 550, 320); return false;" title="{L_MSNM}"><span>{L_MSNM}</span></a></li><!-- ENDIF -->
<!-- IF postrow.U_ICQ --><li class="icq-icon"><a href="{postrow.U_ICQ}" onclick="popup(this.href, 550, 320); return false;" title="{L_ICQ}"><span>{L_ICQ}</span></a></li><!-- ENDIF -->
(); $this->create_guest_sessions($time); $this->assertEquals($expected, obtain_guest_count($forum_id)); } static public function obtain_users_online_data() { return array( array(0, false, array( 'online_users' => array(2 => 2, 3 => 3, 6 => 6, 7 => 7, 10 => 10), 'hidden_users' => array(6 => 6, 7 => 7, 10 => 10), 'total_online' => 5, 'visible_online' => 2, 'hidden_online' => 3, 'guests_online' => 0, )), array(0, true, array( 'online_users' => array(2 => 2, 3 => 3, 6 => 6, 7 => 7, 10 => 10), 'hidden_users' => array(6 => 6, 7 => 7, 10 => 10), 'total_online' => 7, 'visible_online' => 2, 'hidden_online' => 3, 'guests_online' => 2, )), array(1, false, array( 'online_users' => array(3 => 3, 7 => 7), 'hidden_users' => array(7 => 7), 'total_online' => 2, 'visible_online' => 1, 'hidden_online' => 1, 'guests_online' => 0, )), array(1, true, array( 'online_users' => array(3 => 3, 7 => 7), 'hidden_users' => array(7 => 7), 'total_online' => 3, 'visible_online' => 1, 'hidden_online' => 1, 'guests_online' => 1, )), array(2, false, array( 'online_users' => array(), 'hidden_users' => array(), 'total_online' => 0, 'visible_online' => 0, 'hidden_online' => 0, 'guests_online' => 0, )), array(2, true, array( 'online_users' => array(), 'hidden_users' => array(), 'total_online' => 0, 'visible_online' => 0, 'hidden_online' => 0, 'guests_online' => 0, )), ); } /** * @dataProvider obtain_users_online_data */ public function test_obtain_users_online($forum_id, $display_guests, $expected) { $this->db->sql_query('DELETE FROM phpbb_sessions'); global $config; $config['load_online_guests'] = $display_guests; $time = time(); $this->create_guest_sessions($time); $this->create_user_sessions($time); $this->assertEquals($expected, obtain_users_online($forum_id)); } static public function obtain_users_online_string_data() { return array( array(0, false, array( 'online_userlist' => 'REGISTERED_USERS <span class="username">2</span>, <span class="username">3</span>', 'l_online_users' => 'ONLINE_USERS_TOTAL 5 REG_USERS_TOTAL 2 HIDDEN_USERS_TOTAL 3', )), array(0, true, array( 'online_userlist' => 'REGISTERED_USERS <span class="username">2</span>, <span class="username">3</span>', 'l_online_users' => 'ONLINE_USERS_TOTAL_GUESTS 7 REG_USERS_TOTAL 2 HIDDEN_USERS_TOTAL 3 GUEST_USERS_TOTAL 2', )), array(1, false, array( 'online_userlist' => 'BROWSING_FORUM <span class="username">3</span>', 'l_online_users' => 'ONLINE_USERS_TOTAL 2 REG_USERS_TOTAL 1 HIDDEN_USERS_TOTAL 1', )), array(1, true, array( 'online_userlist' => 'BROWSING_FORUM_GUESTS 1 <span class="username">3</span>', 'l_online_users' => 'ONLINE_USERS_TOTAL_GUESTS 3 REG_USERS_TOTAL 1 HIDDEN_USERS_TOTAL 1 GUEST_USERS_TOTAL 1', )), array(2, false, array( 'online_userlist' => 'BROWSING_FORUM NO_ONLINE_USERS', 'l_online_users' => 'ONLINE_USERS_TOTAL 0 REG_USERS_TOTAL 0 HIDDEN_USERS_TOTAL 0', )), array(2, true, array( 'online_userlist' => 'BROWSING_FORUM_GUESTS 0 NO_ONLINE_USERS', 'l_online_users' => 'ONLINE_USERS_TOTAL_GUESTS 0 REG_USERS_TOTAL 0 HIDDEN_USERS_TOTAL 0 GUEST_USERS_TOTAL 0', )), ); } /** * @dataProvider obtain_users_online_string_data */ public function test_obtain_users_online_string($forum_id, $display_guests, $expected) { $this->db->sql_query('DELETE FROM phpbb_sessions'); global $config, $user, $auth, $phpbb_dispatcher; $config['load_online_guests'] = $display_guests; $user = new phpbb_mock_lang(); $user->lang = $this->load_language(); $auth = $this->getMock('\phpbb\auth\auth'); $acl_get_map = array( array('u_viewonline', true), array('u_viewprofile', true), ); $auth->expects($this->any()) ->method('acl_get') ->with($this->stringContains('_'), $this->anything()) ->will($this->returnValueMap($acl_get_map)); $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); $time = time(); $this->create_guest_sessions($time); $this->create_user_sessions($time); $online_users = obtain_users_online($forum_id); $this->assertEquals($expected, obtain_users_online_string($online_users, $forum_id)); } protected function create_guest_sessions($time) { $this->add_session(1, '0001', '192.168.0.1', 0, true, $time); $this->add_session(1, '0002', '192.168.0.2', 1, true, $time); $this->add_session(1, '0003', '192.168.0.3', 0, true, $time, 10); $this->add_session(1, '0004', '192.168.0.4', 1, true, $time, 10); } protected function create_user_sessions($time) { $this->add_session(2, '0005', '192.168.0.5', 0, true, $time); $this->add_session(3, '0006', '192.168.0.6', 1, true, $time); $this->add_session(4, '0007', '192.168.0.7', 0, true, $time, 10); $this->add_session(5, '0008', '192.168.0.8', 1, true, $time, 10); $this->add_session(6, '0005', '192.168.0.9', 0, false, $time); $this->add_session(7, '0006', '192.168.0.10', 1, false, $time); $this->add_session(8, '0007', '192.168.0.11', 0, false, $time, 10); $this->add_session(9, '0008', '192.168.0.12', 1, false, $time, 10); $this->add_session(10, '009', '192.168.0.13', 0, false, $time); } protected function add_session($user_id, $session_id, $user_ip, $forum_id, $view_online, $time, $time_delta = 0) { $sql_ary = array( 'session_id' => $user_id . '_' . $forum_id . '_session00000000000000000' . $session_id, 'session_user_id' => $user_id, 'session_ip' => $user_ip, 'session_forum_id' => $forum_id, 'session_time' => $time - $time_delta * 60, 'session_viewonline' => $view_online, ); $this->db->sql_query('INSERT INTO phpbb_sessions ' . $this->db->sql_build_array('INSERT', $sql_ary)); } protected function load_language() { return array( 'NO_ONLINE_USERS' => 'NO_ONLINE_USERS', 'REGISTERED_USERS' => 'REGISTERED_USERS', 'BROWSING_FORUM' => 'BROWSING_FORUM %s', 'BROWSING_FORUM_GUEST' => 'BROWSING_FORUM_GUEST %s %d', 'BROWSING_FORUM_GUESTS' => 'BROWSING_FORUM_GUESTS %s %d', ); } }