diff options
| author | Oleg Pudeyev <oleg@bsdpower.com> | 2012-12-13 19:21:23 -0500 |
|---|---|---|
| committer | Oleg Pudeyev <oleg@bsdpower.com> | 2012-12-13 19:21:23 -0500 |
| commit | 89f069637cd95f584db924407378b64df9910243 (patch) | |
| tree | 55693645b3899359e363f8ddf0673bf0bf49257d | |
| parent | ee7dc9e5a061038eadce40ed295d47f978b9e567 (diff) | |
| download | forums-89f069637cd95f584db924407378b64df9910243.tar forums-89f069637cd95f584db924407378b64df9910243.tar.gz forums-89f069637cd95f584db924407378b64df9910243.tar.bz2 forums-89f069637cd95f584db924407378b64df9910243.tar.xz forums-89f069637cd95f584db924407378b64df9910243.zip | |
[ticket/11015] Move comment in the right place.
PHPBB3-11015
| -rw-r--r-- | phpBB/includes/functions.php | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php index 575dd11388..8ef5284134 100644 --- a/phpBB/includes/functions.php +++ b/phpBB/includes/functions.php @@ -5573,6 +5573,13 @@ function phpbb_convert_30_dbms_to_31($dbms) if (class_exists($dbms)) { + // Additionally we could check that $dbms extends phpbb_db_driver. + // http://php.net/manual/en/class.reflectionclass.php + // Beware of possible performance issues: + // http://stackoverflow.com/questions/294582/php-5-reflection-api-performance + // We could check for interface implementation in all paths or + // only when we do not prepend phpbb_db_driver_. + /* $reflection = new \ReflectionClass($dbms); @@ -5585,13 +5592,6 @@ function phpbb_convert_30_dbms_to_31($dbms) return $dbms; } - // Additionally we could check that $dbms extends phpbb_db_driver. - // http://php.net/manual/en/class.reflectionclass.php - // Beware of possible performance issues: - // http://stackoverflow.com/questions/294582/php-5-reflection-api-performance - // We could check for interface implementation in all paths or - // only when we do not prepend phpbb_db_driver_. - throw new \RuntimeException("You have specified an invalid dbms driver: $dbms"); } |