aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOleg Pudeyev <oleg@bsdpower.com>2012-11-15 08:20:07 -0500
committerOleg Pudeyev <oleg@bsdpower.com>2012-11-15 14:54:13 -0500
commit8917b31e31e117e9ded9558a065986bfb4a672ac (patch)
tree02ce4f3868e0ab8ec143003072c286f4cd1acc8b
parentb9e1caa81ae2e3eea162c60d2bcec3e01fb539e1 (diff)
downloadforums-8917b31e31e117e9ded9558a065986bfb4a672ac.tar
forums-8917b31e31e117e9ded9558a065986bfb4a672ac.tar.gz
forums-8917b31e31e117e9ded9558a065986bfb4a672ac.tar.bz2
forums-8917b31e31e117e9ded9558a065986bfb4a672ac.tar.xz
forums-8917b31e31e117e9ded9558a065986bfb4a672ac.zip
[ticket/11202] Check response success before content assertions.
This does not change tests that perform requests which are either clearly not supposed to succeed or are a gray area. PHPBB3-11202
-rw-r--r--tests/functional/extension_controller_test.php2
1 files changed, 2 insertions, 0 deletions
diff --git a/tests/functional/extension_controller_test.php b/tests/functional/extension_controller_test.php
index e9409d9d3f..d92a830365 100644
--- a/tests/functional/extension_controller_test.php
+++ b/tests/functional/extension_controller_test.php
@@ -82,6 +82,7 @@ class phpbb_functional_extension_controller_test extends phpbb_functional_test_c
{
$this->phpbb_extension_manager->enable('foobar');
$crawler = $this->request('GET', 'index.php?ext=foobar');
+ $this->assert_response_success();
$this->assertContains("This is for testing purposes.", $crawler->filter('#page-body')->text());
$this->phpbb_extension_manager->purge('foobar');
}
@@ -94,6 +95,7 @@ class phpbb_functional_extension_controller_test extends phpbb_functional_test_c
{
$this->phpbb_extension_manager->enable('foo/bar');
$crawler = $this->request('GET', 'index.php?ext=foo/bar');
+ $this->assert_response_success();
$this->assertContains("This is for testing purposes.", $crawler->filter('#page-body')->text());
$this->phpbb_extension_manager->purge('foo/bar');
}