diff options
| author | Nathan Guse <nathaniel.guse@gmail.com> | 2012-07-30 15:24:31 -0500 | 
|---|---|---|
| committer | Nathan Guse <nathaniel.guse@gmail.com> | 2012-07-30 15:31:27 -0500 | 
| commit | 828eaecf6ab4f6c013a7955bf6af2a81c049e42f (patch) | |
| tree | 0006d5c0fcb023caa629c1b4e8b338dddb06864b | |
| parent | 7fd1a166da4c040532bb8ff35584b330348366d2 (diff) | |
| download | forums-828eaecf6ab4f6c013a7955bf6af2a81c049e42f.tar forums-828eaecf6ab4f6c013a7955bf6af2a81c049e42f.tar.gz forums-828eaecf6ab4f6c013a7955bf6af2a81c049e42f.tar.bz2 forums-828eaecf6ab4f6c013a7955bf6af2a81c049e42f.tar.xz forums-828eaecf6ab4f6c013a7955bf6af2a81c049e42f.zip | |
[ticket/10875] Changes to Cache Driver caused method_exists checks to fail
SQL Cache and other functions using the check
method_exists($cache,
failed because of the changes to the cache system.
method_exists($cache has been changed to
method_exists($cache->get_driver()
PHPBB3-10875
| -rw-r--r-- | phpBB/includes/cron/task/core/tidy_cache.php | 2 | ||||
| -rw-r--r-- | phpBB/includes/db/firebird.php | 4 | ||||
| -rw-r--r-- | phpBB/includes/db/mssql.php | 4 | ||||
| -rw-r--r-- | phpBB/includes/db/mssql_odbc.php | 4 | ||||
| -rw-r--r-- | phpBB/includes/db/mssqlnative.php | 4 | ||||
| -rw-r--r-- | phpBB/includes/db/mysql.php | 4 | ||||
| -rw-r--r-- | phpBB/includes/db/mysqli.php | 4 | ||||
| -rw-r--r-- | phpBB/includes/db/oracle.php | 4 | ||||
| -rw-r--r-- | phpBB/includes/db/postgres.php | 4 | ||||
| -rw-r--r-- | phpBB/includes/db/sqlite.php | 4 | 
10 files changed, 19 insertions, 19 deletions
| diff --git a/phpBB/includes/cron/task/core/tidy_cache.php b/phpBB/includes/cron/task/core/tidy_cache.php index c9dc0bd9ae..991b0725eb 100644 --- a/phpBB/includes/cron/task/core/tidy_cache.php +++ b/phpBB/includes/cron/task/core/tidy_cache.php @@ -44,7 +44,7 @@ class phpbb_cron_task_core_tidy_cache extends phpbb_cron_task_base  	public function is_runnable()  	{  		global $cache; -		return method_exists($cache, 'tidy'); +		return method_exists($cache->get_driver(), 'tidy');  	}  	/** diff --git a/phpBB/includes/db/firebird.php b/phpBB/includes/db/firebird.php index 7709e8fdf5..f89d5134c1 100644 --- a/phpBB/includes/db/firebird.php +++ b/phpBB/includes/db/firebird.php @@ -156,7 +156,7 @@ class dbal_firebird extends dbal  			}  			$this->last_query_text = $query; -			$this->query_result = ($cache_ttl && method_exists($cache, 'sql_load')) ? $cache->sql_load($query) : false; +			$this->query_result = ($cache_ttl && method_exists($cache->get_driver(), 'sql_load')) ? $cache->sql_load($query) : false;  			$this->sql_add_num_queries($this->query_result);  			if ($this->query_result === false) @@ -269,7 +269,7 @@ class dbal_firebird extends dbal  					}  				} -				if ($cache_ttl && method_exists($cache, 'sql_save')) +				if ($cache_ttl && method_exists($cache->get_driver(), 'sql_save'))  				{  					$this->open_queries[(int) $this->query_result] = $this->query_result;  					$cache->sql_save($query, $this->query_result, $cache_ttl); diff --git a/phpBB/includes/db/mssql.php b/phpBB/includes/db/mssql.php index fb044b492f..4fad3f2297 100644 --- a/phpBB/includes/db/mssql.php +++ b/phpBB/includes/db/mssql.php @@ -144,7 +144,7 @@ class dbal_mssql extends dbal  				$this->sql_report('start', $query);  			} -			$this->query_result = ($cache_ttl && method_exists($cache, 'sql_load')) ? $cache->sql_load($query) : false; +			$this->query_result = ($cache_ttl && method_exists($cache->get_driver(), 'sql_load')) ? $cache->sql_load($query) : false;  			$this->sql_add_num_queries($this->query_result);  			if ($this->query_result === false) @@ -159,7 +159,7 @@ class dbal_mssql extends dbal  					$this->sql_report('stop', $query);  				} -				if ($cache_ttl && method_exists($cache, 'sql_save')) +				if ($cache_ttl && method_exists($cache->get_driver(), 'sql_save'))  				{  					$this->open_queries[(int) $this->query_result] = $this->query_result;  					$cache->sql_save($query, $this->query_result, $cache_ttl); diff --git a/phpBB/includes/db/mssql_odbc.php b/phpBB/includes/db/mssql_odbc.php index 64fa9634d1..594de28b8b 100644 --- a/phpBB/includes/db/mssql_odbc.php +++ b/phpBB/includes/db/mssql_odbc.php @@ -163,7 +163,7 @@ class dbal_mssql_odbc extends dbal  			}  			$this->last_query_text = $query; -			$this->query_result = ($cache_ttl && method_exists($cache, 'sql_load')) ? $cache->sql_load($query) : false; +			$this->query_result = ($cache_ttl && method_exists($cache->get_driver(), 'sql_load')) ? $cache->sql_load($query) : false;  			$this->sql_add_num_queries($this->query_result);  			if ($this->query_result === false) @@ -178,7 +178,7 @@ class dbal_mssql_odbc extends dbal  					$this->sql_report('stop', $query);  				} -				if ($cache_ttl && method_exists($cache, 'sql_save')) +				if ($cache_ttl && method_exists($cache->get_driver(), 'sql_save'))  				{  					$this->open_queries[(int) $this->query_result] = $this->query_result;  					$cache->sql_save($query, $this->query_result, $cache_ttl); diff --git a/phpBB/includes/db/mssqlnative.php b/phpBB/includes/db/mssqlnative.php index 1f37d54ecb..7f64ca1784 100644 --- a/phpBB/includes/db/mssqlnative.php +++ b/phpBB/includes/db/mssqlnative.php @@ -318,7 +318,7 @@ class dbal_mssqlnative extends dbal  			}  			$this->last_query_text = $query; -			$this->query_result = ($cache_ttl && method_exists($cache, 'sql_load')) ? $cache->sql_load($query) : false; +			$this->query_result = ($cache_ttl && method_exists($cache->get_driver(), 'sql_load')) ? $cache->sql_load($query) : false;  			$this->sql_add_num_queries($this->query_result);  			if ($this->query_result === false) @@ -335,7 +335,7 @@ class dbal_mssqlnative extends dbal  					$this->sql_report('stop', $query);  				} -				if ($cache_ttl && method_exists($cache, 'sql_save')) +				if ($cache_ttl && method_exists($cache->get_driver(), 'sql_save'))  				{  					$this->open_queries[(int) $this->query_result] = $this->query_result;  					$cache->sql_save($query, $this->query_result, $cache_ttl); diff --git a/phpBB/includes/db/mysql.php b/phpBB/includes/db/mysql.php index 8d1f805870..31bb59711a 100644 --- a/phpBB/includes/db/mysql.php +++ b/phpBB/includes/db/mysql.php @@ -172,7 +172,7 @@ class dbal_mysql extends dbal  				$this->sql_report('start', $query);  			} -			$this->query_result = ($cache_ttl && method_exists($cache, 'sql_load')) ? $cache->sql_load($query) : false; +			$this->query_result = ($cache_ttl && method_exists($cache->get_driver(), 'sql_load')) ? $cache->sql_load($query) : false;  			$this->sql_add_num_queries($this->query_result);  			if ($this->query_result === false) @@ -187,7 +187,7 @@ class dbal_mysql extends dbal  					$this->sql_report('stop', $query);  				} -				if ($cache_ttl && method_exists($cache, 'sql_save')) +				if ($cache_ttl && method_exists($cache->get_driver(), 'sql_save'))  				{  					$this->open_queries[(int) $this->query_result] = $this->query_result;  					$cache->sql_save($query, $this->query_result, $cache_ttl); diff --git a/phpBB/includes/db/mysqli.php b/phpBB/includes/db/mysqli.php index e07cd35e24..538cd23015 100644 --- a/phpBB/includes/db/mysqli.php +++ b/phpBB/includes/db/mysqli.php @@ -179,7 +179,7 @@ class dbal_mysqli extends dbal  				$this->sql_report('start', $query);  			} -			$this->query_result = ($cache_ttl && method_exists($cache, 'sql_load')) ? $cache->sql_load($query) : false; +			$this->query_result = ($cache_ttl && method_exists($cache->get_driver(), 'sql_load')) ? $cache->sql_load($query) : false;  			$this->sql_add_num_queries($this->query_result);  			if ($this->query_result === false) @@ -194,7 +194,7 @@ class dbal_mysqli extends dbal  					$this->sql_report('stop', $query);  				} -				if ($cache_ttl && method_exists($cache, 'sql_save')) +				if ($cache_ttl && method_exists($cache->get_driver(), 'sql_save'))  				{  					$cache->sql_save($query, $this->query_result, $cache_ttl);  				} diff --git a/phpBB/includes/db/oracle.php b/phpBB/includes/db/oracle.php index 2e801532f0..fbad325eb9 100644 --- a/phpBB/includes/db/oracle.php +++ b/phpBB/includes/db/oracle.php @@ -242,7 +242,7 @@ class dbal_oracle extends dbal  			}  			$this->last_query_text = $query; -			$this->query_result = ($cache_ttl && method_exists($cache, 'sql_load')) ? $cache->sql_load($query) : false; +			$this->query_result = ($cache_ttl && method_exists($cache->get_driver(), 'sql_load')) ? $cache->sql_load($query) : false;  			$this->sql_add_num_queries($this->query_result);  			if ($this->query_result === false) @@ -418,7 +418,7 @@ class dbal_oracle extends dbal  					$this->sql_report('stop', $query);  				} -				if ($cache_ttl && method_exists($cache, 'sql_save')) +				if ($cache_ttl && method_exists($cache->get_driver(), 'sql_save'))  				{  					$this->open_queries[(int) $this->query_result] = $this->query_result;  					$cache->sql_save($query, $this->query_result, $cache_ttl); diff --git a/phpBB/includes/db/postgres.php b/phpBB/includes/db/postgres.php index bf22cffafa..e40fe5e370 100644 --- a/phpBB/includes/db/postgres.php +++ b/phpBB/includes/db/postgres.php @@ -200,7 +200,7 @@ class dbal_postgres extends dbal  			}  			$this->last_query_text = $query; -			$this->query_result = ($cache_ttl && method_exists($cache, 'sql_load')) ? $cache->sql_load($query) : false; +			$this->query_result = ($cache_ttl && method_exists($cache->get_driver(), 'sql_load')) ? $cache->sql_load($query) : false;  			$this->sql_add_num_queries($this->query_result);  			if ($this->query_result === false) @@ -215,7 +215,7 @@ class dbal_postgres extends dbal  					$this->sql_report('stop', $query);  				} -				if ($cache_ttl && method_exists($cache, 'sql_save')) +				if ($cache_ttl && method_exists($cache->get_driver(), 'sql_save'))  				{  					$this->open_queries[(int) $this->query_result] = $this->query_result;  					$cache->sql_save($query, $this->query_result, $cache_ttl); diff --git a/phpBB/includes/db/sqlite.php b/phpBB/includes/db/sqlite.php index 86bfa75a13..e770dc0a91 100644 --- a/phpBB/includes/db/sqlite.php +++ b/phpBB/includes/db/sqlite.php @@ -117,7 +117,7 @@ class dbal_sqlite extends dbal  				$this->sql_report('start', $query);  			} -			$this->query_result = ($cache_ttl && method_exists($cache, 'sql_load')) ? $cache->sql_load($query) : false; +			$this->query_result = ($cache_ttl && method_exists($cache->get_driver(), 'sql_load')) ? $cache->sql_load($query) : false;  			$this->sql_add_num_queries($this->query_result);  			if ($this->query_result === false) @@ -132,7 +132,7 @@ class dbal_sqlite extends dbal  					$this->sql_report('stop', $query);  				} -				if ($cache_ttl && method_exists($cache, 'sql_save')) +				if ($cache_ttl && method_exists($cache->get_driver(), 'sql_save'))  				{  					$this->open_queries[(int) $this->query_result] = $this->query_result;  					$cache->sql_save($query, $this->query_result, $cache_ttl); | 
