aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCallum Macrae <callum@lynxphp.com>2011-07-26 13:28:08 +0100
committerCallum Macrae <callum@lynxphp.com>2011-07-26 13:43:52 +0100
commit7e01850a4252aa68df6ab5c23e8dc12e8b0b66bd (patch)
treef1ca807bcd3aa717e453a9395a1b0e7c1ceff478
parent13ca659f1f992f3cd4f8395366ccd01b951ee96d (diff)
downloadforums-7e01850a4252aa68df6ab5c23e8dc12e8b0b66bd.tar
forums-7e01850a4252aa68df6ab5c23e8dc12e8b0b66bd.tar.gz
forums-7e01850a4252aa68df6ab5c23e8dc12e8b0b66bd.tar.bz2
forums-7e01850a4252aa68df6ab5c23e8dc12e8b0b66bd.tar.xz
forums-7e01850a4252aa68df6ab5c23e8dc12e8b0b66bd.zip
[ticket/10293] Fixed the JavaScript in the jumpbox.
The current code is invalid, and results in an critical error which aborts the script before it gets to return false, thus allowing the form to submit with an invalid forum ID. This commit fixes that by referencing "this" instead of "document.jumpbox", which didn't exist because the form had no name. PHPBB3-10293
-rw-r--r--phpBB/styles/prosilver/template/jumpbox.html2
1 files changed, 1 insertions, 1 deletions
diff --git a/phpBB/styles/prosilver/template/jumpbox.html b/phpBB/styles/prosilver/template/jumpbox.html
index f7b4fca609..1029627561 100644
--- a/phpBB/styles/prosilver/template/jumpbox.html
+++ b/phpBB/styles/prosilver/template/jumpbox.html
@@ -10,7 +10,7 @@
<!-- ENDIF -->
<!-- IF S_DISPLAY_JUMPBOX -->
- <form method="post" id="jumpbox" action="{S_JUMPBOX_ACTION}" onsubmit="if(document.jumpbox.f.value == -1){return false;}">
+ <form method="post" id="jumpbox" action="{S_JUMPBOX_ACTION}" onsubmit="if(this.f.value == -1){return false;}">
<!-- IF $CUSTOM_FIELDSET_CLASS -->
<fieldset class="{$CUSTOM_FIELDSET_CLASS}">