diff options
| author | U-H-PC\H <kellanved@phpbb.com> | 2010-03-28 14:17:42 +0200 |
|---|---|---|
| committer | U-H-PC\H <kellanved@phpbb.com> | 2010-03-28 14:17:42 +0200 |
| commit | 6cfb4c82dd4f81cade9b75fb730ebe8c2343b709 (patch) | |
| tree | 52a454d58342b489315b17b3fa8c6cff01edceeb | |
| parent | d79cff235c761d10c148eb1434ce72289f4327a0 (diff) | |
| download | forums-6cfb4c82dd4f81cade9b75fb730ebe8c2343b709.tar forums-6cfb4c82dd4f81cade9b75fb730ebe8c2343b709.tar.gz forums-6cfb4c82dd4f81cade9b75fb730ebe8c2343b709.tar.bz2 forums-6cfb4c82dd4f81cade9b75fb730ebe8c2343b709.tar.xz forums-6cfb4c82dd4f81cade9b75fb730ebe8c2343b709.zip | |
[bug/58465] The redirect hidden field is now XHTML conform
The result of build_url was falsely un-entitized.
| -rw-r--r-- | phpBB/docs/CHANGELOG.html | 1 | ||||
| -rw-r--r-- | phpBB/includes/functions.php | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html index 08f8be32fd..fabf2dad4f 100644 --- a/phpBB/docs/CHANGELOG.html +++ b/phpBB/docs/CHANGELOG.html @@ -105,6 +105,7 @@ <li>[Fix] Correct redirection after login to forum not in web root (Bug #58755)</li> <li>[Fix] Allow setting parent forums regardless of permission settings. (Bug #57415)</li> <li>[Fix] Redirect search engines that access pages with SIDs in the URL. (Bug #58025)</li> + <li>[Fix] Fix incorrect ampersand encoding in redirect parameter. (Bug #58465)</li> <li>[Feature] Support for Microsoft's Native SQL Server Driver for PHP (Bug #57055 - Patch by Chris Pucci at Microsoft)</li> <li>[Feature] The memcache acm plugin now supports multiple memcache servers.</li> </ul> diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php index 5878c1977d..4f52c7c2ce 100644 --- a/phpBB/includes/functions.php +++ b/phpBB/includes/functions.php @@ -4257,7 +4257,7 @@ function page_header($page_title = '', $display_online_list = true, $item_id = 0 'S_TOPIC_ID' => $topic_id, 'S_LOGIN_ACTION' => ((!defined('ADMIN_START')) ? append_sid("{$phpbb_root_path}ucp.$phpEx", 'mode=login') : append_sid("index.$phpEx", false, true, $user->session_id)), - 'S_LOGIN_REDIRECT' => build_hidden_fields(array('redirect' => str_replace('&', '&', build_url()))), + 'S_LOGIN_REDIRECT' => build_hidden_fields(array('redirect' => build_url())), 'S_ENABLE_FEEDS' => ($config['feed_enable']) ? true : false, 'S_ENABLE_FEEDS_OVERALL' => ($config['feed_overall']) ? true : false, |