diff options
| author | Cesar G <prototech91@gmail.com> | 2014-02-27 19:29:02 -0800 |
|---|---|---|
| committer | Cesar G <prototech91@gmail.com> | 2014-02-27 19:29:02 -0800 |
| commit | 5c3fc4840c6c5729b7144b8f268990684f151b12 (patch) | |
| tree | ccc1a76371449747af252f5bf57136df9c9e5458 | |
| parent | 620f2840d742056224efa4e41dfe31d1ba7b7c7d (diff) | |
| download | forums-5c3fc4840c6c5729b7144b8f268990684f151b12.tar forums-5c3fc4840c6c5729b7144b8f268990684f151b12.tar.gz forums-5c3fc4840c6c5729b7144b8f268990684f151b12.tar.bz2 forums-5c3fc4840c6c5729b7144b8f268990684f151b12.tar.xz forums-5c3fc4840c6c5729b7144b8f268990684f151b12.zip | |
[ticket/12232] Remove excessive calls to sizeof() in assign_block_vars() method
The size of the template block array is calculated within a foreach loop
iterating through the array, which is unnecessary. It only needs to be done
once. In a block of 1000 rows, this results in
500,500 calls to sizeof() in this location. With this change, that's reduced to
1000.
PHPBB3-12232
| -rw-r--r-- | phpBB/phpbb/template/context.php | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/phpBB/phpbb/template/context.php b/phpBB/phpbb/template/context.php index 65c7d094a0..ef01034c52 100644 --- a/phpBB/phpbb/template/context.php +++ b/phpBB/phpbb/template/context.php @@ -186,11 +186,12 @@ class context // Add a new iteration to this block with the variable assignments we were given. $this->tpldata[$blockname][] = $vararray; + $s_num_rows = sizeof($this->tpldata[$blockname]); // Set S_NUM_ROWS foreach ($this->tpldata[$blockname] as &$mod_block) { - $mod_block['S_NUM_ROWS'] = sizeof($this->tpldata[$blockname]); + $mod_block['S_NUM_ROWS'] = $s_num_rows; } } |