diff options
| author | Marc Alexander <admin@m-a-styles.de> | 2015-05-14 12:53:29 +0200 |
|---|---|---|
| committer | Marc Alexander <admin@m-a-styles.de> | 2015-05-14 12:53:29 +0200 |
| commit | 4527789e5054db42d7117caebebe45a591246ec5 (patch) | |
| tree | a4a3bd6216074ea07ae63c6266d17abfacaf1dd4 | |
| parent | b3b7f8e925a2af91d578ad4453070cefc02e7a3d (diff) | |
| parent | 084aa567772e9d56012e1fd251478f75c6cd5a3b (diff) | |
| download | forums-4527789e5054db42d7117caebebe45a591246ec5.tar forums-4527789e5054db42d7117caebebe45a591246ec5.tar.gz forums-4527789e5054db42d7117caebebe45a591246ec5.tar.bz2 forums-4527789e5054db42d7117caebebe45a591246ec5.tar.xz forums-4527789e5054db42d7117caebebe45a591246ec5.zip | |
Merge pull request #3605 from Nicofuma/ticket/13830
[ticket/13830] Check class used in catch statements
| -rw-r--r-- | build/code_sniffer/phpbb/Sniffs/Namespaces/UnusedUseSniff.php | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/build/code_sniffer/phpbb/Sniffs/Namespaces/UnusedUseSniff.php b/build/code_sniffer/phpbb/Sniffs/Namespaces/UnusedUseSniff.php index 18cb8ba82e..9f68ee1341 100644 --- a/build/code_sniffer/phpbb/Sniffs/Namespaces/UnusedUseSniff.php +++ b/build/code_sniffer/phpbb/Sniffs/Namespaces/UnusedUseSniff.php @@ -195,6 +195,20 @@ class phpbb_Sniffs_Namespaces_UnusedUseSniff implements PHP_CodeSniffer_Sniff } } + // Checks in catch blocks + $old_catch = $stackPtr; + while (($catch = $phpcsFile->findNext(T_CATCH, ($old_catch + 1))) !== false) + { + $old_catch = $catch; + + $caught_class_name_start = $phpcsFile->findNext(array(T_NS_SEPARATOR, T_STRING), $catch + 1); + $caught_class_name_end = $phpcsFile->findNext($find, $caught_class_name_start, null, true); + + $caught_class_name = trim($phpcsFile->getTokensAsString($caught_class_name_start, ($caught_class_name_end - $caught_class_name_start))); + + $ok = $this->check($phpcsFile, $caught_class_name, $class_name_full, $class_name_short, $catch) ? true : $ok; + } + if (!$ok) { $error = 'There must not be unused USE statements.'; |