diff options
| author | mrgoldy <gijsmartens1@gmail.com> | 2019-11-10 22:28:53 +0100 |
|---|---|---|
| committer | mrgoldy <gijsmartens1@gmail.com> | 2019-11-10 22:59:55 +0100 |
| commit | 3e22a2eebdc29ae6f2dc828f0886888fb2d385a8 (patch) | |
| tree | 9487d3c7cf128fef2bf3d4341f2631c138613306 | |
| parent | 79a6648b99bc570dd9705547a35e21df808a6657 (diff) | |
| download | forums-3e22a2eebdc29ae6f2dc828f0886888fb2d385a8.tar forums-3e22a2eebdc29ae6f2dc828f0886888fb2d385a8.tar.gz forums-3e22a2eebdc29ae6f2dc828f0886888fb2d385a8.tar.bz2 forums-3e22a2eebdc29ae6f2dc828f0886888fb2d385a8.tar.xz forums-3e22a2eebdc29ae6f2dc828f0886888fb2d385a8.zip | |
[ticket/16206] Remove offsetExists and set non-NULL value
PHPBB3-16206
| -rw-r--r-- | phpBB/phpbb/di/service_collection.php | 19 |
1 files changed, 2 insertions, 17 deletions
diff --git a/phpBB/phpbb/di/service_collection.php b/phpBB/phpbb/di/service_collection.php index 8c1c172e36..6298670c42 100644 --- a/phpBB/phpbb/di/service_collection.php +++ b/phpBB/phpbb/di/service_collection.php @@ -49,21 +49,6 @@ class service_collection extends \ArrayObject return new service_collection_iterator($this); } - // Because of a PHP issue we have to redefine offsetExists - // (even with a call to the parent): - // https://bugs.php.net/bug.php?id=66834 - // https://bugs.php.net/bug.php?id=67067 - // But it triggers a sniffer issue that we have to skip - // @codingStandardsIgnoreStart - /** - * {@inheritdoc} - */ - public function offsetExists($index) - { - return parent::offsetExists($index); - } - // @codingStandardsIgnoreEnd - /** * {@inheritdoc} */ @@ -76,11 +61,11 @@ class service_collection extends \ArrayObject * Add a service to the collection * * @param string $name The service name - * @return null + * @return void */ public function add($name) { - $this->offsetSet($name, null); + $this->offsetSet($name, false); } /** |