diff options
| author | Tristan Darricau <github@nicofuma.fr> | 2014-06-15 20:52:51 +0200 |
|---|---|---|
| committer | Tristan Darricau <github@nicofuma.fr> | 2014-06-16 22:35:12 +0200 |
| commit | 34a4ba36cd554ebd3cab1bdbb422d97a9429bd72 (patch) | |
| tree | caa56f72f2bfb25dd8e537d87bbfcdf4e870e1ff | |
| parent | 1aec0d29fd573950d5fbfd224997aac546df9b05 (diff) | |
| download | forums-34a4ba36cd554ebd3cab1bdbb422d97a9429bd72.tar forums-34a4ba36cd554ebd3cab1bdbb422d97a9429bd72.tar.gz forums-34a4ba36cd554ebd3cab1bdbb422d97a9429bd72.tar.bz2 forums-34a4ba36cd554ebd3cab1bdbb422d97a9429bd72.tar.xz forums-34a4ba36cd554ebd3cab1bdbb422d97a9429bd72.zip | |
[ticket/12721] Add Squiz.Arrays.ArrayBracketSpacing in the legacy ruleset
PHPBB3-12721
| -rw-r--r-- | build/code_sniffer/ruleset-php-legacy.xml | 3 | ||||
| -rw-r--r-- | phpBB/includes/acp/acp_extensions.php | 2 | ||||
| -rw-r--r-- | phpBB/phpbb/db/driver/mssqlnative.php | 6 |
3 files changed, 7 insertions, 4 deletions
diff --git a/build/code_sniffer/ruleset-php-legacy.xml b/build/code_sniffer/ruleset-php-legacy.xml index fe42d25431..175a993f48 100644 --- a/build/code_sniffer/ruleset-php-legacy.xml +++ b/build/code_sniffer/ruleset-php-legacy.xml @@ -38,6 +38,9 @@ <!-- Each file MUST end with exactly one newline character --> <rule ref="PSR2.Files.EndFileNewline" /> + <!-- When referencing arrays you should not put whitespace around the opening bracket or before the closing bracket. --> + <rule ref="Squiz.Arrays.ArrayBracketSpacing" /> + <!-- In the argument list, there MUST NOT be a space before each comma, and there MUST be one space after each comma. --> <rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing"> diff --git a/phpBB/includes/acp/acp_extensions.php b/phpBB/includes/acp/acp_extensions.php index 3d3cfb7f16..b2a6820461 100644 --- a/phpBB/includes/acp/acp_extensions.php +++ b/phpBB/includes/acp/acp_extensions.php @@ -527,7 +527,7 @@ class acp_extensions $version_helper = new \phpbb\version_helper($this->cache, $this->config, $this->user); $version_helper->set_current_version($meta['version']); - $version_helper->set_file_location($version_check ['host'], $version_check ['directory'], $version_check ['filename']); + $version_helper->set_file_location($version_check['host'], $version_check['directory'], $version_check['filename']); $version_helper->force_stability($this->config['extension_force_unstable'] ? 'unstable' : null); return $updates = $version_helper->get_suggested_updates($force_update, $force_cache); diff --git a/phpBB/phpbb/db/driver/mssqlnative.php b/phpBB/phpbb/db/driver/mssqlnative.php index 9639bfa988..a7f93c8feb 100644 --- a/phpBB/phpbb/db/driver/mssqlnative.php +++ b/phpBB/phpbb/db/driver/mssqlnative.php @@ -319,10 +319,10 @@ class mssqlnative extends \phpbb\db\driver\mssql_base { foreach ($errors as $error) { - $error_message .= "SQLSTATE: " . $error[ 'SQLSTATE'] . "\n"; - $error_message .= "code: " . $error[ 'code'] . "\n"; + $error_message .= "SQLSTATE: " . $error['SQLSTATE'] . "\n"; + $error_message .= "code: " . $error['code'] . "\n"; $code = $error['code']; - $error_message .= "message: " . $error[ 'message'] . "\n"; + $error_message .= "message: " . $error['message'] . "\n"; } $this->last_error_result = $error_message; $error = $this->last_error_result; |