diff options
| author | Marc Alexander <admin@m-a-styles.de> | 2018-10-08 21:42:46 +0200 |
|---|---|---|
| committer | Marc Alexander <admin@m-a-styles.de> | 2018-10-08 21:42:46 +0200 |
| commit | 2c74cb71b51a36dd2e65e3d16ce8db49fba3732c (patch) | |
| tree | 3b4e986d07c0fd27e88e7553e5a0258ce1de8e77 | |
| parent | dd43c6a61ea189c14c909eb87c8311102b8da2b0 (diff) | |
| parent | 4ebd582947d44b4fa34e0fd81602a171b744b677 (diff) | |
| download | forums-2c74cb71b51a36dd2e65e3d16ce8db49fba3732c.tar forums-2c74cb71b51a36dd2e65e3d16ce8db49fba3732c.tar.gz forums-2c74cb71b51a36dd2e65e3d16ce8db49fba3732c.tar.bz2 forums-2c74cb71b51a36dd2e65e3d16ce8db49fba3732c.tar.xz forums-2c74cb71b51a36dd2e65e3d16ce8db49fba3732c.zip | |
Merge pull request #5301 from senky/ticket/11500
[ticket/11500] Remove unnamed input
| -rw-r--r-- | phpBB/adm/style/acp_profile.html | 2 | ||||
| -rw-r--r-- | tests/functional/acp_profile_field_test.php | 15 |
2 files changed, 9 insertions, 8 deletions
diff --git a/phpBB/adm/style/acp_profile.html b/phpBB/adm/style/acp_profile.html index bd3935b464..25bf97efd5 100644 --- a/phpBB/adm/style/acp_profile.html +++ b/phpBB/adm/style/acp_profile.html @@ -238,7 +238,7 @@ <form id="profile_fields" method="post" action="{U_ACTION}"> <fieldset class="quick"> - <input class="text small" type="text" name="field_ident" /> <select name="field_type">{S_TYPE_OPTIONS}</select> + <select name="field_type">{S_TYPE_OPTIONS}</select> <input class="button1" type="submit" name="submit" value="{L_CREATE_NEW_FIELD}" /> <input type="hidden" name="create" value="1" /> {S_FORM_TOKEN} diff --git a/tests/functional/acp_profile_field_test.php b/tests/functional/acp_profile_field_test.php index 88df782faa..7a0a6ca941 100644 --- a/tests/functional/acp_profile_field_test.php +++ b/tests/functional/acp_profile_field_test.php @@ -28,18 +28,20 @@ class phpbb_functional_acp_profile_field_test extends phpbb_functional_test_case public function data_add_profile_field() { return array( - array('bool', 'profilefields.type.bool', + array('profilefields.type.bool', array( + 'field_ident' => 'bool', + 'lang_name' => 'bool', 'lang_options[0]' => 'foo', 'lang_options[1]' => 'bar', ), - array(), ), - array('dropdown', 'profilefields.type.dropdown', + array('profilefields.type.dropdown', array( + 'field_ident' => 'dropdown', + 'lang_name' => 'dropdown', 'lang_options' => "foo\nbar\nbar\nfoo", ), - array(), ), ); } @@ -47,13 +49,12 @@ class phpbb_functional_acp_profile_field_test extends phpbb_functional_test_case /** * @dataProvider data_add_profile_field */ - public function test_add_profile_field($name, $type, $page1_settings, $page2_settings) + public function test_add_profile_field($type, $page1_settings) { // Custom profile fields page $crawler = self::request('GET', 'adm/index.php?i=acp_profile&mode=profile&sid=' . $this->sid); // these language strings are html $form = $crawler->selectButton('Create new field')->form(array( - 'field_ident' => $name, 'field_type' => $type, )); $crawler = self::submit($form); @@ -63,7 +64,7 @@ class phpbb_functional_acp_profile_field_test extends phpbb_functional_test_case $crawler = self::submit($form); // Fill form for profile field specific options - $form = $crawler->selectButton('Save')->form($page2_settings); + $form = $crawler->selectButton('Save')->form(); $crawler= self::submit($form); $this->assertContainsLang('ADDED_PROFILE_FIELD', $crawler->text()); |