aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMeik Sievertsen <acydburn@phpbb.com>2008-01-29 14:33:53 +0000
committerMeik Sievertsen <acydburn@phpbb.com>2008-01-29 14:33:53 +0000
commit1819be3ed12eafa6582e4b605196c74e0a7d8f95 (patch)
tree882a18b8fe1e70165f9dd8893ca41302dd3cf315
parent9f5841219a3a2cb41e5078967682e64c6f398067 (diff)
downloadforums-1819be3ed12eafa6582e4b605196c74e0a7d8f95.tar
forums-1819be3ed12eafa6582e4b605196c74e0a7d8f95.tar.gz
forums-1819be3ed12eafa6582e4b605196c74e0a7d8f95.tar.bz2
forums-1819be3ed12eafa6582e4b605196c74e0a7d8f95.tar.xz
forums-1819be3ed12eafa6582e4b605196c74e0a7d8f95.zip
Merge revision #r8343
git-svn-id: file:///svn/phpbb/trunk@8344 89ea8834-ac86-4346-8a33-228a782c2dd0
-rw-r--r--phpBB/docs/CHANGELOG.html1
-rw-r--r--phpBB/includes/session.php10
2 files changed, 6 insertions, 5 deletions
diff --git a/phpBB/docs/CHANGELOG.html b/phpBB/docs/CHANGELOG.html
index b54f212e91..61f95d9146 100644
--- a/phpBB/docs/CHANGELOG.html
+++ b/phpBB/docs/CHANGELOG.html
@@ -104,6 +104,7 @@
<li>[Fix] Allow calls to $user->set_cookie() define no cookie time for setting session cookies (Bug #18025)</li>
<li>[Fix] Stricter checks on smilie packs (Bug #19675)</li>
<li>[Fix] Gracefully return from cancelling pm drafts (Bug #19675)</li>
+ <li>[Fix] Possible login problems with IE7 if browser check is activated (Bug #20135)</li>
</ul>
<a name="v30rc8"></a><h3>1.i. Changes since 3.0.RC8</h3>
diff --git a/phpBB/includes/session.php b/phpBB/includes/session.php
index ff91c5df30..ee385dfaed 100644
--- a/phpBB/includes/session.php
+++ b/phpBB/includes/session.php
@@ -256,8 +256,8 @@ class session
$u_ip = implode('.', array_slice(explode('.', $this->ip), 0, $config['ip_check']));
}
- $s_browser = ($config['browser_check']) ? strtolower(substr($this->data['session_browser'], 0, 149)) : '';
- $u_browser = ($config['browser_check']) ? strtolower(substr($this->browser, 0, 149)) : '';
+ $s_browser = ($config['browser_check']) ? trim(strtolower(substr($this->data['session_browser'], 0, 149))) : '';
+ $u_browser = ($config['browser_check']) ? trim(strtolower(substr($this->browser, 0, 149))) : '';
$s_forwarded_for = ($config['forwarded_for_check']) ? substr($this->data['session_forwarded_for'], 0, 254) : '';
$u_forwarded_for = ($config['forwarded_for_check']) ? substr($this->forwarded_for, 0, 254) : '';
@@ -526,8 +526,8 @@ class session
$u_ip = implode('.', array_slice(explode('.', $this->ip), 0, $config['ip_check']));
}
- $s_browser = ($config['browser_check']) ? strtolower(substr($this->data['session_browser'], 0, 149)) : '';
- $u_browser = ($config['browser_check']) ? strtolower(substr($this->browser, 0, 149)) : '';
+ $s_browser = ($config['browser_check']) ? trim(strtolower(substr($this->data['session_browser'], 0, 149))) : '';
+ $u_browser = ($config['browser_check']) ? trim(strtolower(substr($this->browser, 0, 149))) : '';
$s_forwarded_for = ($config['forwarded_for_check']) ? substr($this->data['session_forwarded_for'], 0, 254) : '';
$u_forwarded_for = ($config['forwarded_for_check']) ? substr($this->forwarded_for, 0, 254) : '';
@@ -579,7 +579,7 @@ class session
'session_start' => (int) $this->time_now,
'session_last_visit' => (int) $this->data['session_last_visit'],
'session_time' => (int) $this->time_now,
- 'session_browser' => (string) substr($this->browser, 0, 149),
+ 'session_browser' => (string) trim(substr($this->browser, 0, 149)),
'session_forwarded_for' => (string) $this->forwarded_for,
'session_ip' => (string) $this->ip,
'session_autologin' => ($session_autologin) ? 1 : 0,