aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrxu <rxu@mail.ru>2014-10-27 21:43:10 +0700
committerNils Adermann <naderman@naderman.de>2014-10-27 17:01:29 -0700
commit16d78407db91a1f2762fd99e4ba16a1bdffe9a06 (patch)
tree465099b76d54a3a294c396f19bbff89c7a0e9469
parentaa916fc43f256952eafc81379af9e0b292497044 (diff)
downloadforums-16d78407db91a1f2762fd99e4ba16a1bdffe9a06.tar
forums-16d78407db91a1f2762fd99e4ba16a1bdffe9a06.tar.gz
forums-16d78407db91a1f2762fd99e4ba16a1bdffe9a06.tar.bz2
forums-16d78407db91a1f2762fd99e4ba16a1bdffe9a06.tar.xz
forums-16d78407db91a1f2762fd99e4ba16a1bdffe9a06.zip
[ticket/13229] Fix overloading memberlist with redundant SQL queries
PHPBB3-13229
-rw-r--r--phpBB/includes/functions_display.php4
-rw-r--r--phpBB/memberlist.php2
2 files changed, 3 insertions, 3 deletions
diff --git a/phpBB/includes/functions_display.php b/phpBB/includes/functions_display.php
index 745eb20c77..48c34ecfe6 100644
--- a/phpBB/includes/functions_display.php
+++ b/phpBB/includes/functions_display.php
@@ -1491,7 +1491,7 @@ function phpbb_get_user_rank($user_data, $user_posts)
/**
* Prepare profile data
*/
-function phpbb_show_profile($data, $user_notes_enabled = false, $warn_user_enabled = false)
+function phpbb_show_profile($data, $user_notes_enabled = false, $warn_user_enabled = false, $check_can_receive_pm = true)
{
global $config, $auth, $user, $phpEx, $phpbb_root_path, $phpbb_dispatcher;
@@ -1559,7 +1559,7 @@ function phpbb_show_profile($data, $user_notes_enabled = false, $warn_user_enabl
}
// Can this user receive a Private Message?
- $can_receive_pm = (
+ $can_receive_pm = $check_can_receive_pm && (
// They must be a "normal" user
$data['user_type'] != USER_IGNORE &&
diff --git a/phpBB/memberlist.php b/phpBB/memberlist.php
index 439b97b47f..4f31178ffb 100644
--- a/phpBB/memberlist.php
+++ b/phpBB/memberlist.php
@@ -1427,7 +1427,7 @@ switch ($mode)
$cp_row = (isset($profile_fields_cache[$user_id])) ? $cp->generate_profile_fields_template_data($profile_fields_cache[$user_id], false) : array();
}
- $memberrow = array_merge(phpbb_show_profile($row), array(
+ $memberrow = array_merge(phpbb_show_profile($row, false, false, false), array(
'ROW_NUMBER' => $i + ($start + 1),
'S_CUSTOM_PROFILE' => (isset($cp_row['row']) && sizeof($cp_row['row'])) ? true : false,