aboutsummaryrefslogtreecommitdiffstats
path: root/xt/lib
diff options
context:
space:
mode:
authorMax Kanat-Alexander <mkanat@bugzilla.org>2010-10-02 12:45:23 -0700
committerMax Kanat-Alexander <mkanat@bugzilla.org>2010-10-02 12:45:23 -0700
commit38230573e91978fcf0b5a768ca7aa9ec121ab1cc (patch)
treea8fcdb4f82ce9021eae5226c1f92dffb7846d46b /xt/lib
parent380fca01fdebfb84544c02adced886a64c1ab85e (diff)
downloadbugs-38230573e91978fcf0b5a768ca7aa9ec121ab1cc.tar
bugs-38230573e91978fcf0b5a768ca7aa9ec121ab1cc.tar.gz
bugs-38230573e91978fcf0b5a768ca7aa9ec121ab1cc.tar.bz2
bugs-38230573e91978fcf0b5a768ca7aa9ec121ab1cc.tar.xz
bugs-38230573e91978fcf0b5a768ca7aa9ec121ab1cc.zip
Change the way that the xt/search.t injection tests look for known broken
tests, so that the Pg tests properly understand that they can't test creation_ts changedafter or changedbefore, *ever*. https://bugzilla.mozilla.org/show_bug.cgi?id=600496
Diffstat (limited to 'xt/lib')
-rw-r--r--xt/lib/Bugzilla/Test/Search/InjectionTest.pm5
1 files changed, 2 insertions, 3 deletions
diff --git a/xt/lib/Bugzilla/Test/Search/InjectionTest.pm b/xt/lib/Bugzilla/Test/Search/InjectionTest.pm
index 1ee83c57c..1bd9fd82c 100644
--- a/xt/lib/Bugzilla/Test/Search/InjectionTest.pm
+++ b/xt/lib/Bugzilla/Test/Search/InjectionTest.pm
@@ -37,15 +37,14 @@ sub _known_broken {
# We don't want to auto-vivify $operator_broken and thus make it true.
my @field_ok = $operator_broken ? @{ $operator_broken->{field_ok} || [] }
: ();
-
- return {} if grep { $_ eq $self->field } @field_ok;
+ $operator_broken = undef if grep { $_ eq $self->field } @field_ok;
my $field_broken = INJECTION_BROKEN_FIELD->{$self->field}
|| INJECTION_BROKEN_FIELD->{$self->field_object->type};
# We don't want to auto-vivify $field_broken and thus make it true.
my @operator_ok = $field_broken ? @{ $field_broken->{operator_ok} || [] }
: ();
- return {} if grep { $_ eq $self->operator } @operator_ok;
+ $field_broken = undef if grep { $_ eq $self->operator } @operator_ok;
return $operator_broken || $field_broken || {};
}