diff options
| author | Frédéric Buclin <LpSolit@gmail.com> | 2015-04-05 21:48:58 +0200 |
|---|---|---|
| committer | Frédéric Buclin <LpSolit@gmail.com> | 2015-04-05 21:48:58 +0200 |
| commit | c2c8f774694bd9782fe3310204b626ea20e43b6e (patch) | |
| tree | d5c7e1690d8a7b838822a9b15c6aab6e7ba3a2ea /template | |
| parent | 9c9eac99fd7008f2b711a33736f21e5103791a04 (diff) | |
| download | bugs-c2c8f774694bd9782fe3310204b626ea20e43b6e.tar bugs-c2c8f774694bd9782fe3310204b626ea20e43b6e.tar.gz bugs-c2c8f774694bd9782fe3310204b626ea20e43b6e.tar.bz2 bugs-c2c8f774694bd9782fe3310204b626ea20e43b6e.tar.xz bugs-c2c8f774694bd9782fe3310204b626ea20e43b6e.zip | |
Bug 1143874: Improve load time of bug comments
r=dkl a=sgreen
Diffstat (limited to 'template')
| -rw-r--r-- | template/en/default/bug/comments.html.tmpl | 19 |
1 files changed, 10 insertions, 9 deletions
diff --git a/template/en/default/bug/comments.html.tmpl b/template/en/default/bug/comments.html.tmpl index d040e651d..f4f79ec5c 100644 --- a/template/en/default/bug/comments.html.tmpl +++ b/template/en/default/bug/comments.html.tmpl @@ -46,6 +46,7 @@ [% DEFAULT mode = "show" %] [% user_cache = template_cache.users %] +[% can_edit_comments = bug.check_can_change_field('longdesc', 0, 1) %] <!-- This auto-sizes the comments and positions the collapse/expand links to the right. --> @@ -53,9 +54,7 @@ <tr> <td> -[% FOREACH comment = comments %] - [% PROCESS a_comment %] -[% END %] +[% PROCESS display_comments %] [% IF mode == "edit" && user.id && user.settings.comment_box_position.value == "before_comments" %] @@ -96,10 +95,11 @@ [%# Block for individual comments #%] [%############################################################################%] -[% BLOCK a_comment %] - [% RETURN IF comment.is_private AND NOT (user.is_insider || user.id == comment.author.id) %] - [% comment_text = comment.body_full %] - [% RETURN IF comment_text == '' AND (comment.work_time - 0) != 0 AND !user.is_timetracker %] +[% BLOCK display_comments %] + [% FOREACH comment = comments %] + [% NEXT IF comment.is_private AND NOT (user.is_insider || user.id == comment.author.id) %] + [% comment_text = comment.body_full %] + [% NEXT IF comment_text == '' AND (comment.work_time - 0) != 0 AND !user.is_timetracker %] <div id="c[% comment.count %]" class="bz_comment[% " bz_private" IF comment.is_private %] [% " bz_default_collapsed" IF comment.collapsed %] @@ -119,7 +119,7 @@ [% IF comment.collapsed %] <span class="bz_collapsed_actions"> [% END %] - [% IF bug.check_can_change_field('longdesc', 0, 1) %] + [% IF can_edit_comments %] [% IF user.can_tag_comments %] [<a href="#" onclick="YAHOO.bugzilla.commentTagging.toggle([% comment.id %], [% comment.count %]);return false">tag</a>] @@ -145,7 +145,7 @@ </span> [% END %] - [% IF mode == "edit" && user.is_insider && bug.check_can_change_field('longdesc', 0, 1) %] + [% IF mode == "edit" && can_edit_comments && user.is_insider %] <div class="bz_private_checkbox"> <input type="hidden" value="1" name="defined_isprivate_[% comment.id %]"> @@ -233,4 +233,5 @@ </pre> [% Hook.process('a_comment-end', 'bug/comments.html.tmpl') %] </div> + [% END %] [% END %] |