Bug 920681: Remove the cellspacing and cellpadding attributes from tables

r/a=justdave

5 files changed, 36 insertions, 64 deletions

diff --git a/template/en/default/reports/components.html.tmpl b/template/en/default/reports/components.html.tmpl
index 2a5d2399b..c307caedb 100644
--- a/template/en/default/reports/components.html.tmpl
+++ b/template/en/default/reports/components.html.tmpl
@@ -26,39 +26,23 @@
   [% numcols = 2 %]
 [% END %]
 
-<table cellpadding="0" cellspacing="0" id="components_header_table">
-  <tr>
-    <td class="instructions">
-      Select a component to see open [% terms.bugs %] in that component:
-    </td>
-    <td class="product_container">
-      <span class="product_name">[% product.name FILTER html %]</span>
-      <div class="product_desc">
-        [% product.description FILTER html_light %]
-      </div>
-    </td>
-  </tr>
-</table>
+<h1>[% product.name FILTER html %]</h1>
 
-<span class="components_header">Components</span>
+<div class="product_desc">[% product.description FILTER html_light %]</div>
+<p>Select a component to see open [% terms.bugs %] in that component.</p>
 
-<table summary="Components table"
-       class="component_table" cellspacing="0" cellpadding="0">
-  <thead>
+<table class="component_table">
   <tr>
-    <th>&nbsp;</th>
+    <th>Component</th>
     <th>Default Assignee</th>
     [% IF Param("useqacontact") %]
       <th>Default QA Contact</th>
     [% END %]
   </tr>
-  </thead>
 
-  <tbody>
   [% FOREACH comp = product.components %]
     [% INCLUDE describe_comp %]
   [% END %]
-  </tbody>
 </table>
 
 [% PROCESS global/footer.html.tmpl %]
diff --git a/template/en/default/reports/duplicates-table.html.tmpl b/template/en/default/reports/duplicates-table.html.tmpl
index 45cf8c394..0484c8fcd 100644
--- a/template/en/default/reports/duplicates-table.html.tmpl
+++ b/template/en/default/reports/duplicates-table.html.tmpl
@@ -53,7 +53,7 @@
 [% base_args_string = base_args.join('&amp;') %]
 
 [% IF bugs.size %]
-  <table id="duplicates_table" cellpadding="0" cellspacing="0">
+  <table id="duplicates_table">
     <thead>
       <tr>
         [% FOREACH column = columns %]
diff --git a/template/en/default/reports/keywords.html.tmpl b/template/en/default/reports/keywords.html.tmpl
index b9a2fd795..598979d33 100644
--- a/template/en/default/reports/keywords.html.tmpl
+++ b/template/en/default/reports/keywords.html.tmpl
@@ -12,7 +12,6 @@
   #   name: the name of the keyword
   #   description: keyword description. Can contain some limited HTML code.
   #   bug_count: number of bugs with that keyword
-  # caneditkeywords: boolean. True if this user can edit keywords
  %]
 
 [% PROCESS global/header.html.tmpl
@@ -20,27 +19,19 @@
   style_urls = ['skins/standard/admin.css']
 %]
 
-[% FOREACH keyword = keywords %]
-  [% IF loop.index % 50 == 0 %]
-    [% IF loop.index != 0 %]
-       </table>
-    [% END %]
-
-    <table border="1" cellpadding="4" cellspacing="0">
-      <tr class="column_header">
-        <th>Name</th>
-        <th>Description</th>
-        <th>Open [% terms.Bugs %]</th>
-        <th>Total [% terms.Bugs %]</th>
-      </tr>
-  [% END %]
+<table id="admin_table">
+  <tr class="column_header">
+    <th>Name</th>
+    <th>Description</th>
+    <th>Open [% terms.Bugs %]</th>
+    <th>Total [% terms.Bugs %]</th>
+  </tr>
 
+  [% FOREACH keyword = keywords %]
   <tr id="[% keyword.name FILTER html %]">
-    <th>
-        [% keyword.name FILTER html %]
-    </th>
+    <td>[% keyword.name FILTER html %]</td>
     <td>[% keyword.description FILTER html_light %]</td>
-    <td align="center">
+    <td class="center">
       [% IF keyword.bug_count > 0 %]
         <a href="buglist.cgi?keywords=[% keyword.name FILTER uri %]&amp;resolution=---">
           Search</a>
@@ -48,7 +39,7 @@
         none
       [% END %]
     </td>
-    <td align="right">
+    <td class="right">
       [% IF keyword.bug_count > 0 %]
         <a href="buglist.cgi?keywords=[% keyword.name FILTER uri %]">
           [% keyword.bug_count %]</a>
@@ -57,13 +48,10 @@
       [% END %]
     </td>
   </tr>
-[% END %]
-
-[% IF keywords.size > 0 %]
-  </table>
-[% END %]
+  [% END %]
+</table>
 
-[% IF caneditkeywords %]
+[% IF user.in_group("editkeywords") %]
   <p>
     <a href="editkeywords.cgi">Edit keywords</a>.
   </p>
diff --git a/template/en/default/reports/old-charts.html.tmpl b/template/en/default/reports/old-charts.html.tmpl
index 29098c160..96e387b78 100644
--- a/template/en/default/reports/old-charts.html.tmpl
+++ b/template/en/default/reports/old-charts.html.tmpl
@@ -15,19 +15,20 @@
 [% PROCESS global/header.html.tmpl
   title = "$terms.Bug Charts"
   h1 = "Welcome to the $terms.Bugzilla Charting Kitchen"
+  style_urls = ['skins/standard/reports.css']
   doc_section = "reporting.html#charts"
 %]
 
-<div align="center">
-  [% IF url_image %]
+[% IF url_image %]
+  <div class="center">
     <img src="[% url_image FILTER html %]">
-    <br clear="both">
-  [% ELSE %]
+  </div>
+[% ELSE %]
     <form id="choose_product" method="get" action="reports.cgi">
-      <table border="1" cellpadding="5" cellspacing="2">
+      <table id="old_charts">
         <tr>
           <th>Product:</th>
-          <td align="center">
+          <td>
             <select id="product_id" name="product_id">
               [% FOREACH product = products %]
                 <option value="[% product.id FILTER html %]">[% product.name || '-All-' FILTER html %]</option>
@@ -37,7 +38,7 @@
         </tr>
         <tr>
           <th>Chart datasets:</th>
-          <td align="center">
+          <td>
             <select id="datasets" name="datasets" multiple="multiple" size="5">
               [%# We cannot use translated statuses and resolutions from field-descs.none.html
                 # because old charts do not distinguish statuses from resolutions. %]
@@ -56,7 +57,6 @@
         </tr>
       </table>
     </form>
-  [% END %]
-</div>
+[% END %]
 
 [% PROCESS global/footer.html.tmpl %]
diff --git a/template/en/default/reports/report-table.html.tmpl b/template/en/default/reports/report-table.html.tmpl
index 927a38917..abf770f29 100644
--- a/template/en/default/reports/report-table.html.tmpl
+++ b/template/en/default/reports/report-table.html.tmpl
@@ -141,7 +141,7 @@ YAHOO.util.Event.addListener(window, "load", function() {
   <tr>
     <td>
     </td>
-    <td align="center">
+    <td class="center">
       <strong>[% col_field_disp FILTER html %]</strong>
     </td>
   </tr>
@@ -158,7 +158,7 @@ YAHOO.util.Event.addListener(window, "load", function() {
 [% row_idx = 0 %]
 [% total_key = '-total-' %]
 <div id="tabular_report_container_[% tbl FILTER html %]">
-<table id="tabular_report" border="1">
+<table id="tabular_report">
   [% IF col_field %]
     <thead>
     <tr>
@@ -182,14 +182,14 @@ YAHOO.util.Event.addListener(window, "load", function() {
   [% FOREACH row = row_names %]
     [% row_idx = 1 - row_idx %]
     <tr>
-      <td class="[% classes.$row_idx.$col_idx %]" align="right">
+      <td class="[% classes.$row_idx.$col_idx %] right">
         [% PROCESS value_display value = row field = row_field %]
       </td>
       [% FOREACH col = col_names %]
         [% NEXT IF col == "" %]
         
         [% col_idx = 1 - col_idx %]
-        <td class="[% classes.$row_idx.$col_idx %]" align="center">
+        <td class="[% classes.$row_idx.$col_idx %]">
           [% IF data.$tbl.$col.$row AND data.$tbl.$col.$row > 0 %]
             <a href="[% urlbase %]&amp;
               [% row_field FILTER uri %]=[% row FILTER uri %]&amp;
@@ -200,7 +200,7 @@ YAHOO.util.Event.addListener(window, "load", function() {
           [% END %]
         </td>
       [% END %] 
-      <td class="ttotal" align="right">
+      <td class="ttotal right">
         <a href="[% urlbase %]&amp;
           [% row_field FILTER uri %]=[% row FILTER uri %]
           [% "&amp;$col_vals" IF col_vals %]">
@@ -216,14 +216,14 @@ YAHOO.util.Event.addListener(window, "load", function() {
       [% FOREACH col = col_names %]
         [% NEXT IF col == "" %]
 
-        <td class="ttotal" align="center">
+        <td class="ttotal">
           <a href="[% urlbase %]&amp;
             [% col_field FILTER uri %]=[% col FILTER uri %]
             [% "&amp;$row_vals" IF row_vals %]">
           [% data.$tbl.$col.$total_key OR 0 FILTER html %]</a>
         </td>
       [% END %]
-      <td class="ttotal" align="right">
+      <td class="ttotal right">
         <strong>
           <a href="[% urlbase %]
             [% "&amp;$row_vals" IF row_vals %]