Bug 920681: Remove the cellspacing and cellpadding attributes from tables

r/a=justdave

3 files changed, 23 insertions, 27 deletions

diff --git a/template/en/default/attachment/confirm-delete.html.tmpl b/template/en/default/attachment/confirm-delete.html.tmpl
index c03d58641..fe6135679 100644
--- a/template/en/default/attachment/confirm-delete.html.tmpl
+++ b/template/en/default/attachment/confirm-delete.html.tmpl
@@ -21,48 +21,44 @@
   doc_section = "attachments.html"
 %]
 
-<table border="1" cellpadding="4" cellspacing="0">
+<table id="admin_table">
   <tr class="column_header">
-    <th valign="top" class="left">Field</th>
-    <th valign="top" class="left">Value</th>
+    <th>Field</th>
+    <th>Value</th>
   </tr>
   <tr>
-    <td valign="top">Attachment ID:</td>
-    <td valign="top">
+    <td>Attachment ID</td>
+    <td>
       <a href="attachment.cgi?id=[% a.id FILTER html %]">[% a.id FILTER html %]</a>
     </td>
   </tr>
   <tr>
-    <td valign="top">File name:</td>
-    <td valign="top">[% a.filename FILTER html %]</td>
+    <td>File name</td>
+    <td>[% a.filename FILTER html %]</td>
   </tr>
   <tr>
-    <td valign="top">Description:</td>
-    <td valign="top">[% a.description FILTER html %]</td>
+    <td>Description</td>
+    <td>[% a.description FILTER html %]</td>
   </tr>
   <tr>
-    <td valign="top">Contained in [% terms.Bug %]:</td>
-    <td valign="top">[% a.bug_id FILTER bug_link(a.bug_id) FILTER none %]</td>
+    <td>Contained in [% terms.Bug %]</td>
+    <td>[% a.bug_id FILTER bug_link(a.bug_id) FILTER none %]</td>
   </tr>
   <tr>
-    <td valign="top">Creator:</td>
-    <td valign="top">[% a.attacher.identity FILTER html %]</td>
+    <td>Creator</td>
+    <td>[% a.attacher.identity FILTER html %]</td>
   </tr>
   <tr>
-    <td valign="top">Creation Date:</td>
-    <td valign="top">[% a.attached FILTER time %]</td>
+    <td>Creation Date</td>
+    <td>[% a.attached FILTER time %]</td>
   </tr>
 </table>
 
 <h2>Confirmation</h2>
 
-<table class="confirmation">
-  <tr>
-    <td>
-      The content of this attachment will be deleted in an <b>irreversible</b> way.
-    </td>
-  </tr>
-</table>
+<p class="confirmation">
+  The content of this attachment will be deleted in an <b>irreversible</b> way.
+</p>
 
 <p>Do you really want to delete this attachment?</p>
 
diff --git a/template/en/default/attachment/diff-file.html.tmpl b/template/en/default/attachment/diff-file.html.tmpl
index 1af6b3140..cf2aadde6 100644
--- a/template/en/default/attachment/diff-file.html.tmpl
+++ b/template/en/default/attachment/diff-file.html.tmpl
@@ -44,7 +44,7 @@ incremental_restore()
 [% FOREACH section = sections %]
   [% section_num = section_num + 1 %]
   <tr><th colspan="4" class="section_head">
-    <table id="[% file.filename FILTER html %]_sec[% section_num %]" cellpadding="0" cellspacing="0">
+    <table id="[% file.filename FILTER html %]_sec[% section_num %]">
     <tr><th width="95%" class="left">
   [% IF file.is_add %]
     Added
diff --git a/template/en/default/attachment/list.html.tmpl b/template/en/default/attachment/list.html.tmpl
index 48921e3ca..4599f38ed 100644
--- a/template/en/default/attachment/list.html.tmpl
+++ b/template/en/default/attachment/list.html.tmpl
@@ -42,7 +42,7 @@ function toggle_display(link) {
 </script>
 
 <br>
-<table id="attachment_table" cellspacing="0" cellpadding="4">
+<table id="attachment_table">
   <tr id="a0">
     <th colspan="[% show_attachment_flags ? 3 : 2 %]" class="left">
       Attachments
@@ -65,7 +65,7 @@ function toggle_display(link) {
                  [% " bz_private" IF attachment.isprivate %]
                  [% " bz_tr_obsolete bz_default_hidden" 
                      IF attachment.isobsolete %]">
-        <td valign="top">
+        <td>
           [% IF attachment.datasize %]
             <a href="attachment.cgi?id=[% attachment.id %]"
                title="View the content of the attachment">
@@ -102,7 +102,7 @@ function toggle_display(link) {
         </td>
 
         [% IF show_attachment_flags %]
-          <td class="bz_attach_flags" valign="top">
+          <td class="bz_attach_flags">
             [% IF attachment.flags.size == 0 %]
               <i>no flags</i>
             [% ELSE %]
@@ -129,7 +129,7 @@ function toggle_display(link) {
           </td>
         [% END %]
 
-        <td valign="top">
+        <td>
           <a href="attachment.cgi?id=[% attachment.id %]&amp;action=edit">Details</a>
           [% IF attachment.ispatch && feature_enabled('patch_viewer') %]
             | <a href="attachment.cgi?id=[% attachment.id %]&amp;action=diff">Diff</a>