Bug 840407: Remove the "align" and "valign" attributes

r/a=justdave

15 files changed, 62 insertions, 88 deletions

diff --git a/template/en/default/admin/components/list.html.tmpl b/template/en/default/admin/components/list.html.tmpl
index 949f56b1e..91808fbae 100644
--- a/template/en/default/admin/components/list.html.tmpl
+++ b/template/en/default/admin/components/list.html.tmpl
@@ -69,7 +69,7 @@
   [% columns.push({
        name => 'bug_count'
        heading => "$terms.Bugs"
-       align => "right"
+       class => "right"
        contentlink => bug_count_contentlink
      }) %]
 
diff --git a/template/en/default/admin/components/select-product.html.tmpl b/template/en/default/admin/components/select-product.html.tmpl
index 3651ec570..a152415c3 100644
--- a/template/en/default/admin/components/select-product.html.tmpl
+++ b/template/en/default/admin/components/select-product.html.tmpl
@@ -35,7 +35,7 @@
   [% columns.push({
       name => 'bug_count'
       heading => "$terms.Bugs"
-      align => "right"
+      class => "right"
       contentlink => "buglist.cgi?product=%%name%%"
     })
   %]
diff --git a/template/en/default/admin/flag-type/confirm-delete.html.tmpl b/template/en/default/admin/flag-type/confirm-delete.html.tmpl
index 70f5efb3d..74ceb2201 100644
--- a/template/en/default/admin/flag-type/confirm-delete.html.tmpl
+++ b/template/en/default/admin/flag-type/confirm-delete.html.tmpl
@@ -10,6 +10,7 @@
 
 [% PROCESS global/header.html.tmpl
   title = title
+  style_urls = ['skins/standard/admin.css']
   doc_section = "flags-overview.html#flags-delete"
 %]
 
@@ -26,24 +27,14 @@
    in the database but will not appear in the [% terms.Bugzilla %] UI.
 </p>
 
-<table>
-   <tr>
-      <td colspan="2">
-         Do you really want to delete this type?
-      </td>
-   </tr>
-   <tr>
-      <td>
-         <a href="editflagtypes.cgi?action=delete&amp;id=[% flag_type.id %]&amp;token=
-                 [%- token FILTER html %]">Yes, delete
-         </a>
-      </td>
-      <td align="right">
-         <a href="editflagtypes.cgi">
-            No, don't delete
-         </a>
-      </td>
-   </tr>
-</table>
+<p class="confirmation">
+  Do you really want to delete this type?
+</p>
+
+<p>
+  <a href="editflagtypes.cgi?action=delete&amp;id=[% flag_type.id %]&amp;token=
+           [%- token FILTER html %]">Yes, delete</a> -
+  <a href="editflagtypes.cgi">No, don't delete</a>
+</p>
 
 [% PROCESS global/footer.html.tmpl %]
diff --git a/template/en/default/admin/keywords/list.html.tmpl b/template/en/default/admin/keywords/list.html.tmpl
index d3391d939..c3f4a5292 100644
--- a/template/en/default/admin/keywords/list.html.tmpl
+++ b/template/en/default/admin/keywords/list.html.tmpl
@@ -33,7 +33,7 @@
      { 
        name => "bug_count"
        heading => "$terms.Bugs"
-       align => "right"
+       class => "right"
        contentlink => "buglist.cgi?keywords=%%name%%"
      },
      { 
diff --git a/template/en/default/admin/milestones/list.html.tmpl b/template/en/default/admin/milestones/list.html.tmpl
index 20e4f6138..aa377d88e 100644
--- a/template/en/default/admin/milestones/list.html.tmpl
+++ b/template/en/default/admin/milestones/list.html.tmpl
@@ -53,7 +53,7 @@
   [% columns.push({
        name => "bug_count"
        heading => "$terms.Bugs"
-       align => "right"
+       class => "right"
        contentlink => bug_count_contentlink
      })
   %]
diff --git a/template/en/default/admin/milestones/select-product.html.tmpl b/template/en/default/admin/milestones/select-product.html.tmpl
index ccc7e193b..e2784127e 100644
--- a/template/en/default/admin/milestones/select-product.html.tmpl
+++ b/template/en/default/admin/milestones/select-product.html.tmpl
@@ -35,7 +35,7 @@
   [% columns.push({
       name => 'bug_count'
       heading => "$terms.Bugs"
-      align => "right"
+      class => "right"
       contentlink => "buglist.cgi?product=%%name%%"
     })
   %]
diff --git a/template/en/default/admin/params/editparams.html.tmpl b/template/en/default/admin/params/editparams.html.tmpl
index 50a0a2ea5..00fb27ba4 100644
--- a/template/en/default/admin/params/editparams.html.tmpl
+++ b/template/en/default/admin/params/editparams.html.tmpl
@@ -68,19 +68,17 @@
   </div>
 
   <div class="cell">
-      [% IF curpanel == -1 %]
-        [% PROCESS admin/params/index.html.tmpl panels = panels %]
-      [% ELSE %]
-
-        <div class="contribute"><strong>Note:</strong>
-          B[% %]ugzilla is developed entirely by volunteers.
-          The best way to give back to the B[% %]ugzilla project is to
-          <a href="http://www.bugzilla.org/contribute/">contribute</a>
-          yourself!
-          You don't have to be a programmer to contribute, there are lots of
-          things that we need.
-        </div>
+    <div class="contribute"><strong>Note:</strong>
+      B[% %]ugzilla is developed entirely by volunteers.
+      The best way to give back to the B[% %]ugzilla project is to
+      <a href="http://www.bugzilla.org/contribute/">contribute</a> yourself!
+      You don't have to be a programmer to contribute, there are lots of
+      things that we need.
+    </div>
 
+    [% IF curpanel == -1 %]
+      [% PROCESS admin/params/index.html.tmpl panels = panels %]
+    [% ELSE %]
         <p>
           This lets you edit the basic operating parameters of [% terms.Bugzilla %].
           Be careful!<br>
@@ -95,7 +93,7 @@
           <input type="hidden" name="token" value="[% token FILTER html %]">
           <input type="submit" id="save-params" value="Save Changes">
         </form>
-      [% END %]
+    [% END %]
   </div>
 </div>
 
diff --git a/template/en/default/admin/params/index.html.tmpl b/template/en/default/admin/params/index.html.tmpl
index 65aa398eb..ee64eca9f 100644
--- a/template/en/default/admin/params/index.html.tmpl
+++ b/template/en/default/admin/params/index.html.tmpl
@@ -6,33 +6,23 @@
   # defined by the Mozilla Public License, v. 2.0.
   #%]
 
-<p>
-  All parameters are displayed below, per section.
-  If you cannot find one from here, then the parameter does not exist.
-</p>
+<div id="params_index">
+  <p>
+    All parameters are displayed below, per section.
+    If you cannot find one from here, then the parameter does not exist.
+  </p>
 
-<div align="center">
-  <table>
-    <tr>
-      <th>Parameter</th>
-      <th>Section</th>
-    </tr>
-    [% FOREACH panel = panels %]
+  [% FOREACH panel = panels %]
+    <h3>[% panel.title FILTER html %]</h3>
+
+    <ul>
       [% FOREACH param = panel.param_list.sort('name') %]
-        <tr>
-          <td>
-            <a href="editparams.cgi?section=
-              [%- panel.name FILTER uri %]#[% param.name FILTER uri %]_desc">
-              [% param.name FILTER html %]</a>
-          </td>    
-          <td>
-            [% panel.title FILTER html %]
-          </td>
-        </tr>
+        <li>
+          <a href="editparams.cgi?section=
+                   [%- panel.name FILTER uri %]#[% param.name FILTER uri %]_desc">
+            [% param.name FILTER html %]</a>
+        </li>
       [% END %]
-      <tr>
-        <td>&nbsp;</td><td>&nbsp;</td>
-      </tr>
-    [% END %]
-  </table>
+    </ul>
+  [% END %]
 </div>
diff --git a/template/en/default/admin/products/list-classifications.html.tmpl b/template/en/default/admin/products/list-classifications.html.tmpl
index a13d2be0f..39f3ee1c1 100644
--- a/template/en/default/admin/products/list-classifications.html.tmpl
+++ b/template/en/default/admin/products/list-classifications.html.tmpl
@@ -32,7 +32,7 @@
      },
      { 
        name => "product_count"
-       align => "right"
+       class => "right"
        heading => "Product Count"
      }
    ]
diff --git a/template/en/default/admin/products/list.html.tmpl b/template/en/default/admin/products/list.html.tmpl
index d09a552e2..58edaa7bd 100644
--- a/template/en/default/admin/products/list.html.tmpl
+++ b/template/en/default/admin/products/list.html.tmpl
@@ -58,7 +58,7 @@
   [% columns.push({
        name => "bug_count"
        heading => "$terms.Bug Count"
-       align => 'right'
+       class => 'right'
        contentlink => 'buglist.cgi?product=%%name%%'
      })
   %]
diff --git a/template/en/default/admin/table.html.tmpl b/template/en/default/admin/table.html.tmpl
index 3981ef4bb..993181c7f 100644
--- a/template/en/default/admin/table.html.tmpl
+++ b/template/en/default/admin/table.html.tmpl
@@ -25,8 +25,6 @@
   #                        field_descs hash will be used instead of "content."
   #                        See fieldvalues/select-field for an example of use.
   #                        This content WILL be HTML-filtered in this case.
-  #     align: left/center/right. Controls the horizontal alignment of the
-  #            text in the column.
   #     allow_html_content: if defined, then this column allows some html content
   #                         and so it will be only partially filtered.
   #     yesno_field: Turn the data from 0/!0 into Yes/No
@@ -89,7 +87,6 @@
       [% contentlink = c.contentlink
          content = c.content
          content_use_field = c.content_use_field
-         align = c.align
          class = c.class
          allow_html_content = c.allow_html_content
          yesno_field = c.yesno_field
@@ -121,8 +118,7 @@
           [% END %]
       [% END %]
 
-      <td [% IF align %] align="[% align FILTER html %]" [% END %]
-          [% IF class %] class="[% class FILTER html %]" [% END %]>
+      <td [% IF class %] class="[% class FILTER html %]"[% END %]>
 
         [% IF contentlink %]
           [% FOREACH m = contentlink.match('%%(.+?)%%', 1) %]
@@ -155,7 +151,7 @@
 [% END %]
 
 [% IF data.size == 0 %]
-  <tr><td colspan="[% columns.size %]" align="center"><i>&lt;none&gt;</i></td></tr>
+  <tr><td colspan="[% columns.size %]" class="center"><i>&lt;none&gt;</i></td></tr>
 [% END %]
 
 
diff --git a/template/en/default/admin/versions/list.html.tmpl b/template/en/default/admin/versions/list.html.tmpl
index ee69ee03e..43a14f9ee 100644
--- a/template/en/default/admin/versions/list.html.tmpl
+++ b/template/en/default/admin/versions/list.html.tmpl
@@ -45,7 +45,7 @@
   [% columns.push({
        name => "bug_count"
        heading => "$terms.Bugs"
-       align => "right"
+       class => "right"
        contentlink => bug_count_contentlink
      })
   %]
diff --git a/template/en/default/admin/versions/select-product.html.tmpl b/template/en/default/admin/versions/select-product.html.tmpl
index e19aa18cc..119ec9a71 100644
--- a/template/en/default/admin/versions/select-product.html.tmpl
+++ b/template/en/default/admin/versions/select-product.html.tmpl
@@ -35,7 +35,7 @@
   [% columns.push({
       name => 'bug_count'
       heading => "$terms.Bugs"
-      align => "right"
+      class => "right"
       contentlink => "buglist.cgi?product=%%name%%"
     })
   %]
diff --git a/template/en/default/admin/workflow/comment.html.tmpl b/template/en/default/admin/workflow/comment.html.tmpl
index 94218c8fa..19762d154 100644
--- a/template/en/default/admin/workflow/comment.html.tmpl
+++ b/template/en/default/admin/workflow/comment.html.tmpl
@@ -15,9 +15,9 @@
 <!--
   function toggle_cell(cell) {
     if (cell.checked)
-      cell.parentNode.className = "checkbox-cell checked";
+      cell.parentNode.className = "checked";
     else
-      cell.parentNode.className = "checkbox-cell";
+      cell.parentNode.className = "";
   }
 //-->
 </script>
@@ -28,7 +28,7 @@
 </p>
 
 <form id="workflow_form" method="POST" action="editworkflow.cgi">
-<table>
+<table id="workflow">
   <tr>
     <th colspan="2">&nbsp;</th>
     <th colspan="[% statuses.size FILTER html %]" class="title">To</th>
@@ -38,7 +38,7 @@
     <th rowspan="[% statuses.size + 2 FILTER html %]" class="title">From</th>
     <th>&nbsp;</th>
     [% FOREACH status = statuses %]
-      <th class="col-header[% status.is_open ? " open-status" : " closed-status" %]">
+      <th class="[% status.is_open ? "open-status" : "closed-status" %] center">
         [% display_value("bug_status", status.name) FILTER html %]
       </th>
     [% END %]
@@ -54,22 +54,21 @@
 
       [% FOREACH new_status = statuses %]
         [% IF workflow.${status.id}.${new_status.id}.defined %]
-          <td align="center" class="checkbox-cell
-              [% " checked" IF workflow.${status.id}.${new_status.id} %]"
+          <td class="[% "checked" IF workflow.${status.id}.${new_status.id} %]"
               title="From [% status.name FILTER html %] to [% new_status.name FILTER html %]">
             <input type="checkbox" name="c_[% status.id %]_[% new_status.id %]"
                    id="c_[% status.id %]_[% new_status.id %]" onclick="toggle_cell(this)"
               [% " checked='checked'" IF workflow.${status.id}.${new_status.id} %]>
           </td>
         [% ELSE %]
-          <td class="checkbox-cell forbidden">&nbsp;</td>
+          <td class="forbidden">&nbsp;</td>
         [% END %]
       [% END %]
     </tr>
   [% END %]
 </table>
 
-<p align="center">
+<p class="center">
   <input type="hidden" name="action" value="update_comment">
   <input type="hidden" name="token" value="[% token FILTER html %]">
   <input type="submit" id="update_comment" value="Commit Changes"> -
diff --git a/template/en/default/admin/workflow/edit.html.tmpl b/template/en/default/admin/workflow/edit.html.tmpl
index 4ae613ef5..1904b487e 100644
--- a/template/en/default/admin/workflow/edit.html.tmpl
+++ b/template/en/default/admin/workflow/edit.html.tmpl
@@ -15,9 +15,9 @@
 <!--
   function toggle_cell(cell) {
     if (cell.checked)
-      cell.parentNode.className = "checkbox-cell checked";
+      cell.parentNode.className = "checked";
     else
-      cell.parentNode.className = "checkbox-cell";
+      cell.parentNode.className = "";
   }
 //-->
 </script>
@@ -33,7 +33,7 @@
 </p>
 
 <form id="workflow_form" method="POST" action="editworkflow.cgi">
-<table>
+<table id="workflow">
   <tr>
     <th colspan="2">&nbsp;</th>
     <th colspan="[% statuses.size FILTER html %]" class="title">To</th>
@@ -43,7 +43,7 @@
     <th rowspan="[% statuses.size + 2 FILTER html %]" class="title">From</th>
     <th>&nbsp;</th>
     [% FOREACH status = statuses %]
-      <th class="col-header[% status.is_open ? " open-status" : " closed-status" %]">
+      <th class="[% status.is_open ? "open-status" : "closed-status" %] center">
         [% display_value("bug_status", status.name) FILTER html %]
       </th>
     [% END %]
@@ -61,7 +61,7 @@
         [% IF status.id != new_status.id %]
           [% checked = workflow.${status.id}.${new_status.id}.defined ? 1 : 0 %]
           [% mandatory = (status.id && new_status.name == Param("duplicate_or_move_bug_status")) ? 1 : 0 %]
-          <td align="center" class="checkbox-cell[% " checked" IF checked || mandatory %]"
+          <td class="[% "checked" IF checked || mandatory %]"
               title="From [% status.name FILTER html %] to [% new_status.name FILTER html %]">
             <input type="checkbox" name="w_[% status.id %]_[% new_status.id %]"
                    id="w_[% status.id %]_[% new_status.id %]" onclick="toggle_cell(this)"
@@ -69,7 +69,7 @@
                    [%+ "disabled='disabled'" IF mandatory %]>
           </td>
         [% ELSE %]
-          <td class="checkbox-cell forbidden">&nbsp;</td>
+          <td class="forbidden">&nbsp;</td>
         [% END %]
       [% END %]
     </tr>
@@ -87,7 +87,7 @@
   page and editing the <i>duplicate_or_move_bug_status</i> parameter.
 </p>
 
-<p align="center">
+<p class="center">
   <input type="hidden" name="action" value="update">
   <input type="hidden" name="token" value="[% token FILTER html %]">
   <input type="submit" id="update_workflow" value="Commit Changes"> -