diff options
| author | terry%netscape.com <> | 1998-11-21 03:18:33 +0000 |
|---|---|---|
| committer | terry%netscape.com <> | 1998-11-21 03:18:33 +0000 |
| commit | 89eccc9b74482b8c636a02d3a6bcf3ec2947eb7b (patch) | |
| tree | 235232c5fcc2e5d1fb13ad91e8b44da262c2a3f3 /reports.cgi | |
| parent | 3789246e0d115ebd9b0f280c8fa209a690e425fe (diff) | |
| download | bugs-89eccc9b74482b8c636a02d3a6bcf3ec2947eb7b.tar bugs-89eccc9b74482b8c636a02d3a6bcf3ec2947eb7b.tar.gz bugs-89eccc9b74482b8c636a02d3a6bcf3ec2947eb7b.tar.bz2 bugs-89eccc9b74482b8c636a02d3a6bcf3ec2947eb7b.tar.xz bugs-89eccc9b74482b8c636a02d3a6bcf3ec2947eb7b.zip | |
Backed out Andrew's patch -- turns out it was doing quoting sublty wrong.
Diffstat (limited to 'reports.cgi')
| -rwxr-xr-x | reports.cgi | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/reports.cgi b/reports.cgi index 12ff00c7f..7456c054e 100755 --- a/reports.cgi +++ b/reports.cgi @@ -156,12 +156,11 @@ FIN sub most_doomed { my $when = localtime (time); - my $product = url_decode($::FORM{'product'}); print <<FIN; <center> <h1> -Bug Report for $product +Bug Report for $::FORM{'product'} </h1> $when<p> FIN @@ -180,7 +179,7 @@ from bugs, versions projector where bugs.assigned_to = assign.userid and bugs.reporter = report.userid -and bugs.product='$product' +and bugs.product='$::FORM{'product'}' and ( bugs.bug_status = 'NEW' or @@ -394,13 +393,13 @@ sub header FIN } -sub show_chart { - my $when = localtime (time); - my $product = url_decode($::FORM{'product'}); +sub show_chart + { + my $when = localtime (time); - if (! is_legal_product($product)) + if (! is_legal_product ($::FORM{'product'})) { - &die_politely ("Unknown product: $product"); + &die_politely ("Unknown product: $::FORM{'product'}"); } print <<FIN; @@ -455,7 +454,7 @@ FIN my %settings = ( - "title" => "Bug Charts for $product", + "title" => "Bug Charts for $::FORM{'product'}", "x_label" => "Dates", "y_label" => "Bug Count", "legend_labels" => \@labels, @@ -477,7 +476,6 @@ FIN sub die_politely { my $msg = shift; - my $product = url_decode($::FORM{'product'}); print <<FIN; <p> @@ -486,7 +484,7 @@ sub die_politely <td align=center> <font color=blue>Sorry, but ...</font> <p> -There is no graph available for <b>$product</b><p> +There is no graph available for <b>$::FORM{'product'}</b><p> <font size=-1> $msg |