diff options
| author | Gervase Markham <gerv@mozilla.org> | 2015-01-21 20:06:08 +0000 |
|---|---|---|
| committer | David Lawrence <dkl@mozilla.com> | 2015-01-21 20:06:08 +0000 |
| commit | 19117cc3e4da268d64107957e4c206d8df875505 (patch) | |
| tree | 81546dbda0b66c7463407c3854ee98689326dc15 /reports.cgi | |
| parent | 272b0b69b2884d937ffd4b5b01fb89235603c67c (diff) | |
| download | bugs-19117cc3e4da268d64107957e4c206d8df875505.tar bugs-19117cc3e4da268d64107957e4c206d8df875505.tar.gz bugs-19117cc3e4da268d64107957e4c206d8df875505.tar.bz2 bugs-19117cc3e4da268d64107957e4c206d8df875505.tar.xz bugs-19117cc3e4da268d64107957e4c206d8df875505.zip | |
Bug 1079065: [SECURITY] Always use the 3 arguments form for open() to prevent shell code injection
r=dkl,a=glob
Diffstat (limited to 'reports.cgi')
| -rwxr-xr-x | reports.cgi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/reports.cgi b/reports.cgi index cdc9d4a87..89dee1c9a 100755 --- a/reports.cgi +++ b/reports.cgi @@ -138,7 +138,7 @@ sub generate_chart { my ($dir, $image_file, $product, $datasets) = @_; my $data_file = $dir . '/' . $product->id; - if (! open FILE, $data_file) { + if (!open(FILE, '<', $data_file)) { ThrowCodeError('chart_data_not_generated', {'product' => $product}); } |