Bug 314547: [PostgreSQL] cannot check/uncheck the "Private" checkbox for comments in show_bug.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave

1 files changed, 6 insertions, 4 deletions

diff --git a/process_bug.cgi b/process_bug.cgi
index fdf5a405b..af0283d6c 100755
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -936,16 +936,18 @@ if (defined $cgi->param('id')) {
 if (defined $cgi->param('id') &&
     (Param("insidergroup") && UserInGroup(Param("insidergroup")))) {
 
+    my $sth = $dbh->prepare('UPDATE longdescs SET isprivate = ?
+                             WHERE bug_id = ? AND bug_when = ?');
+
     foreach my $field ($cgi->param()) {
         if ($field =~ /when-([0-9]+)/) {
             my $sequence = $1;
             my $private = $cgi->param("isprivate-$sequence") ? 1 : 0 ;
             if ($private != $cgi->param("oisprivate-$sequence")) {
                 my $field_data = $cgi->param("$field");
-                detaint_natural($field_data);
-                SendSQL("UPDATE longdescs SET isprivate = $private " .
-                        "WHERE bug_id = " . $cgi->param('id') . 
-                        " AND bug_when = $field_data");
+                # Make sure a valid date is given.
+                $field_data = format_time($field_data, '%Y-%m-%d %T');
+                $sth->execute($private, $cgi->param('id'), $field_data);
             }
         }