aboutsummaryrefslogtreecommitdiffstats
path: root/process_bug.cgi
diff options
context:
space:
mode:
authorlpsolit%gmail.com <>2006-06-20 03:15:17 +0000
committerlpsolit%gmail.com <>2006-06-20 03:15:17 +0000
commit2545c0950c4f0fde8f78b265217fa9f523eff7bf (patch)
tree5bb305644ad11da196c7613b82743e426e2fd337 /process_bug.cgi
parentb687ddef9b6dfeec3d87b7ae211decbf21b6e9a9 (diff)
downloadbugs-2545c0950c4f0fde8f78b265217fa9f523eff7bf.tar
bugs-2545c0950c4f0fde8f78b265217fa9f523eff7bf.tar.gz
bugs-2545c0950c4f0fde8f78b265217fa9f523eff7bf.tar.bz2
bugs-2545c0950c4f0fde8f78b265217fa9f523eff7bf.tar.xz
bugs-2545c0950c4f0fde8f78b265217fa9f523eff7bf.zip
Bug 304601: Bugzilla::Config's :locations exports need to be in their own module - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat for the main patch, r=myk for the patch about CGI.pm a=justdave
Bug 328637: Remove all legal_* versioncache arrays - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave Bug 110503 - Eliminate versioncache
Diffstat (limited to 'process_bug.cgi')
-rwxr-xr-xprocess_bug.cgi21
1 files changed, 5 insertions, 16 deletions
diff --git a/process_bug.cgi b/process_bug.cgi
index ca72015a2..88377c78e 100755
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -64,15 +64,6 @@ use Bugzilla::Keyword;
use Bugzilla::Flag;
use Bugzilla::FlagType;
-# Shut up misguided -w warnings about "used only once":
-
-use vars qw(%legal_opsys
- %legal_platform
- %legal_priority
- %settable_resolution
- %legal_severity
- );
-
my $user = Bugzilla->login(LOGIN_REQUIRED);
my $whoid = $user->id;
my $grouplist = $user->groups_as_string;
@@ -266,8 +257,6 @@ if ($cgi->cookie("BUGLIST") && defined $cgi->param('id')) {
$vars->{'bug_list'} = \@bug_list;
}
-GetVersionTable();
-
foreach my $field_name ('product', 'component', 'version') {
defined($cgi->param($field_name))
|| ThrowCodeError('undefined_field', { field => $field_name });
@@ -639,10 +628,10 @@ if (defined $cgi->param('id')) {
check_field('target_milestone', scalar $cgi->param('target_milestone'),
[map($_->name, @{$prod_obj->milestones})]);
}
- check_field('rep_platform', scalar $cgi->param('rep_platform'), \@::legal_platform);
- check_field('op_sys', scalar $cgi->param('op_sys'), \@::legal_opsys);
- check_field('priority', scalar $cgi->param('priority'), \@::legal_priority);
- check_field('bug_severity', scalar $cgi->param('bug_severity'), \@::legal_severity);
+ check_field('rep_platform', scalar $cgi->param('rep_platform'));
+ check_field('op_sys', scalar $cgi->param('op_sys'));
+ check_field('priority', scalar $cgi->param('priority'));
+ check_field('bug_severity', scalar $cgi->param('bug_severity'));
# Those fields only have to exist. We don't validate their value here.
foreach my $field_name ('bug_file_loc', 'short_desc', 'longdesclength') {
@@ -1173,7 +1162,7 @@ SWITCH: for ($cgi->param('knob')) {
/^(resolve|change_resolution)$/ && CheckonComment( "resolve" ) && do {
# Check here, because its the only place we require the resolution
check_field('resolution', scalar $cgi->param('resolution'),
- \@::settable_resolution);
+ Bugzilla::Bug->settable_resolutions);
# don't resolve as fixed while still unresolved blocking bugs
if (Param("noresolveonopenblockers")