diff options
| author | bugreport%peshkin.net <> | 2004-07-27 22:13:48 +0000 |
|---|---|---|
| committer | bugreport%peshkin.net <> | 2004-07-27 22:13:48 +0000 |
| commit | fba06c0a5f82ddf2f73ef068752d697666464dc1 (patch) | |
| tree | 1e3e2655bdc0553fac9fe7e9ee4b607873f69f3f /editmilestones.cgi | |
| parent | 667a7abdb6d998df719317e101eb08860f1b78d1 (diff) | |
| download | bugs-fba06c0a5f82ddf2f73ef068752d697666464dc1.tar bugs-fba06c0a5f82ddf2f73ef068752d697666464dc1.tar.gz bugs-fba06c0a5f82ddf2f73ef068752d697666464dc1.tar.bz2 bugs-fba06c0a5f82ddf2f73ef068752d697666464dc1.tar.xz bugs-fba06c0a5f82ddf2f73ef068752d697666464dc1.zip | |
Bug 252450: Unlock tables in edit*.cgi before sending trailer
r=kiko
a=justdave
Diffstat (limited to 'editmilestones.cgi')
| -rwxr-xr-x | editmilestones.cgi | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/editmilestones.cgi b/editmilestones.cgi index e9ec0ed92..aaec24455 100755 --- a/editmilestones.cgi +++ b/editmilestones.cgi @@ -115,6 +115,7 @@ sub EmitFormElements ($$$) sub PutTrailer (@) { my (@links) = ("Back to the <A HREF=\"query.cgi\">query page</A>", @_); + SendSQL("UNLOCK TABLES"); my $count = $#links; my $num = 0; @@ -453,7 +454,6 @@ if ($action eq 'delete') { WHERE product_id=$product_id AND value=" . SqlQuote($milestone)); print "Milestone deleted.<P>\n"; - SendSQL("UNLOCK TABLES"); unlink "$datadir/versioncache"; PutTrailer($localtrailer); @@ -535,13 +535,11 @@ if ($action eq 'update') { unless ($milestone) { print "Sorry, I can't delete the milestone text."; PutTrailer($localtrailer); - SendSQL("UNLOCK TABLES"); exit; } if (TestMilestone($product,$milestone)) { print "Sorry, milestone '$milestone' is already in use."; PutTrailer($localtrailer); - SendSQL("UNLOCK TABLES"); exit; } SendSQL("UPDATE bugs @@ -560,7 +558,6 @@ if ($action eq 'update') { unlink "$datadir/versioncache"; print "Updated milestone.<BR>\n"; } - SendSQL("UNLOCK TABLES"); PutTrailer($localtrailer); exit; |