Bug 173629: Clean up "my" variable scoping issues for mod_perl

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk

1 files changed, 7 insertions, 3 deletions

diff --git a/attachment.cgi b/attachment.cgi
index fcbd10020..94f4fbe5c 100755
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -52,9 +52,13 @@ use Bugzilla::Token;
 
 Bugzilla->login();
 
-my $cgi = Bugzilla->cgi;
-my $template = Bugzilla->template;
-my $vars = {};
+# For most scripts we don't make $cgi and $template global variables. But
+# when preparing Bugzilla for mod_perl, this script used these
+# variables in so many subroutines that it was easier to just
+# make them globals.
+local our $cgi = Bugzilla->cgi;
+local our $template = Bugzilla->template;
+local our $vars = {};
 
 ################################################################################
 # Main Body Execution