diff options
| author | Byron Jones <glob@mozilla.com> | 2014-08-12 14:05:32 +0800 |
|---|---|---|
| committer | Byron Jones <glob@mozilla.com> | 2014-08-12 14:05:32 +0800 |
| commit | c19dc4ffe98074bedb780652af581a1f0edb3b2d (patch) | |
| tree | 8565697b853e6d9cc84e9e3536b3fcb90d46bb6c /Bugzilla/User | |
| parent | 8b98912309870c03c4b82396647682a8d9f247b4 (diff) | |
| download | bugs-c19dc4ffe98074bedb780652af581a1f0edb3b2d.tar bugs-c19dc4ffe98074bedb780652af581a1f0edb3b2d.tar.gz bugs-c19dc4ffe98074bedb780652af581a1f0edb3b2d.tar.bz2 bugs-c19dc4ffe98074bedb780652af581a1f0edb3b2d.tar.xz bugs-c19dc4ffe98074bedb780652af581a1f0edb3b2d.zip | |
Bug 993926: Bugzilla::User::Setting::get_all_settings() should use memcached
r=sgreen,a=glob
Diffstat (limited to 'Bugzilla/User')
| -rw-r--r-- | Bugzilla/User/Setting.pm | 41 |
1 files changed, 31 insertions, 10 deletions
diff --git a/Bugzilla/User/Setting.pm b/Bugzilla/User/Setting.pm index 451e946f7..5b518da65 100644 --- a/Bugzilla/User/Setting.pm +++ b/Bugzilla/User/Setting.pm @@ -15,8 +15,12 @@ use parent qw(Exporter); # Module stuff -@Bugzilla::User::Setting::EXPORT = qw(get_all_settings get_defaults - add_setting); +@Bugzilla::User::Setting::EXPORT = qw( + get_all_settings + get_defaults + add_setting + clear_settings_cache +); use Bugzilla::Error; use Bugzilla::Util qw(trick_taint get_text); @@ -159,15 +163,20 @@ sub get_all_settings { my $settings = {}; my $dbh = Bugzilla->dbh; - my $rows = $dbh->selectall_arrayref( - q{SELECT name, default_value, is_enabled, setting_value, subclass - FROM setting - LEFT JOIN profile_setting - ON setting.name = profile_setting.setting_name - AND profile_setting.user_id = ?}, undef, ($user_id)); + my $cache_key = "user_settings.$user_id"; + my $rows = Bugzilla->memcached->get_config({ key => $cache_key }); + if (!$rows) { + $rows = $dbh->selectall_arrayref( + q{SELECT name, default_value, is_enabled, setting_value, subclass + FROM setting + LEFT JOIN profile_setting + ON setting.name = profile_setting.setting_name + AND profile_setting.user_id = ?}, undef, ($user_id)); + Bugzilla->memcached->set_config({ key => $cache_key, data => $rows }); + } foreach my $row (@$rows) { - my ($name, $default_value, $is_enabled, $value, $subclass) = @$row; + my ($name, $default_value, $is_enabled, $value, $subclass) = @$row; my $is_default; @@ -179,13 +188,18 @@ sub get_all_settings { } $settings->{$name} = new Bugzilla::User::Setting( - $name, $user_id, $is_enabled, + $name, $user_id, $is_enabled, $default_value, $value, $is_default, $subclass); } return $settings; } +sub clear_settings_cache { + my ($user_id) = @_; + Bugzilla->memcached->clear_config({ key => "user_settings.$user_id" }); +} + sub get_defaults { my ($user_id) = @_; my $dbh = Bugzilla->dbh; @@ -368,6 +382,13 @@ Params: C<$setting_name> - string - the name of the setting C<$is_enabled> - boolean - if false, all users must use the global default Returns: nothing +=item C<clear_settings_cache($user_id)> + +Description: Clears cached settings data for the specified user. Must be + called after updating any user's setting. +Params: C<$user_id> - integer - the user id. +Returns: nothing + =begin private =item C<_setting_exists> |