diff options
author | lpsolit%gmail.com <> | 2009-01-28 23:27:27 +0000 |
---|---|---|
committer | lpsolit%gmail.com <> | 2009-01-28 23:27:27 +0000 |
commit | b5ae8cde2a4c1dc1fe6359690be9044ecb8b0b07 (patch) | |
tree | 369b73ff0c7c7d45f91a987fb447e562b04d179b | |
parent | 70f22ae49bfee300a79aece56ca72cb319b786a5 (diff) | |
download | bugs-b5ae8cde2a4c1dc1fe6359690be9044ecb8b0b07.tar bugs-b5ae8cde2a4c1dc1fe6359690be9044ecb8b0b07.tar.gz bugs-b5ae8cde2a4c1dc1fe6359690be9044ecb8b0b07.tar.bz2 bugs-b5ae8cde2a4c1dc1fe6359690be9044ecb8b0b07.tar.xz bugs-b5ae8cde2a4c1dc1fe6359690be9044ecb8b0b07.zip |
Bug 471523: Cloning a bug copies the newest visible comment for Newest to Oldest comment order - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
-rwxr-xr-x | enter_bug.cgi | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/enter_bug.cgi b/enter_bug.cgi index d463a7a11..ef0314bca 100755 --- a/enter_bug.cgi +++ b/enter_bug.cgi @@ -422,14 +422,17 @@ if ($cloned_bug_id) { # We need to ensure that we respect the 'insider' status of # the first comment, if it has one. Either way, make a note # that this bug was cloned from another bug. - - my $isprivate = $cloned_bug->longdescs->[0]->{'isprivate'}; + # We cannot use $cloned_bug->longdescs because this method + # depends on the "comment_sort_order" user pref, and we + # really want the first comment of the bug. + my $bug_desc = Bugzilla::Bug::GetComments($cloned_bug_id, 'oldest_to_newest'); + my $isprivate = $bug_desc->[0]->{'isprivate'}; $vars->{'comment'} = ""; $vars->{'commentprivacy'} = 0; - if ( !($isprivate) || Bugzilla->user->is_insider ) { - $vars->{'comment'} = $cloned_bug->longdescs->[0]->{'body'}; + if (!$isprivate || Bugzilla->user->is_insider) { + $vars->{'comment'} = $bug_desc->[0]->{'body'}; $vars->{'commentprivacy'} = $isprivate; } |