diff options
| author | mkanat%bugzilla.org <> | 2008-12-24 19:08:20 +0000 |
|---|---|---|
| committer | mkanat%bugzilla.org <> | 2008-12-24 19:08:20 +0000 |
| commit | 648127eb7ee4ab3623af6c4d9770ea84aae2aca2 (patch) | |
| tree | 52213d6b888389af9154cf1c7d2c8af8c1e44759 | |
| parent | 985149e60ebc4091934056b4fa41ea0c5c512cce (diff) | |
| download | bugs-648127eb7ee4ab3623af6c4d9770ea84aae2aca2.tar bugs-648127eb7ee4ab3623af6c4d9770ea84aae2aca2.tar.gz bugs-648127eb7ee4ab3623af6c4d9770ea84aae2aca2.tar.bz2 bugs-648127eb7ee4ab3623af6c4d9770ea84aae2aca2.tar.xz bugs-648127eb7ee4ab3623af6c4d9770ea84aae2aca2.zip | |
Bug 347707: Changing parameters could silently fail because we weren't correctly checking the return code from "rename"
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=justdave, a=mkanat
| -rw-r--r-- | Bugzilla/Config.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm index 3666861f0..14f10bed9 100644 --- a/Bugzilla/Config.pm +++ b/Bugzilla/Config.pm @@ -287,7 +287,7 @@ sub write_params { close $fh; rename $tmpname, $param_file - || die "Can't rename $tmpname to $param_file: $!"; + or die "Can't rename $tmpname to $param_file: $!"; ChmodDataFile($param_file, 0666); |