aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorByron Jones <glob@glob.com.au>2010-11-03 00:18:33 +0100
committerFrédéric Buclin <LpSolit@gmail.com>2010-11-03 00:18:33 +0100
commit3f3cc3c9ac50a9e43fc98dfd84c675ba22ada22b (patch)
treef9d640c64d83213421689adac4942606899e0a09
parentc793bb323f1c58c1fe3e82b09068e88c380f5c21 (diff)
downloadbugs-3f3cc3c9ac50a9e43fc98dfd84c675ba22ada22b.tar
bugs-3f3cc3c9ac50a9e43fc98dfd84c675ba22ada22b.tar.gz
bugs-3f3cc3c9ac50a9e43fc98dfd84c675ba22ada22b.tar.bz2
bugs-3f3cc3c9ac50a9e43fc98dfd84c675ba22ada22b.tar.xz
bugs-3f3cc3c9ac50a9e43fc98dfd84c675ba22ada22b.zip
Bug 600464: (CVE-2010-3172) [SECURITY] Content/Header injection due to non-random multipart/x-mixed-replace boundary
r=mkanat a=LpSolit
-rw-r--r--Bugzilla/CGI.pm3
1 files changed, 2 insertions, 1 deletions
diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm
index a9b938c6d..8ec3ac28e 100644
--- a/Bugzilla/CGI.pm
+++ b/Bugzilla/CGI.pm
@@ -213,7 +213,8 @@ sub multipart_init {
}
# Set the MIME boundary and content-type
- my $boundary = $param{'-boundary'} || '------- =_aaaaaaaaaa0';
+ my $boundary = $param{'-boundary'}
+ || '------- =_' . generate_random_password(16);
delete $param{'-boundary'};
$self->{'separator'} = "\r\n--$boundary\r\n";
$self->{'final_separator'} = "\r\n--$boundary--\r\n";