1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[338] Ugly code rejecting submit when buildrequires are missing</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd>338</dd>
<dt>Author</dt> <dd>pterjan</dd>
<dt>Date</dt> <dd>2011-01-22 15:49:03 +0100 (Sat, 22 Jan 2011)</dd>
</dl>
<h3>Log Message</h3>
<pre>Ugly code rejecting submit when buildrequires are missing</pre>
<h3>Added Paths</h3>
<ul>
<li><a href="#build_systemmdvyourisubmittrunklibYouriSubmitCheckDepspm">build_system/mdv-youri-submit/trunk/lib/Youri/Submit/Check/Deps.pm</a></li>
</ul>
</div>
<div id="patch"><pre>
<a id="build_systemmdvyourisubmittrunklibYouriSubmitCheckDepspm">Added: build_system/mdv-youri-submit/trunk/lib/Youri/Submit/Check/Deps.pm</a>
===================================================================
--- build_system/mdv-youri-submit/trunk/lib/Youri/Submit/Check/Deps.pm (rev 0)
+++ build_system/mdv-youri-submit/trunk/lib/Youri/Submit/Check/Deps.pm 2011-01-22 14:49:03 UTC (rev 338)
@@ -0,0 +1,87 @@
+package Youri::Submit::Check::Deps;
+
+=head1 NAME
+
+Youri::Submit::Check::Deps - Check dependencies
+
+=head1 DESCRIPTION
+
+This check plugin rejects packages with unresolved dependencies.
+
+=cut
+
+use warnings;
+use strict;
+use Carp;
+use Youri::Media::URPM;
+use base qw/Youri::Submit::Check/;
+
+sub resolvedep {
+ my ($media, @requires) = @_;
+
+ my @errors;
+ my $index = sub {
+ my ($package) = @_;
+
+ my @provides = $package->get_provides();
+
+ @requires = grep {
+ my $require = $_;
+ my $notfound = 1;
+ foreach my $provide (@provides) {
+ next unless $provide->[Youri::Package::DEPENDENCY_NAME] eq $require->[Youri::Package::DEPENDENCY_NAME];
+ if ($require->[Youri::Package::DEPENDENCY_RANGE]) {
+ next unless $package->check_ranges_compatibility($provide->[Youri::Package::DEPENDENCY_RANGE], $require->[Youri::Package::DEPENDENCY_RANGE]);
+ }
+ $notfound = 0;
+ }
+
+ if ($notfound && $require->[Youri::Package::DEPENDENCY_NAME] =~ m|/|) {
+ foreach my $file ($package->get_files()) {
+ next unless $file eq $require->[Youri::Package::DEPENDENCY_NAME];
+ $notfound = 0;
+ last;
+ }
+ }
+ $notfound;
+ } @requires;
+ };
+ $media->traverse_headers($index);
+ foreach my $require (@requires) {
+ push (@errors, "Unresolved dep on " . $require->[Youri::Package::DEPENDENCY_NAME]);
+ }
+ return @errors;
+}
+
+sub run {
+ my ($self, $package, $repository, $target, $define) = @_;
+ croak "Not a class method" unless ref $self;
+
+ # FIXME Define some Youri::Media with allowed_deps in the config and
+ # match target + section to a media
+ my $section = $repository->_get_section($package, $target, $define);
+ return unless $target eq "cauldron" && $section eq 'core/release';
+
+ my @requires = $package->get_requires();
+
+ my $path = $repository->get_install_root() . "/" . $target;
+ # FIXME we need dependencies on all archs except for ExclusiveArch
+ my $arch = 'i586';
+# foreach my $arch ($repository->get_extra_arches()) {
+ my $media = new Youri::Media::URPM(name => "core.".$arch,
+ type => "binary",
+ hdlist => "$path/$arch/media/$section/media_info/hdlist.cz");
+ return resolvedep($media, @requires);
+# }
+
+}
+
+=head1 COPYRIGHT AND LICENSE
+
+Copyright (C) 2011, YOURI project
+
+This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself.
+
+=cut
+
+1;
</pre></div>
</body>
</html>
|
