zarb-ml/mageia-dev/attachments/20120404/d21fc6fd/attachment.html


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23

<br><br><div class="gmail_quote">On Wed, Apr 4, 2012 at 09:01, Thierry Vignaud <span dir="ltr">&lt;<a href="mailto:thierry.vignaud@gmail.com">thierry.vignaud@gmail.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class="im">On 4 April 2012 01:01,  &lt;<a href="mailto:root@mageia.org">root@mageia.org</a>&gt; wrote:<br>
&gt; Revision 3909 Author pterjan Date 2012-04-04 01:01:59 +0200 (Wed, 04 Apr<br>
&gt; 2012)<br>
&gt;<br>
&gt; Log Message<br>
&gt;<br>
&gt; Drop check_chroot<br>
<br>
</div>A minor comment: it hasn&#39;t actually been dropped<br>
I think a better changelog would have been:<br>
<br>
&quot;(check_chroot) merge it in check_build_chroot()&quot;<br></blockquote><div> </div><div>Indeed, I&#39;ll improve log messages</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


Also, you didn&#39;t comment the call to create_build_chroot() instead<br>
of to create_chroot().<br></blockquote><div> </div><div>Indeed, this was an extension of the change I amended before commit when I noticed the call with those options that I was moving had a dedicated function.</div><div>

I should probably have done another commit</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Not that it matters a lot since create_build_chroot() got killed a little<br>
later but it would make history easier to read in 6 months (which it<br>
is already not for previous years :-( )<br></blockquote><div><br></div></div>