1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] RFC: Patch e2fsprogs to not print the "clean" message on fsck.
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20RFC%3A%20Patch%20e2fsprogs%20to%20not%20print%20the%20%22clean%22%0A%20message%20on%20fsck.&In-Reply-To=%3C51408716.8000002%40colin.guthr.ie%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="023465.html">
<LINK REL="Next" HREF="023478.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] RFC: Patch e2fsprogs to not print the "clean" message on fsck.</H1>
<B>Colin Guthrie</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20RFC%3A%20Patch%20e2fsprogs%20to%20not%20print%20the%20%22clean%22%0A%20message%20on%20fsck.&In-Reply-To=%3C51408716.8000002%40colin.guthr.ie%3E"
TITLE="[Mageia-dev] RFC: Patch e2fsprogs to not print the "clean" message on fsck.">mageia at colin.guthr.ie
</A><BR>
<I>Wed Mar 13 15:03:02 CET 2013</I>
<P><UL>
<LI>Previous message: <A HREF="023465.html">[Mageia-dev] RFC: Patch e2fsprogs to not print the "clean" message on fsck.
</A></li>
<LI>Next message: <A HREF="023478.html">[Mageia-dev] RFC: Patch e2fsprogs to not print the "clean" message on fsck.
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#23467">[ date ]</a>
<a href="thread.html#23467">[ thread ]</a>
<a href="subject.html#23467">[ subject ]</a>
<a href="author.html#23467">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>'Twas brillig, and Colin Guthrie at 13/03/13 12:35 did gyre and gimble:
><i> Hi,
</I>><i>
</I>><i> I would like to propose that we push a patch to e2fsprogs to make it not
</I>><i> print out the "clean" message when it checks the filesystem.
</I>><i>
</I>><i> In my current boot (which is an experiment without initrds), it prints
</I>><i> this message over the top of plymouth and stays during the nice fade
</I>><i> transition to gdm and generally makes the boot ugly.
</I>><i>
</I>><i> I believe only the e2fsprogs print this message and the others do not
</I>><i> e.g. see this comparison with XFS:
</I>><i>
</I>><i> [<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at jimmy</A> ~]# dd if=/dev/zero of=xfs.img bs=1M count=100 >/dev/null
</I>><i> 2>&1; mkfs.xfs xfs.img >/dev/null 2>&1; xfs_check xfs.img
</I>><i> [<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at jimmy</A> ~]# dd if=/dev/zero of=ext4.img bs=1M count=100 >/dev/null
</I>><i> 2>&1; mkfs.ext4 -F ext4.img >/dev/null 2>&1; fsck.ext4 -a ext4.img
</I>><i> ext4.img: clean, 11/25688 files, 8896/102400 blocks
</I>><i>
</I>><i>
</I>><i>
</I>><i> My patch would propose to not print the "clean" message when the -a
</I>><i> option was passed. This is similar logic which prevents showing the
</I>><i> version when -a is passed.
</I>><i>
</I>><i> I've not tested this but I will before committing if no-one disapproves
</I>><i> of this approach.
</I>><i>
</I>><i> --- e2fsprogs-1.42.7/e2fsck/unix.c.orig 2013-03-13 10:57:22.349126868 +0000
</I>><i> +++ e2fsprogs-1.42.7/e2fsck/unix.c 2013-03-13 12:33:08.340522834 +0000
</I>><i> @@ -421,13 +421,14 @@
</I>><i> }
</I>><i>
</I>><i> /* Print the summary message when we're skipping a full check */
</I>><i> - log_out(ctx, _("%s: clean, %u/%u files, %llu/%llu blocks"),
</I>><i> - ctx->device_name,
</I>><i> - fs->super->s_inodes_count - fs->super->s_free_inodes_count,
</I>><i> - fs->super->s_inodes_count,
</I>><i> - ext2fs_blocks_count(fs->super) -
</I>><i> - ext2fs_free_blocks_count(fs->super),
</I>><i> - ext2fs_blocks_count(fs->super));
</I>><i> + if (!(ctx->options & E2F_OPT_PREEN))
</I>><i> + log_out(ctx, _("%s: clean, %u/%u files, %llu/%llu blocks"),
</I>><i> + ctx->device_name,
</I>><i> + fs->super->s_inodes_count - fs->super->s_free_inodes_count,
</I>><i> + fs->super->s_inodes_count,
</I>><i> + ext2fs_blocks_count(fs->super) -
</I>><i> + ext2fs_free_blocks_count(fs->super),
</I>><i> + ext2fs_blocks_count(fs->super));
</I>><i> next_check = 100000;
</I>><i> if (fs->super->s_max_mnt_count > 0) {
</I>><i> next_check = fs->super->s_max_mnt_count - fs->super->s_mnt_count;
</I>><i>
</I>
FWIW, this patch is a bit wrong (as it still prints out a newline and
some other fluff about when the next check is etc.) and it causes a test
to fail.
But an updated and tested patch fixes it up. If there are no complaints,
I'll push it.
Cheers
Col
--
Colin Guthrie
colin(at)mageia.org
<A HREF="http://colin.guthr.ie/">http://colin.guthr.ie/</A>
Day Job:
Tribalogic Limited <A HREF="http://www.tribalogic.net/">http://www.tribalogic.net/</A>
Open Source:
Mageia Contributor <A HREF="http://www.mageia.org/">http://www.mageia.org/</A>
PulseAudio Hacker <A HREF="http://www.pulseaudio.org/">http://www.pulseaudio.org/</A>
Trac Hacker <A HREF="http://trac.edgewall.org/">http://trac.edgewall.org/</A>
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="023465.html">[Mageia-dev] RFC: Patch e2fsprogs to not print the "clean" message on fsck.
</A></li>
<LI>Next message: <A HREF="023478.html">[Mageia-dev] RFC: Patch e2fsprogs to not print the "clean" message on fsck.
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#23467">[ date ]</a>
<a href="thread.html#23467">[ thread ]</a>
<a href="subject.html#23467">[ subject ]</a>
<a href="author.html#23467">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
