1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [7324] (call_blkid) always bypass blkid cache
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B7324%5D%20%28call_blkid%29%20always%20bypass%0A%09blkid%20cache&In-Reply-To=%3CCA%2BCX%2Bbgc142YrJVc%2BpKkZu_bo%3DLq9aZSUk-1jO%3D47KN%3DV3DHBw%40mail.gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="022853.html">
<LINK REL="Next" HREF="022849.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [7324] (call_blkid) always bypass blkid cache</H1>
<B>Pascal Terjan</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B7324%5D%20%28call_blkid%29%20always%20bypass%0A%09blkid%20cache&In-Reply-To=%3CCA%2BCX%2Bbgc142YrJVc%2BpKkZu_bo%3DLq9aZSUk-1jO%3D47KN%3DV3DHBw%40mail.gmail.com%3E"
TITLE="[Mageia-dev] [soft-commits] [7324] (call_blkid) always bypass blkid cache">pterjan at gmail.com
</A><BR>
<I>Thu Feb 14 15:34:55 CET 2013</I>
<P><UL>
<LI>Previous message: <A HREF="022853.html">[Mageia-dev] Freeze push: mutter 3.6.3
</A></li>
<LI>Next message: <A HREF="022849.html">[Mageia-dev] [soft-commits] [7324] (call_blkid) always bypass blkid cache
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#22848">[ date ]</a>
<a href="thread.html#22848">[ thread ]</a>
<a href="subject.html#22848">[ subject ]</a>
<a href="author.html#22848">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On Thu, Feb 14, 2013 at 2:22 PM, <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A>> wrote:
><i> **
</I>><i> Revision 7324 Author colin Date 2013-02-14 15:22:44 +0100 (Thu, 14 Feb
</I>><i> 2013) Log Message
</I>><i>
</I>><i> (call_blkid) always bypass blkid cache
</I>><i>
</I>><i> This reverts the use of the blkid cache.
</I>><i>
</I>><i> This cache is a broken concept and should not be used. It's only
</I>><i> intended to be used for LABEL/UUID conversion.
</I>><i>
</I>><i> Please add a comment in the code :)
</I>
><i>
</I>><i> From the upstream maintainer:
</I>><i> <kzak> coling: -p provides more information, the cache is designed for
</I>><i> LABEL/UUID conversion -- and the goal is to avoid the cache if possible
</I>><i> (it's mostly for backward compatibility). The ideal solution is to read
</I>><i> the information from udev DB.
</I>><i> <kzak> coling: man blkid (at least the latest version contains some hint
</I>><i> about this issue)
</I>><i> <kzak> coling: I'd like to learn people to use lsblk -- it's designed
</I>><i> more friendly for end-users as well as for scripts and it reads info
</I>><i> from udev, libblkid is only fallback here.
</I>><i>
</I>><i> Longer term we should kill off the use of blkid and perhaps move to
</I>><i> lsblk or some perl-udev (if such a thing exists) usage instead:
</I>><i>
</I>><i> <kay> coling: avoid the blkid cache, it is a completely broken idea
</I>><i> <kay> kzak: you should really kill that thing :)
</I>><i> <kzak> kay: I'd like to kill blkid at all and keep it as "to test the
</I>><i> library" binary...
</I>><i> <kay> kzak: tools with options like that talk for their sanity
</I>><i> themselves :) " -g Perform a garbage collection pass on the blkid
</I>><i> cache to remove devices which no longer exist."
</I>><i> <kay> kzak: it's just silly, really silly to ever do that :)
</I>><i> <kay> kzak: yeah, sounds fine to let blkid and its cache die in the long
</I>><i> run
</I>><i> <kzak> lsblk is maintainable and extendable -- fix blkid(8) is
</I>><i> impossible to fix...
</I>><i>
</I>><i> This reverts r6891.
</I>><i>
</I>><i> Modified Paths
</I>><i>
</I>><i> - drakx/trunk/perl-install/NEWS<#13cd91629257f7c0_drakxtrunkperlinstallNEWS>
</I>><i> - drakx/trunk/perl-install/fs/type.pm<#13cd91629257f7c0_drakxtrunkperlinstallfstypepm>
</I>><i> - drakx/trunk/perl-install/install/NEWS<#13cd91629257f7c0_drakxtrunkperlinstallinstallNEWS>
</I>><i>
</I>><i> Modified: drakx/trunk/perl-install/NEWS
</I>><i> ===================================================================
</I>><i> --- drakx/trunk/perl-install/NEWS 2013-02-14 01:39:37 UTC (rev 7323)
</I>><i> +++ drakx/trunk/perl-install/NEWS 2013-02-14 14:22:44 UTC (rev 7324)
</I>><i> @@ -1,3 +1,5 @@
</I>><i> +- always bypass blkid cache (the cache only includes a subset of the data we need)
</I>><i> +
</I>><i> Version 15.19 - 16 January 2013
</I>><i>
</I>><i> - update translations
</I>><i> Modified: drakx/trunk/perl-install/fs/type.pm
</I>><i> ===================================================================
</I>><i> --- drakx/trunk/perl-install/fs/type.pm 2013-02-14 01:39:37 UTC (rev 7323)
</I>><i> +++ drakx/trunk/perl-install/fs/type.pm 2013-02-14 14:22:44 UTC (rev 7324)
</I>><i> @@ -273,7 +273,7 @@
</I>><i>
</I>><i> my %h = map {
</I>><i> if_(/(.*?)=(.*)/, $1 => $2);
</I>><i> - } run_program::get_stdout_raw({ timeout => 30 }, 'blkid', '2>', '/dev/null', '-o', 'udev', devices::make($part->{device}));
</I>><i> + } run_program::get_stdout_raw({ timeout => 30 }, 'blkid', '2>', '/dev/null', '-o', 'udev', '-p', devices::make($part->{device}));
</I>><i>
</I>><i> \%h;
</I>><i> }
</I>><i> Modified: drakx/trunk/perl-install/install/NEWS
</I>><i> ===================================================================
</I>><i> --- drakx/trunk/perl-install/install/NEWS 2013-02-14 01:39:37 UTC (rev 7323)
</I>><i> +++ drakx/trunk/perl-install/install/NEWS 2013-02-14 14:22:44 UTC (rev 7324)
</I>><i> @@ -1,3 +1,5 @@
</I>><i> +- always bypass blkid cache (the cache only includes a subset of the data we need)
</I>><i> +
</I>><i> Version 15.20 - 21 January 2013
</I>><i>
</I>><i> - use modprobe instead of insmod (mga#8676)
</I>><i>
</I>><i>
</I>><i>
</I>-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/mageia-dev/attachments/20130214/7ed5ad66/attachment.html>
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="022853.html">[Mageia-dev] Freeze push: mutter 3.6.3
</A></li>
<LI>Next message: <A HREF="022849.html">[Mageia-dev] [soft-commits] [7324] (call_blkid) always bypass blkid cache
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#22848">[ date ]</a>
<a href="thread.html#22848">[ thread ]</a>
<a href="subject.html#22848">[ subject ]</a>
<a href="author.html#22848">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
